[PATCH 1/2] i2c: s3c2410: Initialize i2c->gpios[] with requested gpio lines

[PATCH 1/2] i2c: s3c2410: Initialize i2c->gpios[] with requested gpio lines

[Inderpal Singh]

i2c->gpios[] is being used to free_gpios but it's not getting initialized.

Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
---
 drivers/i2c/busses/i2c-s3c2410.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index a290d08..f1d1f1e 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -875,6 +875,8 @@ static int s3c24xx_i2c_parse_dt_gpio(struct s3c24xx_i2c *i2c)
 			dev_err(i2c->dev, "gpio [%d] request failed\n", gpio);
 			goto free_gpio;
 		}
+
+		i2c->gpios[idx] = gpio;
 	}
 	return 0;
 
-- 
1.7.9.5

[PATCH 2/2] i2c: s3c2410: free gpios in suspend function

[Inderpal Singh]

While resuming the gpios are being requested again, hence we need
to free the gpios before going to suspend otherwise it gives
"gpio request failed" errors while resuming.

Signed-off-by: Inderpal Singh <inderpal.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 drivers/i2c/busses/i2c-s3c2410.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index f1d1f1e..55c1762 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1172,6 +1172,7 @@ static int s3c24xx_i2c_suspend_noirq(struct device *dev)
 	struct platform_device *pdev = to_platform_device(dev);
 	struct s3c24xx_i2c *i2c = platform_get_drvdata(pdev);
 
+	s3c24xx_i2c_dt_gpio_free(i2c);
 	i2c->suspended = 1;
 
 	return 0;
-- 
1.7.9.5

Re: [PATCH 2/2] i2c: s3c2410: free gpios in suspend function

[Inderpal Singh]

On 27 December 2012 09:39, Inderpal Singh <inderpal.singh@linaro.org> wrote:
> While resuming the gpios are being requested again, hence we need
> to free the gpios before going to suspend otherwise it gives
> "gpio request failed" errors while resuming.
>
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index f1d1f1e..55c1762 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1172,6 +1172,7 @@ static int s3c24xx_i2c_suspend_noirq(struct device *dev)
>         struct platform_device *pdev = to_platform_device(dev);
>         struct s3c24xx_i2c *i2c = platform_get_drvdata(pdev);
>
> +       s3c24xx_i2c_dt_gpio_free(i2c);
>         i2c->suspended = 1;
>
>         return 0;
> --
> 1.7.9.5
>

Please ignore this patch as this has been sent already at

http://dics.voicecontrol.ro/process_mails/arata_discutia/174658/%5BPATCH%5D_i2c:_s3c2410:_Add_fix_for_i2c_suspend_resume.html

Sorry for the noise !!!

Re: [PATCH 1/2] i2c: s3c2410: Initialize i2c->gpios[] with requested gpio lines

[Inderpal Singh]

On 27 December 2012 09:39, Inderpal Singh <inderpal.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> i2c->gpios[] is being used to free_gpios but it's not getting initialized.
>
> Signed-off-by: Inderpal Singh <inderpal.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index a290d08..f1d1f1e 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -875,6 +875,8 @@ static int s3c24xx_i2c_parse_dt_gpio(struct s3c24xx_i2c *i2c)
>                         dev_err(i2c->dev, "gpio [%d] request failed\n", gpio);
>                         goto free_gpio;
>                 }
> +
> +               i2c->gpios[idx] = gpio;
>         }
>         return 0;
>
> --
> 1.7.9.5
>

Please ignore this patch as this has been sent already at

http://www.mail-archive.com/linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg10781.html

Sorry for the noise !!!