* [PATCH] i2c-tools: eeprog/Module.mk: Add missing dependency
@ 2017-12-18 14:11 maxin.john
2017-12-19 12:53 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: maxin.john @ 2017-12-18 14:11 UTC (permalink / raw)
To: linux-i2c; +Cc: jdelvare, Maxin B. John
From: "Maxin B. John" <maxin.john@intel.com>
Absence of this dependency caused parallel build to run into a race
and break.
Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
eeprog/Module.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/eeprog/Module.mk b/eeprog/Module.mk
index 9d36869..d215855 100644
--- a/eeprog/Module.mk
+++ b/eeprog/Module.mk
@@ -20,7 +20,7 @@ EEPROG_TARGETS := eeprog
# Programs
#
-$(EEPROG_DIR)/eeprog: $(EEPROG_DIR)/eeprog.o $(EEPROG_DIR)/24cXX.o
+$(EEPROG_DIR)/eeprog: $(EEPROG_DIR)/eeprog.o $(EEPROG_DIR)/24cXX.o $(LIB_DEPS)
$(CC) $(LDFLAGS) -o $@ $^ $(EEPROG_LDFLAGS)
#
--
2.4.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c-tools: eeprog/Module.mk: Add missing dependency
2017-12-18 14:11 [PATCH] i2c-tools: eeprog/Module.mk: Add missing dependency maxin.john
@ 2017-12-19 12:53 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2017-12-19 12:53 UTC (permalink / raw)
To: maxin.john; +Cc: linux-i2c, Maxin B. John
On Mon, 18 Dec 2017 16:11:37 +0200, maxin.john@gmail.com wrote:
> From: "Maxin B. John" <maxin.john@intel.com>
>
> Absence of this dependency caused parallel build to run into a race
> and break.
>
> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> ---
> eeprog/Module.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eeprog/Module.mk b/eeprog/Module.mk
> index 9d36869..d215855 100644
> --- a/eeprog/Module.mk
> +++ b/eeprog/Module.mk
> @@ -20,7 +20,7 @@ EEPROG_TARGETS := eeprog
> # Programs
> #
>
> -$(EEPROG_DIR)/eeprog: $(EEPROG_DIR)/eeprog.o $(EEPROG_DIR)/24cXX.o
> +$(EEPROG_DIR)/eeprog: $(EEPROG_DIR)/eeprog.o $(EEPROG_DIR)/24cXX.o $(LIB_DEPS)
> $(CC) $(LDFLAGS) -o $@ $^ $(EEPROG_LDFLAGS)
>
> #
Good catch, sorry for missing that one. Applied, thanks.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-19 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-18 14:11 [PATCH] i2c-tools: eeprog/Module.mk: Add missing dependency maxin.john
2017-12-19 12:53 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox