s390 allmodconfig

s390 allmodconfig

[Andrew Morton]

drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'

Some missing Kconfig dependency.  s390 can't do IO :)

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: s390 allmodconfig

[Jean Delvare]

Hi Andrew,

On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote:
> drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
> drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
> drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
> drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
> drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
> drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
> drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
> drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
> 
> Some missing Kconfig dependency.  s390 can't do IO :)

Where is this failure happening? In Linus' tree, I2C depends on
HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So
I fail to see how a make allmodconfig can select I2C_OCORES on s390.
Can you share the .config file?

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: s390 allmodconfig

[Andrew Morton]

On Fri, 29 Aug 2008 10:45:33 +0200 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:

> Hi Andrew,
> 
> On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote:
> > drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
> > drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
> > drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
> > drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
> > drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
> > drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
> > drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
> > drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
> > 
> > Some missing Kconfig dependency.  s390 can't do IO :)
> 
> Where is this failure happening? In Linus' tree, I2C depends on
> HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So
> I fail to see how a make allmodconfig can select I2C_OCORES on s390.
> Can you share the .config file?
> 

<bisects>

It's
power-support-for-texas-instruments-bq27x00-battery-managers.patch,
which does

--- a/drivers/power/Kconfig~power-support-for-texas-instruments-bq27x00-battery-managers
+++ a/drivers/power/Kconfig
@@ -62,4 +62,17 @@ config BATTERY_PALMTX
 	help
 	  Say Y to enable support for the battery in Palm T|X.
 
+config BATTERY_BQ27x00
+	tristate "BQ27x00 battery driver"
+	help
+	  Say Y here to enable support for batteries with BQ27000 or
+	  BQ27200 chip.
+
+config BATTERY_BQ27200
+	bool "BQ27200 battery driver"
+	depends on BATTERY_BQ27x00
+	select I2C
+	help
+	  Say Y here to enable support for batteries with BQ27200(I2C) chip.
+


which enables I2C stuff in s390 allmodconfig.  Should it be `depends on'?

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: s390 allmodconfig

[Rodolfo Giometti]

[-- Attachment #1.1: Type: text/plain, Size: 2469 bytes --]

On Fri, Aug 29, 2008 at 02:04:09AM -0700, Andrew Morton wrote:
> On Fri, 29 Aug 2008 10:45:33 +0200 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> 
> > Hi Andrew,
> > 
> > On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote:
> > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
> > > drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
> > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
> > > drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
> > > drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
> > > drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
> > > drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
> > > drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
> > > 
> > > Some missing Kconfig dependency.  s390 can't do IO :)
> > 
> > Where is this failure happening? In Linus' tree, I2C depends on
> > HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So
> > I fail to see how a make allmodconfig can select I2C_OCORES on s390.
> > Can you share the .config file?
> > 
> 
> <bisects>
> 
> It's
> power-support-for-texas-instruments-bq27x00-battery-managers.patch,
> which does
> 
> --- a/drivers/power/Kconfig~power-support-for-texas-instruments-bq27x00-battery-managers
> +++ a/drivers/power/Kconfig
> @@ -62,4 +62,17 @@ config BATTERY_PALMTX
>  	help
>  	  Say Y to enable support for the battery in Palm T|X.
>  
> +config BATTERY_BQ27x00
> +	tristate "BQ27x00 battery driver"
> +	help
> +	  Say Y here to enable support for batteries with BQ27000 or
> +	  BQ27200 chip.
> +
> +config BATTERY_BQ27200
> +	bool "BQ27200 battery driver"
> +	depends on BATTERY_BQ27x00
> +	select I2C
> +	help
> +	  Say Y here to enable support for batteries with BQ27200(I2C) chip.
> +
> 
> 
> which enables I2C stuff in s390 allmodconfig.  Should it be `depends on'?

Yes.

	depends on I2C && BATTERY_BQ27x00

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org
Linux Device Driver                          giometti-k2GhghHVRtY@public.gmane.org
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: s390 allmodconfig

[Jean Delvare]

On Fri, 29 Aug 2008 11:09:18 +0200, Rodolfo Giometti wrote:
> On Fri, Aug 29, 2008 at 02:04:09AM -0700, Andrew Morton wrote:
> > On Fri, 29 Aug 2008 10:45:33 +0200 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> > 
> > > Hi Andrew,
> > > 
> > > On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote:
> > > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
> > > > drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
> > > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
> > > > drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
> > > > drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
> > > > drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
> > > > drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
> > > > drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
> > > > 
> > > > Some missing Kconfig dependency.  s390 can't do IO :)
> > > 
> > > Where is this failure happening? In Linus' tree, I2C depends on
> > > HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So
> > > I fail to see how a make allmodconfig can select I2C_OCORES on s390.
> > > Can you share the .config file?
> > > 
> > 
> > <bisects>
> > 
> > It's
> > power-support-for-texas-instruments-bq27x00-battery-managers.patch,
> > which does
> > 
> > --- a/drivers/power/Kconfig~power-support-for-texas-instruments-bq27x00-battery-managers
> > +++ a/drivers/power/Kconfig
> > @@ -62,4 +62,17 @@ config BATTERY_PALMTX
> >  	help
> >  	  Say Y to enable support for the battery in Palm T|X.
> >  
> > +config BATTERY_BQ27x00
> > +	tristate "BQ27x00 battery driver"
> > +	help
> > +	  Say Y here to enable support for batteries with BQ27000 or
> > +	  BQ27200 chip.
> > +
> > +config BATTERY_BQ27200
> > +	bool "BQ27200 battery driver"
> > +	depends on BATTERY_BQ27x00
> > +	select I2C
> > +	help
> > +	  Say Y here to enable support for batteries with BQ27200(I2C) chip.
> > +
> > 
> > 
> > which enables I2C stuff in s390 allmodconfig.  Should it be `depends on'?
> 
> Yes.
> 
> 	depends on I2C && BATTERY_BQ27x00
> 

Yes please. Ideally nothing but arch files should ever select I2C.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c