* [PATCH] drivers/i2c: Include SPDX-license-identifier
@ 2018-06-21 9:40 Mawanda Henry
2018-06-21 9:45 ` Peter Rosin
0 siblings, 1 reply; 2+ messages in thread
From: Mawanda Henry @ 2018-06-21 9:40 UTC (permalink / raw)
To: mawanda111; +Cc: wsa, linux-i2c, linux-kernel
including the SPDX license identifier header makes it easy for
developers and machines to know the lecense that is governing the file
Signed-off-by: Mawanda Henry <mawandahenrynaco@gmail.com>
---
drivers/i2c/i2c-core-slave.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/i2c-core-slave.c b/drivers/i2c/i2c-core-slave.c
index 4a78c65..883ca836 100644
--- a/drivers/i2c/i2c-core-slave.c
+++ b/drivers/i2c/i2c-core-slave.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* Linux I2C core slave support code
*
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/i2c: Include SPDX-license-identifier
2018-06-21 9:40 [PATCH] drivers/i2c: Include SPDX-license-identifier Mawanda Henry
@ 2018-06-21 9:45 ` Peter Rosin
0 siblings, 0 replies; 2+ messages in thread
From: Peter Rosin @ 2018-06-21 9:45 UTC (permalink / raw)
To: Mawanda Henry, mawanda111; +Cc: wsa, linux-i2c, linux-kernel
On 2018-06-21 11:40, Mawanda Henry wrote:
> including the SPDX license identifier header makes it easy for
> developers and machines to know the lecense that is governing the file
If you do changes like this, you should also remove the actual
license text (it follows later in the comment in this case). And
more importantly, you should make *sure* that you use the correct
SPDX tag, which you don't in this case.
So, you need to fix those issues.
Cheers,
Peter
> Signed-off-by: Mawanda Henry <mawandahenrynaco@gmail.com>
> ---
> drivers/i2c/i2c-core-slave.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/i2c-core-slave.c b/drivers/i2c/i2c-core-slave.c
> index 4a78c65..883ca836 100644
> --- a/drivers/i2c/i2c-core-slave.c
> +++ b/drivers/i2c/i2c-core-slave.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Linux I2C core slave support code
> *
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-21 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-21 9:40 [PATCH] drivers/i2c: Include SPDX-license-identifier Mawanda Henry
2018-06-21 9:45 ` Peter Rosin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox