* [PATCH] i2c: brcmstb: Allow enabling the driver on DSL SoCs
@ 2018-09-28 22:39 Florian Fainelli
2018-09-29 7:55 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2018-09-28 22:39 UTC (permalink / raw)
To: linux-kernel
Cc: kdasu.kdev, Florian Fainelli, Wolfram Sang, Jarkko Nikula,
Jean Delvare, Andy Shevchenko, M'boumba Cedric Madianga,
Karthikeyan Ramasubramanian, Geert Uytterhoeven,
Pierre-Yves MORDRET, Eddie James, Ard Biesheuvel,
Manivannan Sadhasivam, Arnd Bergmann, Heikki Krogerus,
open list:I2C SUBSYSTEM HOST DRIVERS
ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the
same controller, make it possible to select the STB driver and update
the Kconfig and help text a bit.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/i2c/busses/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 451d4ae50e66..fc3fd987f718 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -432,12 +432,13 @@ config I2C_BCM_KONA
If you do not need KONA I2C interface, say N.
config I2C_BRCMSTB
- tristate "BRCM Settop I2C controller"
- depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+ tristate "BRCM Settop/DSL I2C controller"
+ depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST || \
+ ARCH_BCM_63XX
default y
help
If you say yes to this option, support will be included for the
- I2C interface on the Broadcom Settop SoCs.
+ I2C interface on the Broadcom Settop/DSL SoCs.
If you do not need I2C interface, say N.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: brcmstb: Allow enabling the driver on DSL SoCs
2018-09-28 22:39 [PATCH] i2c: brcmstb: Allow enabling the driver on DSL SoCs Florian Fainelli
@ 2018-09-29 7:55 ` Geert Uytterhoeven
2018-09-29 20:37 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-09-29 7:55 UTC (permalink / raw)
To: Florian Fainelli
Cc: Linux Kernel Mailing List, Kamal Dasu, Wolfram Sang,
Jarkko Nikula, Jean Delvare, Andy Shevchenko,
M'boumba Cedric Madianga, kramasub, Pierre-Yves MORDRET,
eajames, Ard Biesheuvel, manivannan.sadhasivam, Arnd Bergmann,
Heikki Krogerus, Linux I2C
Hi Florian,
On Sat, Sep 29, 2018 at 12:40 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
> ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the
> same controller, make it possible to select the STB driver and update
> the Kconfig and help text a bit.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks for your patch!
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -432,12 +432,13 @@ config I2C_BCM_KONA
> If you do not need KONA I2C interface, say N.
>
> config I2C_BRCMSTB
> - tristate "BRCM Settop I2C controller"
> - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> + tristate "BRCM Settop/DSL I2C controller"
> + depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST || \
> + ARCH_BCM_63XX
I think it would be good to keep the "|| COMPILE_TEST" as the last dependency.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: brcmstb: Allow enabling the driver on DSL SoCs
2018-09-29 7:55 ` Geert Uytterhoeven
@ 2018-09-29 20:37 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2018-09-29 20:37 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux Kernel Mailing List, Kamal Dasu, Wolfram Sang,
Jarkko Nikula, Jean Delvare, Andy Shevchenko,
M'boumba Cedric Madianga, kramasub, Pierre-Yves MORDRET,
eajames, Ard Biesheuvel, manivannan.sadhasivam, Arnd Bergmann,
Heikki Krogerus, Linux I2C
On September 29, 2018 12:55:08 AM PDT, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>Hi Florian,
>
>On Sat, Sep 29, 2018 at 12:40 AM Florian Fainelli
><f.fainelli@gmail.com> wrote:
>> ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses
>the
>> same controller, make it possible to select the STB driver and update
>> the Kconfig and help text a bit.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
>Thanks for your patch!
>
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -432,12 +432,13 @@ config I2C_BCM_KONA
>> If you do not need KONA I2C interface, say N.
>>
>> config I2C_BRCMSTB
>> - tristate "BRCM Settop I2C controller"
>> - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>> + tristate "BRCM Settop/DSL I2C controller"
>> + depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST || \
>> + ARCH_BCM_63XX
>
>I think it would be good to keep the "|| COMPILE_TEST" as the last
>dependency.
Makes sense, v2 coming, thank you!
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-29 20:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-28 22:39 [PATCH] i2c: brcmstb: Allow enabling the driver on DSL SoCs Florian Fainelli
2018-09-29 7:55 ` Geert Uytterhoeven
2018-09-29 20:37 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox