* [PATCH v2] i2c: Update documentation to use .probe() again
@ 2023-06-27 6:45 Uwe Kleine-König
2023-06-27 11:44 ` Jean Delvare
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2023-06-27 6:45 UTC (permalink / raw)
To: Wolfram Sang; +Cc: kernel, Javier Martinez Canillas, Jean Delvare, linux-i2c
Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id
parameter") .probe() is the recommended callback to implement (again).
Reflect this in the documentation and don't mention .probe_new() any
more.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
changes since (implicit) v1 sent a moment ago:
- Fix whitespace. My editor seems to be configured to expand tabs to
spaces in rst files, but that's inconsitent with the tab style used
in that file.
Best regards
Uwe
Documentation/i2c/writing-clients.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/i2c/writing-clients.rst b/Documentation/i2c/writing-clients.rst
index b7d3ae7458f8..41ddc10f1ac7 100644
--- a/Documentation/i2c/writing-clients.rst
+++ b/Documentation/i2c/writing-clients.rst
@@ -46,7 +46,7 @@ driver model device node, and its I2C address.
},
.id_table = foo_idtable,
- .probe_new = foo_probe,
+ .probe = foo_probe,
.remove = foo_remove,
/* if device autodetection is needed: */
.class = I2C_CLASS_SOMETHING,
base-commit: 6995e2de6891c724bfeb2db33d7b87775f913ad1
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] i2c: Update documentation to use .probe() again
2023-06-27 6:45 [PATCH v2] i2c: Update documentation to use .probe() again Uwe Kleine-König
@ 2023-06-27 11:44 ` Jean Delvare
2023-06-27 12:16 ` Javier Martinez Canillas
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2023-06-27 11:44 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Wolfram Sang, kernel, Javier Martinez Canillas, linux-i2c
On Tue, 27 Jun 2023 08:45:22 +0200, Uwe Kleine-König wrote:
> Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id
> parameter") .probe() is the recommended callback to implement (again).
> Reflect this in the documentation and don't mention .probe_new() any
> more.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> changes since (implicit) v1 sent a moment ago:
>
> - Fix whitespace. My editor seems to be configured to expand tabs to
> spaces in rst files, but that's inconsitent with the tab style used
> in that file.
>
> Best regards
> Uwe
>
> Documentation/i2c/writing-clients.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/i2c/writing-clients.rst b/Documentation/i2c/writing-clients.rst
> index b7d3ae7458f8..41ddc10f1ac7 100644
> --- a/Documentation/i2c/writing-clients.rst
> +++ b/Documentation/i2c/writing-clients.rst
> @@ -46,7 +46,7 @@ driver model device node, and its I2C address.
> },
>
> .id_table = foo_idtable,
> - .probe_new = foo_probe,
> + .probe = foo_probe,
> .remove = foo_remove,
> /* if device autodetection is needed: */
> .class = I2C_CLASS_SOMETHING,
>
> base-commit: 6995e2de6891c724bfeb2db33d7b87775f913ad1
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] i2c: Update documentation to use .probe() again
2023-06-27 6:45 [PATCH v2] i2c: Update documentation to use .probe() again Uwe Kleine-König
2023-06-27 11:44 ` Jean Delvare
@ 2023-06-27 12:16 ` Javier Martinez Canillas
2023-08-05 16:54 ` Andi Shyti
2023-08-14 16:15 ` Wolfram Sang
3 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2023-06-27 12:16 UTC (permalink / raw)
To: Uwe Kleine-König, Wolfram Sang; +Cc: kernel, Jean Delvare, linux-i2c
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
Hello Uwe,
> Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id
> parameter") .probe() is the recommended callback to implement (again).
> Reflect this in the documentation and don't mention .probe_new() any
> more.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] i2c: Update documentation to use .probe() again
2023-06-27 6:45 [PATCH v2] i2c: Update documentation to use .probe() again Uwe Kleine-König
2023-06-27 11:44 ` Jean Delvare
2023-06-27 12:16 ` Javier Martinez Canillas
@ 2023-08-05 16:54 ` Andi Shyti
2023-08-14 16:15 ` Wolfram Sang
3 siblings, 0 replies; 5+ messages in thread
From: Andi Shyti @ 2023-08-05 16:54 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Wolfram Sang, kernel, Javier Martinez Canillas, Jean Delvare,
linux-i2c
Hi Uwe,
On Tue, Jun 27, 2023 at 08:45:22AM +0200, Uwe Kleine-König wrote:
> Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id
> parameter") .probe() is the recommended callback to implement (again).
> Reflect this in the documentation and don't mention .probe_new() any
> more.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] i2c: Update documentation to use .probe() again
2023-06-27 6:45 [PATCH v2] i2c: Update documentation to use .probe() again Uwe Kleine-König
` (2 preceding siblings ...)
2023-08-05 16:54 ` Andi Shyti
@ 2023-08-14 16:15 ` Wolfram Sang
3 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2023-08-14 16:15 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: kernel, Javier Martinez Canillas, Jean Delvare, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
On Tue, Jun 27, 2023 at 08:45:22AM +0200, Uwe Kleine-König wrote:
> Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id
> parameter") .probe() is the recommended callback to implement (again).
> Reflect this in the documentation and don't mention .probe_new() any
> more.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-14 16:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-27 6:45 [PATCH v2] i2c: Update documentation to use .probe() again Uwe Kleine-König
2023-06-27 11:44 ` Jean Delvare
2023-06-27 12:16 ` Javier Martinez Canillas
2023-08-05 16:54 ` Andi Shyti
2023-08-14 16:15 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox