From: Tyrone Ting <warp5tw@gmail.com>
To: avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, andi.shyti@kernel.org,
andriy.shevchenko@linux.intel.com, wsa@kernel.org,
rand.sec96@gmail.com, wsa+renesas@sang-engineering.com,
warp5tw@gmail.com, tali.perry@nuvoton.com,
Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com,
KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/7] i2c: npcm: Bug fixes read/write operation, checkpatch
Date: Fri, 30 Aug 2024 11:46:33 +0800 [thread overview]
Message-ID: <20240830034640.7049-1-kfting@nuvoton.com> (raw)
This patchset includes the following fixes:
- Restore the npcm_i2caddr array length to fix the smatch warning.
- Enable the target functionality in the interrupt handling routine
when the i2c transfer is about to finish.
- Correct the read/write operation procedure.
- Introduce a software flag to handle the bus error (BER) condition
which is not caused by the i2c transfer.
- Modify timeout calculation.
- Assign the client address earlier logically.
- Use an i2c frequency table for the frequency parameters assignment.
- Coding style fix.
The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.
Addressed comments from:
- kernel test robot : https://lore.kernel.org/oe-kbuild-all/
202408080319.de2B6PgU-lkp@intel.com/
- Dan Carpenter : https://lore.kernel.org/all/202408130818
.FgDP5uNm-lkp@intel.com/
- Andrew Jeffery : https://lore.kernel.org/lkml/
20240807100244.16872-7-kfting@nuvoton.com/T/
#m3ed3351bf59675bfe0de89c75aae1fb26cad5567
Changes since version 1:
- Restore the npcm_i2caddr array length to fix the smatch warning.
- Remove unused variables.
- Handle the condition where scl_table_cnt reaches to the maximum value.
- Fix the checkpatch warning.
Charles Boyer (1):
i2c: npcm: Enable slave in eob interrupt
Tyrone Ting (6):
i2c: npcm: restore slave addresses array length
i2c: npcm: correct the read/write operation procedure
i2c: npcm: use a software flag to indicate a BER condition
i2c: npcm: Modify timeout evaluation mechanism
i2c: npcm: Modify the client address assignment
i2c: npcm: use i2c frequency table
drivers/i2c/busses/i2c-npcm7xx.c | 276 +++++++++++++++++++------------
1 file changed, 172 insertions(+), 104 deletions(-)
base-commit: 5be63fc19fcaa4c236b307420483578a56986a37
--
2.34.1
next reply other threads:[~2024-08-30 3:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 3:46 Tyrone Ting [this message]
2024-08-30 3:46 ` [PATCH v2 1/7] i2c: npcm: restore slave addresses array length Tyrone Ting
2024-09-05 21:23 ` Andi Shyti
2024-09-06 2:23 ` Tyrone Ting
2024-09-05 21:36 ` Andi Shyti
2024-09-06 2:28 ` Tyrone Ting
2024-09-06 6:49 ` Andi Shyti
2024-09-06 11:40 ` Andy Shevchenko
2024-09-06 7:05 ` Andi Shyti
2024-09-06 8:01 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 2/7] i2c: npcm: correct the read/write operation procedure Tyrone Ting
2024-09-05 21:29 ` Andi Shyti
2024-09-08 10:39 ` Tali Perry
2024-09-09 1:49 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 3/7] i2c: npcm: use a software flag to indicate a BER condition Tyrone Ting
2024-09-05 21:33 ` Andi Shyti
2024-08-30 3:46 ` [PATCH v2 4/7] i2c: npcm: Modify timeout evaluation mechanism Tyrone Ting
2024-09-05 21:39 ` Andi Shyti
2024-09-08 10:47 ` Tali Perry
2024-09-09 1:47 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 5/7] i2c: npcm: Modify the client address assignment Tyrone Ting
2024-08-30 19:16 ` Andy Shevchenko
2024-09-02 1:40 ` Tyrone Ting
2024-09-02 11:54 ` Andy Shevchenko
2024-09-03 2:07 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 6/7] i2c: npcm: use i2c frequency table Tyrone Ting
2024-08-30 19:19 ` Andy Shevchenko
2024-09-01 15:53 ` Tali Perry
2024-09-02 11:53 ` Andy Shevchenko
2024-09-08 8:54 ` Tali Perry
2024-09-09 10:27 ` Andy Shevchenko
2024-09-05 21:43 ` Andi Shyti
2024-09-09 1:56 ` Tyrone Ting
2024-09-09 12:57 ` Andi Shyti
2024-09-10 1:11 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 7/7] i2c: npcm: Enable slave in eob interrupt Tyrone Ting
2024-09-08 10:50 ` Tali Perry
2024-09-08 10:58 ` [PATCH v2 0/7] i2c: npcm: Bug fixes read/write operation, checkpatch Tali Perry
2024-09-09 13:00 ` Andi Shyti
2024-09-10 1:12 ` Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830034640.7049-1-kfting@nuvoton.com \
--to=warp5tw@gmail.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=kfting@nuvoton.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rand.sec96@gmail.com \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox