public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Tyrone Ting <warp5tw@gmail.com>
To: avifishman70@gmail.com, tmaimon77@gmail.com,
	tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
	benjaminfair@google.com, andi.shyti@kernel.org,
	andriy.shevchenko@linux.intel.com, wsa@kernel.org,
	rand.sec96@gmail.com, wsa+renesas@sang-engineering.com,
	warp5tw@gmail.com, tali.perry@nuvoton.com,
	Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com,
	KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Charles Boyer <Charles.Boyer@fii-usa.com>,
	Vivekanand Veeracholan <vveerach@google.com>
Subject: [PATCH v2 7/7] i2c: npcm: Enable slave in eob interrupt
Date: Fri, 30 Aug 2024 11:46:40 +0800	[thread overview]
Message-ID: <20240830034640.7049-8-kfting@nuvoton.com> (raw)
In-Reply-To: <20240830034640.7049-1-kfting@nuvoton.com>

From: Charles Boyer <Charles.Boyer@fii-usa.com>

Nuvoton slave enable was in user space API call master_xfer, so it is
subject to delays from the OS scheduler. If the BMC is not enabled for
slave mode in time for master to send response, then it will NAK the
address match. Then the PLDM request timeout occurs.

If the slave enable is moved to the EOB interrupt service routine, then
the BMC can be ready in slave mode by the time it needs to receive a
response.

Signed-off-by: Charles Boyer <Charles.Boyer@fii-usa.com>
Signed-off-by: Vivekanand Veeracholan <vveerach@google.com>
Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
---
 drivers/i2c/busses/i2c-npcm7xx.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
index cac4ea0b69b8..5bdc1b5895ac 100644
--- a/drivers/i2c/busses/i2c-npcm7xx.c
+++ b/drivers/i2c/busses/i2c-npcm7xx.c
@@ -1781,6 +1781,12 @@ static int npcm_i2c_int_master_handler(struct npcm_i2c *bus)
 	    (FIELD_GET(NPCM_I2CCST3_EO_BUSY,
 		       ioread8(bus->reg + NPCM_I2CCST3)))) {
 		npcm_i2c_irq_handle_eob(bus);
+#if IS_ENABLED(CONFIG_I2C_SLAVE)
+		/* reenable slave if it was enabled */
+		if (bus->slave)
+			iowrite8((bus->slave->addr & 0x7F) | NPCM_I2CADDR_SAEN,
+				 bus->reg + NPCM_I2CADDR1);
+#endif
 		return 0;
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2024-08-30  3:49 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  3:46 [PATCH v2 0/7] i2c: npcm: Bug fixes read/write operation, checkpatch Tyrone Ting
2024-08-30  3:46 ` [PATCH v2 1/7] i2c: npcm: restore slave addresses array length Tyrone Ting
2024-09-05 21:23   ` Andi Shyti
2024-09-06  2:23     ` Tyrone Ting
2024-09-05 21:36   ` Andi Shyti
2024-09-06  2:28     ` Tyrone Ting
2024-09-06  6:49       ` Andi Shyti
2024-09-06 11:40     ` Andy Shevchenko
2024-09-06  7:05   ` Andi Shyti
2024-09-06  8:01     ` Tyrone Ting
2024-08-30  3:46 ` [PATCH v2 2/7] i2c: npcm: correct the read/write operation procedure Tyrone Ting
2024-09-05 21:29   ` Andi Shyti
2024-09-08 10:39     ` Tali Perry
2024-09-09  1:49     ` Tyrone Ting
2024-08-30  3:46 ` [PATCH v2 3/7] i2c: npcm: use a software flag to indicate a BER condition Tyrone Ting
2024-09-05 21:33   ` Andi Shyti
2024-08-30  3:46 ` [PATCH v2 4/7] i2c: npcm: Modify timeout evaluation mechanism Tyrone Ting
2024-09-05 21:39   ` Andi Shyti
2024-09-08 10:47     ` Tali Perry
2024-09-09  1:47       ` Tyrone Ting
2024-08-30  3:46 ` [PATCH v2 5/7] i2c: npcm: Modify the client address assignment Tyrone Ting
2024-08-30 19:16   ` Andy Shevchenko
2024-09-02  1:40     ` Tyrone Ting
2024-09-02 11:54       ` Andy Shevchenko
2024-09-03  2:07         ` Tyrone Ting
2024-08-30  3:46 ` [PATCH v2 6/7] i2c: npcm: use i2c frequency table Tyrone Ting
2024-08-30 19:19   ` Andy Shevchenko
2024-09-01 15:53     ` Tali Perry
2024-09-02 11:53       ` Andy Shevchenko
2024-09-08  8:54         ` Tali Perry
2024-09-09 10:27           ` Andy Shevchenko
2024-09-05 21:43   ` Andi Shyti
2024-09-09  1:56     ` Tyrone Ting
2024-09-09 12:57       ` Andi Shyti
2024-09-10  1:11         ` Tyrone Ting
2024-08-30  3:46 ` Tyrone Ting [this message]
2024-09-08 10:50   ` [PATCH v2 7/7] i2c: npcm: Enable slave in eob interrupt Tali Perry
2024-09-08 10:58 ` [PATCH v2 0/7] i2c: npcm: Bug fixes read/write operation, checkpatch Tali Perry
2024-09-09 13:00 ` Andi Shyti
2024-09-10  1:12   ` Tyrone Ting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830034640.7049-8-kfting@nuvoton.com \
    --to=warp5tw@gmail.com \
    --cc=Avi.Fishman@nuvoton.com \
    --cc=Charles.Boyer@fii-usa.com \
    --cc=JJLIU0@nuvoton.com \
    --cc=KWLIU@nuvoton.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=kfting@nuvoton.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=rand.sec96@gmail.com \
    --cc=tali.perry1@gmail.com \
    --cc=tali.perry@nuvoton.com \
    --cc=tmaimon77@gmail.com \
    --cc=tomer.maimon@nuvoton.com \
    --cc=venture@google.com \
    --cc=vveerach@google.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=wsa@kernel.org \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox