From: Kartik Rajput <kkartik@nvidia.com>
To: <akhilrajeev@nvidia.com>, <andi.shyti@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<ldewangan@nvidia.com>, <digetx@gmail.com>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/5] i2c: tegra: Do not configure DMA if not supported
Date: Wed, 8 Jan 2025 16:36:20 +0530 [thread overview]
Message-ID: <20250108110620.86900-6-kkartik@nvidia.com> (raw)
In-Reply-To: <20250108110620.86900-1-kkartik@nvidia.com>
On Tegra264, not all I2C controllers support DMA, this causes failures
when function tegra_i2c_init_dma() is called.
Ensure that "dmas" device-tree property is present before initializing
DMA in function tegra_i2c_init_dma().
Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
---
drivers/i2c/busses/i2c-tegra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a5974af5b1af..9957802fa4ed 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -546,6 +546,9 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
if (IS_VI(i2c_dev))
return 0;
+ if (!device_property_present(i2c_dev->dev, "dmas"))
+ return 0;
+
if (i2c_dev->hw->has_apb_dma) {
if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {
dev_dbg(i2c_dev->dev, "APB DMA support not enabled\n");
--
2.43.0
next prev parent reply other threads:[~2025-01-08 11:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 11:06 [PATCH 0/5] Add I2C support for Tegra264 Kartik Rajput
2025-01-08 11:06 ` [PATCH 1/5] i2c: tegra: Add HS mode support Kartik Rajput
2025-01-08 16:45 ` Thierry Reding
2025-01-15 11:40 ` Kartik Rajput
2025-01-09 12:18 ` kernel test robot
2025-01-08 11:06 ` [PATCH 2/5] dt-bindings: i2c: nvidia,tegra20-i2c: Document Tegra264 I2C Kartik Rajput
2025-01-08 16:47 ` Thierry Reding
2025-01-15 11:41 ` Kartik Rajput
2025-01-10 15:55 ` Rob Herring
2025-01-15 11:46 ` Kartik Rajput
2025-01-08 11:06 ` [PATCH 3/5] i2c: tegra: Add Tegra264 support Kartik Rajput
2025-01-09 4:43 ` Mukesh Kumar Savaliya
2025-01-09 10:24 ` Thierry Reding
2025-01-09 12:37 ` Mukesh Kumar Savaliya
2025-01-08 11:06 ` [PATCH 4/5] i2c: tegra: Add support for SW Mutex register Kartik Rajput
2025-01-08 17:01 ` Thierry Reding
2025-01-15 11:39 ` Kartik Rajput
2025-01-08 11:06 ` Kartik Rajput [this message]
2025-01-09 10:33 ` [PATCH 5/5] i2c: tegra: Do not configure DMA if not supported Thierry Reding
2025-01-15 11:42 ` Kartik Rajput
2025-01-09 10:37 ` [PATCH 0/5] Add I2C support for Tegra264 Thierry Reding
2025-01-15 11:44 ` Kartik Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108110620.86900-6-kkartik@nvidia.com \
--to=kkartik@nvidia.com \
--cc=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox