From: Andi Shyti <andi.shyti@kernel.org>
To: linux-i2c <linux-i2c@vger.kernel.org>
Cc: Andi Shyti <andi.shyti@kernel.org>
Subject: [PATCH 10/10] i2c: iproc: Remove unnecessary double negation
Date: Fri, 18 Apr 2025 23:16:35 +0200 [thread overview]
Message-ID: <20250418211635.2666234-11-andi.shyti@kernel.org> (raw)
In-Reply-To: <20250418211635.2666234-1-andi.shyti@kernel.org>
True is true when greater than '0', no need for double negation
inside the if statement.
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
---
drivers/i2c/busses/i2c-bcm-iproc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
index 9356a16422a3..2d117f242875 100644
--- a/drivers/i2c/busses/i2c-bcm-iproc.c
+++ b/drivers/i2c/busses/i2c-bcm-iproc.c
@@ -836,8 +836,8 @@ static int bcm_iproc_i2c_xfer_internal(struct bcm_iproc_i2c_dev *iproc_i2c,
struct i2c_msg *msg = &msgs[0];
/* check if bus is busy */
- if (!!(iproc_i2c_rd_reg(iproc_i2c,
- M_CMD_OFFSET) & BIT(M_CMD_START_BUSY_SHIFT))) {
+ if (iproc_i2c_rd_reg(iproc_i2c,
+ M_CMD_OFFSET) & BIT(M_CMD_START_BUSY_SHIFT)) {
dev_warn(iproc_i2c->device, "bus is busy\n");
return -EBUSY;
}
--
2.49.0
next prev parent reply other threads:[~2025-04-18 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 21:16 [PATCH 00/10] Few improvements on the Broadcom iProc Andi Shyti
2025-04-18 21:16 ` [PATCH 01/10] i2c: iproc: Drop unnecessary initialisation of 'ret' Andi Shyti
2025-04-18 21:16 ` [PATCH 02/10] i2c: iproc: Use dev_err_probe in probe Andi Shyti
2025-04-18 21:16 ` [PATCH 03/10] i2c: iproc: Use u32 instead of uint32_t Andi Shyti
2025-04-18 21:16 ` [PATCH 04/10] i2c: iproc: Fix alignment to match the open parenthesis Andi Shyti
2025-04-18 21:16 ` [PATCH 05/10] i2c: iproc: Remove stray blank line in slave ISR Andi Shyti
2025-04-18 21:16 ` [PATCH 06/10] i2c: iproc: Replace udelay() with usleep_range() Andi Shyti
2025-04-18 21:16 ` [PATCH 07/10] i2c: iproc: Fix indentation of bcm_iproc_i2c_slave_init() Andi Shyti
2025-04-18 21:16 ` [PATCH 08/10] i2c: iproc: Move function and avoid prototypes Andi Shyti
2025-04-19 19:46 ` Mukesh Kumar Savaliya
2025-04-26 20:19 ` [PATCH v2 " Andi Shyti
2025-04-18 21:16 ` [PATCH 09/10] i2c: iproc: When there's an error treat it as an error Andi Shyti
2025-04-18 21:16 ` Andi Shyti [this message]
2025-04-28 19:30 ` [PATCH 00/10] Few improvements on the Broadcom iProc Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418211635.2666234-11-andi.shyti@kernel.org \
--to=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox