* [PATCH] i2c: aspeed: propagate reset deassert errors
@ 2026-08-30 13:06 Pengpeng Hou
0 siblings, 0 replies; only message in thread
From: Pengpeng Hou @ 2026-08-30 13:06 UTC (permalink / raw)
To: Ryan Chen
Cc: Pengpeng Hou, Benjamin Herrenschmidt, Joel Stanley, Andi Shyti,
Andrew Jeffery, Billy Tsai, Philipp Zabel, linux-i2c, openbmc,
linux-arm-kernel, linux-aspeed, linux-kernel
aspeed_i2c_probe_bus() initializes and registers an adapter after
deasserting its shared reset, without checking whether the reset provider
accepted that transition.
Do not publish an adapter whose controller may still be held in reset.
Fixes: edd20e95bca4 ("i2c: aspeed: Deassert reset in probe")
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/i2c/busses/i2c-aspeed.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index a26b74c712061..bf29719bab1ea 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -1023,7 +1023,9 @@ static int aspeed_i2c_probe_bus(struct platform_device *pdev)
"missing or invalid reset controller device tree entry\n");
return PTR_ERR(bus->rst);
}
- reset_control_deassert(bus->rst);
+ ret = reset_control_deassert(bus->rst);
+ if (ret)
+ return ret;
ret = of_property_read_u32(pdev->dev.of_node,
"bus-frequency", &bus->bus_frequency);
base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72
--
2.50.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-30 13:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-30 13:06 [PATCH] i2c: aspeed: propagate reset deassert errors Pengpeng Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox