public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vijay Kumar Tumati <vijay.tumati@oss.qualcomm.com>,
	Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
Cc: Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Robert Foss <rfoss@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Todor Tomov <todor.too@gmail.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org,
	jeyaprakash.soundrapandian@oss.qualcomm.com
Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss
Date: Tue, 6 Jan 2026 20:20:51 +0100	[thread overview]
Message-ID: <355c3ae0-9603-4750-b83d-64447b6581ce@kernel.org> (raw)
In-Reply-To: <a228d38d-9fb9-4e61-9a02-e70593c69dac@kernel.org>

On 06/01/2026 20:18, Krzysztof Kozlowski wrote:
> On 06/01/2026 19:40, Vijay Kumar Tumati wrote:
>>
>> On 11/27/2025 12:12 AM, Krzysztof Kozlowski wrote:
>>> On Wed, Nov 26, 2025 at 01:38:40AM -0800, Hangxiang Ma wrote:

Look here^

>>>> +		};
>>>> +
>>>> +		cci0: cci@ac7b000 {
>>> Looks completely mis-ordered/sorted. What are the nodes above and below?
>> Hi Krzysztof, sorry, not sure how you mean exactly. The ones above are 
>> the pinctrl nodes. Each CCI has two masters using two GPIOs each, one 
> 
> Why would pinctrl nodes matter anyhow? Please read how DTS syntax works.
> 
>> for clk and one for data. The ones below are the actual CCI HW nodes 
>> that make use of the pinctrls. I believe this is inline with previous 
>> generations. Have I missed something? Thanks.
> I wrote what is wrong. Is this maintaining proper sorting? Did you read
> DTS coding style?
> 


Heh, you received my review 1 day after your posting.

You replied to my review 5-6 weeks after, yet you still expect me to
understand the context and provide clarifications.

There is simpler way: NAK.

You will not get your patches merged with such latency and such replies
not even trying to address the problem or learn about it.

Best regards,
Krzysztof

  reply	other threads:[~2026-01-06 19:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26  9:38 [PATCH 0/7] media: qcom: camss: Add SM8750 support Hangxiang Ma
2025-11-26  9:38 ` [PATCH 1/7] dt-bindings: i2c: qcom-cci: Document SM8750 compatible Hangxiang Ma
2025-11-27  7:50   ` Krzysztof Kozlowski
2025-11-27  9:44   ` Bryan O'Donoghue
2025-12-03 20:52   ` Andi Shyti
2025-11-26  9:38 ` [PATCH 2/7] media: dt-bindings: Add CAMSS device for SM8750 Hangxiang Ma
2025-11-27  8:10   ` Krzysztof Kozlowski
2025-12-04  1:31     ` Vladimir Zapolskiy
2026-01-06 18:04       ` Vijay Kumar Tumati
2026-01-06 18:02     ` Vijay Kumar Tumati
2025-11-27  9:46   ` Bryan O'Donoghue
2025-11-26  9:38 ` [PATCH 3/7] media: qcom: camss: Add SM8750 compatible camss driver Hangxiang Ma
2025-11-27  9:46   ` Bryan O'Donoghue
2025-11-26  9:38 ` [PATCH 4/7] media: qcom: camss: csiphy: Add support for v2.3.0 two-phase CSIPHY Hangxiang Ma
2025-11-27  8:14   ` Krzysztof Kozlowski
2026-01-06 18:05     ` Vijay Kumar Tumati
2025-11-26  9:38 ` [PATCH 5/7] media: qcom: camss: csid: Add support for CSID 980 Hangxiang Ma
2025-11-27 10:01   ` Bryan O'Donoghue
2026-01-06 18:07     ` Vijay Kumar Tumati
2025-11-26  9:38 ` [PATCH 6/7] media: qcom: camss: vfe: Add support for VFE gen4 Hangxiang Ma
2025-11-27 10:04   ` Bryan O'Donoghue
2026-01-06 18:17     ` Vijay Kumar Tumati
2025-11-26  9:38 ` [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss Hangxiang Ma
2025-11-27  8:12   ` Krzysztof Kozlowski
2026-01-06 18:40     ` Vijay Kumar Tumati
2026-01-06 19:18       ` Krzysztof Kozlowski
2026-01-06 19:20         ` Krzysztof Kozlowski [this message]
2026-01-06 19:43           ` Vijay Kumar Tumati
2025-11-27 10:06   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=355c3ae0-9603-4750-b83d-64447b6581ce@kernel.org \
    --to=krzk@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hangxiang.ma@oss.qualcomm.com \
    --cc=jeyaprakash.soundrapandian@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=vijay.tumati@oss.qualcomm.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox