From: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Loic Poulain <loic.poulain@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: i2c: qcom-cci: Document sm6150 compatible
Date: Wed, 7 Jan 2026 18:07:54 +0800 [thread overview]
Message-ID: <674b8615-dcd3-4ae8-8433-cda6e8347048@oss.qualcomm.com> (raw)
In-Reply-To: <7fc7c14c-a305-422e-8755-22e7c28bcfb3@kernel.org>
On 1/7/2026 4:34 PM, Krzysztof Kozlowski wrote:
> On 07/01/2026 09:17, Wenmeng Liu wrote:
>>
>>
>> On 1/7/2026 4:00 PM, Krzysztof Kozlowski wrote:
>>> On Tue, Jan 06, 2026 at 05:39:53PM +0800, Wenmeng Liu wrote:
>>>> + - if:
>>>> + properties:
>>>> + compatible:
>>>> + contains:
>>>> + enum:
>>>> + - qcom,sm6150-cci
>>>> + then:
>>>> + properties:
>>>> + clocks:
>>>> + minItems: 3
>>>> + maxItems: 3
>>>> + clock-names:
>>>> + items:
>>>> + - const: soc_ahb
>>>
>>> Same question as before. I did not see any resolution of this in
>>> changelog or commit msg.
>>>
>> Will update commit msg in next version:
>>
>> For this platform, it uses soc_ahb instead of camnoc_axi.
>
> That was not my question from v1. AHB and AXI are both bus clocks,
> meaning for this device the same. You again name the clocks how you
> called them in clock controller which is wrong. You name here CLOCK
> INPUTS. What is the role of this clock FOR THIS DEVICE?
>
> I already asked to pay attention to this difference.
>
> Best regards,
> Krzysztof
Ok, i got it, just feel a bit confused.
+ clocks = <&camcc CAM_CC_SOC_AHB_CLK>,
+ <&camcc CAM_CC_CPAS_AHB_CLK>,
+ <&camcc CAM_CC_CCI_CLK>;
+ clock-names = "camnoc_axi",
+ "cpas_ahb",
+ "cci";
clocks = <&camcc CAM_CC_SOC_AHB_CLK>,
clock-names = "camnoc_axi";
If this is acceptable, I will update it this way in the next version.
Thanks,
Wenmeng
next prev parent reply other threads:[~2026-01-07 10:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 9:39 [PATCH v2 0/4] Add CCI and imx577 sensor support for Talos evk Wenmeng Liu
2026-01-06 9:39 ` [PATCH v2 1/4] dt-bindings: i2c: qcom-cci: Document sm6150 compatible Wenmeng Liu
2026-01-07 4:27 ` Vladimir Zapolskiy
2026-01-07 8:00 ` Krzysztof Kozlowski
2026-01-07 8:17 ` Wenmeng Liu
2026-01-07 8:34 ` Krzysztof Kozlowski
2026-01-07 10:07 ` Wenmeng Liu [this message]
2026-01-07 10:35 ` Loic Poulain
2026-01-06 9:39 ` [PATCH v2 2/4] arm64: dts: qcom: talos: Add CCI definitions Wenmeng Liu
2026-01-06 18:27 ` Dmitry Baryshkov
2026-01-07 2:47 ` Wenmeng Liu
2026-01-07 4:28 ` Vladimir Zapolskiy
2026-01-06 9:39 ` [PATCH v2 3/4] arm64: dts: qcom: talos: Add camera MCLK pinctrl Wenmeng Liu
2026-01-06 18:29 ` Dmitry Baryshkov
2026-01-07 4:28 ` Vladimir Zapolskiy
2026-01-07 11:51 ` Konrad Dybcio
2026-01-06 9:39 ` [PATCH v2 4/4] arm64: dts: qcom: talos-evk-camera: Add DT overlay Wenmeng Liu
2026-01-06 18:23 ` Dmitry Baryshkov
2026-01-07 3:05 ` Wenmeng Liu
2026-01-07 5:16 ` Vladimir Zapolskiy
2026-01-07 5:55 ` Wenmeng Liu
2026-01-07 21:24 ` Vladimir Zapolskiy
2026-01-06 19:26 ` Rob Herring
2026-01-07 3:06 ` Wenmeng Liu
2026-01-07 13:28 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=674b8615-dcd3-4ae8-8433-cda6e8347048@oss.qualcomm.com \
--to=wenmeng.liu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox