public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Kim Phillips <kim.phillips@amd.com>, linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	V Narasimhan <Narasimhan.V@amd.com>
Subject: Re: [PATCH] i2c: designware: Revert recent changes to i2c_dw_probe_lock_support()
Date: Fri, 12 Jan 2024 10:13:23 +0200	[thread overview]
Message-ID: <9bb96130-d662-4904-9e4b-6a823b51a990@linux.intel.com> (raw)
In-Reply-To: <f5493701-4cc7-42c2-b9bb-958744bd8626@amd.com>

Hi

On 1/11/24 19:56, Kim Phillips wrote:
>> [    6.245173] i2c_designware AMDI0010:00: Unknown Synopsys component 
>> type: 0xffffffff

This has puzzled me all the time since I'm unable to see which one of 
Andy's patches could cause it. However controller is clearly powered 
down since DW_IC_COMP_TYPE register reads 0xffffffff.

That I'd call as a regression one. Second regression is the Oops and I 
was speculating if commit bd466a892612 ("i2c: designware: Fix PM calls 
order in dw_i2c_plat_probe()") can cause it.

> 
> Hold on, I'm testing this on top of next-20240111 and still seeing the 
> splat...
> 
Btw, does this reproduce always? Can we be mislead if it happens 
somewhat randomly? Happens to boot once we revert some commits and then 
at another Andy's nearby commit does not and we make the wrong conclusion?

Does bisecting between v6.7-rc1 and next-20240111 lead anywhere?


  reply	other threads:[~2024-01-12  8:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 12:56 [PATCH] i2c: designware: Revert recent changes to i2c_dw_probe_lock_support() Jarkko Nikula
2024-01-11 17:56 ` Kim Phillips
2024-01-12  8:13   ` Jarkko Nikula [this message]
2024-01-13 19:26     ` Wolfram Sang
2024-01-14 17:06       ` Andy Shevchenko
2024-01-15  6:58         ` Jarkko Nikula
2024-01-15 21:16     ` Kim Phillips
2024-01-15 22:44       ` Kim Phillips
2024-01-16  8:15         ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bb96130-d662-4904-9e4b-6a823b51a990@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=Narasimhan.V@amd.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=jsd@semihalf.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox