[PATCH 2/6] headers_check fix: ia64, fpswa.h

[PATCH 2/6] headers_check fix: ia64, fpswa.h

[Jaswinder Singh Rajput]

fix the following 'make headers_check' warning:

  usr/include/asm-ia64/fpswa.h:71: extern's make no sense in userspace

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
 arch/ia64/include/asm/fpswa.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/ia64/include/asm/fpswa.h b/arch/ia64/include/asm/fpswa.h
index 62edfce..797b064 100644
--- a/arch/ia64/include/asm/fpswa.h
+++ b/arch/ia64/include/asm/fpswa.h
@@ -68,6 +68,7 @@ typedef struct {
 	efi_fpswa_t	 fpswa;
 } fpswa_interface_t;
 
+#ifdef __KERNEL__
 extern fpswa_interface_t *fpswa_interface;
-
+#endif
 #endif /* _ASM_IA64_FPSWA_H */
-- 
1.6.0.6

Re: [PATCH 2/6] headers_check fix: ia64, fpswa.h

[Sam Ravnborg]

On Thu, Jun 04, 2009 at 05:59:59PM +0530, Jaswinder Singh Rajput wrote:
> 
> fix the following 'make headers_check' warning:
> 
>   usr/include/asm-ia64/fpswa.h:71: extern's make no sense in userspace
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>

Tony - is this file really used from userspace.
Looking at the definitions I think not.

I not then the real fix is to unexport it.

	Sam

Re: [PATCH 2/6] headers_check fix: ia64, fpswa.h

[Arnd Bergmann]

On Thursday 04 June 2009, Jaswinder Singh Rajput wrote:

> index 62edfce..797b064 100644
> --- a/arch/ia64/include/asm/fpswa.h
> +++ b/arch/ia64/include/asm/fpswa.h
> @@ -68,6 +68,7 @@ typedef struct {
>  	efi_fpswa_t	 fpswa;
>  } fpswa_interface_t;
>  
> +#ifdef __KERNEL__
>  extern fpswa_interface_t *fpswa_interface;
> -
> +#endif
>  #endif /* _ASM_IA64_FPSWA_H */

It's pretty obvious that the above data structure also doesn't
apply in user space. In fact it looks like the whole file should
just not be exported. Your patch is not helpful there because
it just silences the warning.

	Arnd <><

RE: [PATCH 2/6] headers_check fix: ia64, fpswa.h

[Luck, Tony]

> Tony - is this file really used from userspace.
> Looking at the definitions I think not.
>
> I not then the real fix is to unexport it.

Sam,

FPSWA should be completely invisible to user space.  You are correct that the
right fix is to unexport it.

-Tony

[PATCH] ia64: unexport fpswa.h

[Sam Ravnborg]

fpswa.h is not relevant for userspace,
so do not export it.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>
---
diff --git a/arch/ia64/include/asm/Kbuild b/arch/ia64/include/asm/Kbuild
index ccbe8ae..c7d0a71 100644
--- a/arch/ia64/include/asm/Kbuild
+++ b/arch/ia64/include/asm/Kbuild
@@ -2,7 +2,6 @@ include include/asm-generic/Kbuild.asm
 
 header-y += break.h
 header-y += fpu.h
-header-y += fpswa.h
 header-y += ia64regs.h
 header-y += intel_intrin.h
 header-y += perfmon_default_smpl.h