From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] sal cleanup
Date: Fri, 27 Feb 2004 18:52:46 +0000 [thread overview]
Message-ID: <16447.37374.350498.666550@napali.hpl.hp.com> (raw)
In-Reply-To: <20040226213704.GW25779@parcelfarce.linux.theplanet.co.uk>
>>>>> On Thu, 26 Feb 2004 22:04:56 +0000, Matthew Wilcox <willy@debian.org> said:
Matthew> On Thu, Feb 26, 2004 at 01:55:34PM -0800, David Mosberger
Matthew> wrote:
>> How about printing "none" or something like that instead?
Matthew> Sure.
Matthew> This patch reorganises sal.c and adds two new functions:
Matthew> - Split the body of the switch statement in
Matthew> ia64_sal_init() into separate functions. - Delete min/max
Matthew> since they were only assigned to, never used. - Print the
Matthew> version of the SAL implementation as well as the spec
Matthew> version it supports. - Stop printing the pal_proc and
Matthew> sal_proc entry addresses. - Print "none" if there are no
Matthew> platform features. - Remember the sal revision and version
Matthew> and add two functions to compare them.
The patch also changes the arguments for ia64_sal_pci_config_read()
and ia64_sal_pci_config_write(), without changing any callers.
Why?
Also, how about putting a colon after "SAL Platform features"?
--david
next prev parent reply other threads:[~2004-02-27 18:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 21:37 [PATCH] sal cleanup Matthew Wilcox
2004-02-26 21:55 ` David Mosberger
2004-02-26 22:04 ` Matthew Wilcox
2004-02-27 18:52 ` David Mosberger [this message]
2004-02-27 19:24 ` Matthew Wilcox
2004-02-27 19:33 ` David Mosberger
2004-02-27 20:25 ` Matthew Wilcox
2004-02-27 21:48 ` Randy.Dunlap
2004-02-27 22:09 ` David Mosberger
2004-02-27 22:42 ` Matthew Wilcox
2004-02-27 23:02 ` David Mosberger
2004-03-01 16:03 ` Matthew Wilcox
2004-03-01 16:05 ` Matthew Wilcox
2004-03-02 1:30 ` David Mosberger
2004-03-02 7:46 ` David Mosberger
2004-03-02 15:56 ` Matthew Wilcox
2004-03-02 16:00 ` Matthew Wilcox
2004-03-02 17:42 ` David Mosberger
2004-03-02 17:57 ` Matthew Wilcox
2004-03-02 18:01 ` David Mosberger
2004-03-02 19:25 ` Matthew Wilcox
2004-03-03 2:53 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16447.37374.350498.666550@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox