From: "Randy.Dunlap" <rddunlap@osdl.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] sal cleanup
Date: Fri, 27 Feb 2004 21:48:50 +0000 [thread overview]
Message-ID: <20040227134850.5deb0f75.rddunlap@osdl.org> (raw)
In-Reply-To: <20040226213704.GW25779@parcelfarce.linux.theplanet.co.uk>
On Fri, 27 Feb 2004 20:25:05 +0000 Matthew Wilcox wrote:
| On Fri, Feb 27, 2004 at 11:33:36AM -0800, David Mosberger wrote:
| > Sounds good to me. The extra blank kills me though... ;-)
|
| Weeeeeelllllllll.... if you're not allergic to trigraphs,
|
| printk(KERN_INFO "SAL %d.%d: %.32s %.32s%sversion %d.%d\n",
| sal_rev_major, sal_rev_minor, systab->oem_id,
| systab->product_id, systab->product_id[0] ? " " : "",
| sal_b_rev_major, sal_b_rev_minor);
|
| does the trick nicely ;-)
|
| I'll send a patch when you've come to a decision about how you want the
| SAL revision comparison to look -- it all touches the same area of code.
Where's the trigraph???
A conditional operator ("?:") [section 6.5.15 of C99 spec.]
does not make a 'trigraph'.
Conditional operators are fine IMO, so long as the gcc extension of
"omitted second operand implies repeat the first operand" is not used... :)
This is ugly and prone to mistakes.
--
~Randy
next prev parent reply other threads:[~2004-02-27 21:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 21:37 [PATCH] sal cleanup Matthew Wilcox
2004-02-26 21:55 ` David Mosberger
2004-02-26 22:04 ` Matthew Wilcox
2004-02-27 18:52 ` David Mosberger
2004-02-27 19:24 ` Matthew Wilcox
2004-02-27 19:33 ` David Mosberger
2004-02-27 20:25 ` Matthew Wilcox
2004-02-27 21:48 ` Randy.Dunlap [this message]
2004-02-27 22:09 ` David Mosberger
2004-02-27 22:42 ` Matthew Wilcox
2004-02-27 23:02 ` David Mosberger
2004-03-01 16:03 ` Matthew Wilcox
2004-03-01 16:05 ` Matthew Wilcox
2004-03-02 1:30 ` David Mosberger
2004-03-02 7:46 ` David Mosberger
2004-03-02 15:56 ` Matthew Wilcox
2004-03-02 16:00 ` Matthew Wilcox
2004-03-02 17:42 ` David Mosberger
2004-03-02 17:57 ` Matthew Wilcox
2004-03-02 18:01 ` David Mosberger
2004-03-02 19:25 ` Matthew Wilcox
2004-03-03 2:53 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040227134850.5deb0f75.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox