From: Matthew Wilcox <willy@debian.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] sal cleanup
Date: Fri, 27 Feb 2004 19:24:59 +0000 [thread overview]
Message-ID: <20040227192459.GP25779@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040226213704.GW25779@parcelfarce.linux.theplanet.co.uk>
On Fri, Feb 27, 2004 at 10:52:46AM -0800, David Mosberger wrote:
> The patch also changes the arguments for ia64_sal_pci_config_read()
> and ia64_sal_pci_config_write(), without changing any callers.
> Why?
Because I made a mistake; I intended to delete that part from that patch.
It's part of the [3/4] patch I sent you earlier today.
> Also, how about putting a colon after "SAL Platform features"?
Sure. While we're nitpicking, how about deleting the 'oem=' and `product='
from the printk? It currently looks like:
SAL 3.1: oem=HP, product=, version 2.21
How about instead it reading
SAL 3.1: HP version 2.21
(if we filled in the product field, it'd read something like
SAL 3.1: HP rx2600 version 2.21
)
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-02-27 19:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 21:37 [PATCH] sal cleanup Matthew Wilcox
2004-02-26 21:55 ` David Mosberger
2004-02-26 22:04 ` Matthew Wilcox
2004-02-27 18:52 ` David Mosberger
2004-02-27 19:24 ` Matthew Wilcox [this message]
2004-02-27 19:33 ` David Mosberger
2004-02-27 20:25 ` Matthew Wilcox
2004-02-27 21:48 ` Randy.Dunlap
2004-02-27 22:09 ` David Mosberger
2004-02-27 22:42 ` Matthew Wilcox
2004-02-27 23:02 ` David Mosberger
2004-03-01 16:03 ` Matthew Wilcox
2004-03-01 16:05 ` Matthew Wilcox
2004-03-02 1:30 ` David Mosberger
2004-03-02 7:46 ` David Mosberger
2004-03-02 15:56 ` Matthew Wilcox
2004-03-02 16:00 ` Matthew Wilcox
2004-03-02 17:42 ` David Mosberger
2004-03-02 17:57 ` Matthew Wilcox
2004-03-02 18:01 ` David Mosberger
2004-03-02 19:25 ` Matthew Wilcox
2004-03-03 2:53 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040227192459.GP25779@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox