Re: [PATCH] QLogic ISP2x00: remove needless busyloop

Re: [PATCH] QLogic ISP2x00: remove needless busyloop

[Christoph Hellwig]

On Mon, Aug 09, 2004 at 02:19:20PM -0600, Bjorn Helgaas wrote:
> I don't use it (note the "there's no isp2x00" bit above).  But it's
> still part of ia64 defconfig (which I don't maintain), and it's easier
> to tell people "use generic_defconfig" than to tell them to remove
> CONFIG_SCSI_QLOGIC_FC by hand.

So tell David to fix up the defconfig..

> In general, I think if a driver is in the tree, it should be fair
> game for bugfixes.  In fact, I see you did the most recent one to
> qlogicfc :-)

That wasn't a bugfix, look harder.

Re: [PATCH] QLogic ISP2x00: remove needless busyloop

[Bjorn Helgaas]

> > In general, I think if a driver is in the tree, it should be fair
> > game for bugfixes.  In fact, I see you did the most recent one to
> > qlogicfc :-)
> 
> That wasn't a bugfix, look harder.

My apologies.  I should have written "if a driver is in the
tree, it should be fair game to improve it."

I think I'm missing something in this exchange.  Are you

1) Pointing out that the qlogicfc is obsolete and shouldn't
be used?  If so, thanks for the tip.

2) Suggesting that no changes to qlogicfc should be made?  If so,
I think it should be removed from the tree altogether.

3) Objecting to my patch because it is incorrect?  If so, please
give me a hint about what the problem is.

4) Something else?

Re: [PATCH] QLogic ISP2x00: remove needless busyloop

[Christoph Hellwig]

On Mon, Aug 09, 2004 at 03:08:27PM -0600, Bjorn Helgaas wrote:
> > > In general, I think if a driver is in the tree, it should be fair
> > > game for bugfixes.  In fact, I see you did the most recent one to
> > > qlogicfc :-)
> > 
> > That wasn't a bugfix, look harder.
> 
> My apologies.  I should have written "if a driver is in the
> tree, it should be fair game to improve it."

I don't object to the patch.  But it was a _very_ _strong_ _hint_ that you
did something wrong if the patch actually matters for you.