* Re: [PATCH] QLogic ISP2x00: remove needless busyloop [not found] ` <200408091419.20029.bjorn.helgaas@hp.com> @ 2004-08-09 20:21 ` Christoph Hellwig 2004-08-09 21:08 ` Bjorn Helgaas 0 siblings, 1 reply; 3+ messages in thread From: Christoph Hellwig @ 2004-08-09 20:21 UTC (permalink / raw) To: Bjorn Helgaas, linux-ia64 Cc: Christoph Hellwig, Andrew Morton, grif, linux-kernel On Mon, Aug 09, 2004 at 02:19:20PM -0600, Bjorn Helgaas wrote: > I don't use it (note the "there's no isp2x00" bit above). But it's > still part of ia64 defconfig (which I don't maintain), and it's easier > to tell people "use generic_defconfig" than to tell them to remove > CONFIG_SCSI_QLOGIC_FC by hand. So tell David to fix up the defconfig.. > In general, I think if a driver is in the tree, it should be fair > game for bugfixes. In fact, I see you did the most recent one to > qlogicfc :-) That wasn't a bugfix, look harder. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] QLogic ISP2x00: remove needless busyloop 2004-08-09 20:21 ` [PATCH] QLogic ISP2x00: remove needless busyloop Christoph Hellwig @ 2004-08-09 21:08 ` Bjorn Helgaas 2004-08-09 21:16 ` Christoph Hellwig 0 siblings, 1 reply; 3+ messages in thread From: Bjorn Helgaas @ 2004-08-09 21:08 UTC (permalink / raw) To: Christoph Hellwig; +Cc: linux-ia64, Andrew Morton, grif, linux-kernel > > In general, I think if a driver is in the tree, it should be fair > > game for bugfixes. In fact, I see you did the most recent one to > > qlogicfc :-) > > That wasn't a bugfix, look harder. My apologies. I should have written "if a driver is in the tree, it should be fair game to improve it." I think I'm missing something in this exchange. Are you 1) Pointing out that the qlogicfc is obsolete and shouldn't be used? If so, thanks for the tip. 2) Suggesting that no changes to qlogicfc should be made? If so, I think it should be removed from the tree altogether. 3) Objecting to my patch because it is incorrect? If so, please give me a hint about what the problem is. 4) Something else? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] QLogic ISP2x00: remove needless busyloop 2004-08-09 21:08 ` Bjorn Helgaas @ 2004-08-09 21:16 ` Christoph Hellwig 0 siblings, 0 replies; 3+ messages in thread From: Christoph Hellwig @ 2004-08-09 21:16 UTC (permalink / raw) To: Bjorn Helgaas Cc: Christoph Hellwig, linux-ia64, Andrew Morton, grif, linux-kernel On Mon, Aug 09, 2004 at 03:08:27PM -0600, Bjorn Helgaas wrote: > > > In general, I think if a driver is in the tree, it should be fair > > > game for bugfixes. In fact, I see you did the most recent one to > > > qlogicfc :-) > > > > That wasn't a bugfix, look harder. > > My apologies. I should have written "if a driver is in the > tree, it should be fair game to improve it." I don't object to the patch. But it was a _very_ _strong_ _hint_ that you did something wrong if the patch actually matters for you. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-08-09 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200408091252.58547.bjorn.helgaas@hp.com>
[not found] ` <20040809210335.A9711@infradead.org>
[not found] ` <200408091419.20029.bjorn.helgaas@hp.com>
2004-08-09 20:21 ` [PATCH] QLogic ISP2x00: remove needless busyloop Christoph Hellwig
2004-08-09 21:08 ` Bjorn Helgaas
2004-08-09 21:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox