From: Christoph Hellwig <hch@infradead.org>
To: Patrick Gefre <pfg@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Latest Altix I/O code reorganization code
Date: Fri, 27 Aug 2004 15:36:54 +0000 [thread overview]
Message-ID: <20040827163654.A32236@infradead.org> (raw)
In-Reply-To: <412F4EC9.7050003@sgi.com>; from pfg@sgi.com on Fri, Aug 27, 2004 at 10:10:01AM -0500
On Fri, Aug 27, 2004 at 10:10:01AM -0500, Patrick Gefre wrote:
> io_init.c iomv.c Makefile pci pci_dma.c pci_extension.c
>
> arch/ia64/sn/ioif/pci:
> Makefile pcibr_ate.c pcibr_dma.c pcibr_provider.c pcibr_reg.c xtalk_providers.c
>
So why are pci_dma.c and pci_extensions.c not under pci? You probably should
just kill that pci subdir, too when there's just two other files left. Or
move those two to kernel/ and have a pci/ subdir which seems to fit other
ports quite well. But I'd rather see the functional changes first and then
do renaming of unchanged files last anyway so you changed get actually
reviewable. The current patchkit is not.
next prev parent reply other threads:[~2004-08-27 15:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-04 20:14 Altix I/O code reorganization Pat Gefre
2004-08-05 0:31 ` Grant Grundler
2004-08-05 18:16 ` Greg KH
2004-08-05 20:51 ` Pat Gefre
2004-08-05 21:08 ` Greg KH
2004-08-05 21:32 ` Jesse Barnes
2004-08-05 21:36 ` Greg KH
2004-08-06 13:18 ` Christoph Hellwig
2004-08-06 16:19 ` Jesse Barnes
2004-08-07 10:58 ` Christoph Hellwig
2004-08-11 23:24 ` Patrick Gefre
2004-08-12 9:15 ` Christoph Hellwig
2004-08-12 14:47 ` Jesse Barnes
2004-08-12 15:21 ` Christoph Hellwig
2004-08-27 15:10 ` Latest Altix I/O code reorganization code Patrick Gefre
2004-08-27 15:14 ` Patrick Gefre
2004-08-27 15:21 ` Christoph Hellwig
2004-08-27 15:35 ` Patrick Gefre
2004-08-27 15:44 ` Christoph Hellwig
2004-08-27 15:23 ` Pat Gefre
2004-08-27 15:36 ` Christoph Hellwig [this message]
2004-08-27 15:45 ` Christoph Hellwig
2004-08-27 16:32 ` Patrick Gefre
2004-08-27 15:54 ` Christoph Hellwig
2004-08-27 16:06 ` Patrick Gefre
2004-08-27 16:21 ` Christoph Hellwig
2004-09-03 23:40 ` Christoph Hellwig
2004-09-07 22:10 ` Patrick Gefre
2004-09-07 22:16 ` Christoph Hellwig
2004-08-27 17:15 ` Christoph Hellwig
2004-08-29 6:39 ` Keith Owens
2004-08-29 7:16 ` Sam Ravnborg
2004-08-29 7:22 ` Keith Owens
2004-08-06 13:51 ` Altix I/O code reorganization Keith Owens
2004-08-06 13:55 ` Christoph Hellwig
2004-08-06 15:47 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040827163654.A32236@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox