NODE_DATA without CONFIG_NUMA

NODE_DATA without CONFIG_NUMA

[Horms]

Hi,

I'm trying to build a non-NUMA (HP_SIM) config, and I am running
into trouble because there are serveral places where NODE_DATA is
used. It seems to me that this makes little sense as NODE_DATA
needs the node_data element of struct cpuinfo_ia64, which doesn't
exist without CONFIG_NUMA.

Is CONFIG_NUMA mandatory or is this just an oversight?

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


-- 
VGER BF report: U 0.500823

Re: NODE_DATA without CONFIG_NUMA

[KAMEZAWA Hiroyuki]

On Mon, 4 Sep 2006 15:23:25 +0900
Horms <horms@verge.net.au> wrote:

> Hi,
> 
> I'm trying to build a non-NUMA (HP_SIM) config, and I am running
> into trouble because there are serveral places where NODE_DATA is
> used. It seems to me that this makes little sense as NODE_DATA
> needs the node_data element of struct cpuinfo_ia64, which doesn't
> exist without CONFIG_NUMA.
> 
> Is CONFIG_NUMA mandatory or is this just an oversight?
> 

Could you attach your .config ?

-Kame


-- 
VGER BF report: U 0.510073

Re: NODE_DATA without CONFIG_NUMA

[Horms]

On Mon, Sep 04, 2006 at 03:37:29PM +0900, KAMEZAWA Hiroyuki wrote:
> On Mon, 4 Sep 2006 15:23:25 +0900
> Horms <horms@verge.net.au> wrote:
> 
> > Hi,
> > 
> > I'm trying to build a non-NUMA (HP_SIM) config, and I am running
> > into trouble because there are serveral places where NODE_DATA is
> > used. It seems to me that this makes little sense as NODE_DATA
> > needs the node_data element of struct cpuinfo_ia64, which doesn't
> > exist without CONFIG_NUMA.
> > 
> > Is CONFIG_NUMA mandatory or is this just an oversight?
> > 
> 
> Could you attach your .config ?

Sure, 

here is a config that exhibits the problem.
Though now you come to mention it, perhaps the config is invalid.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.18-rc5
# Mon Sep  4 16:00:47 2006
#
CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"

#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT2

#
# General setup
#
CONFIG_LOCALVERSION="-kexec"
CONFIG_LOCALVERSION_AUTO=y
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
# CONFIG_POSIX_MQUEUE is not set
# CONFIG_BSD_PROCESS_ACCT is not set
# CONFIG_TASKSTATS is not set
CONFIG_SYSCTL=y
# CONFIG_AUDIT is not set
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
# CONFIG_RELAY is not set
CONFIG_INITRAMFS_SOURCE=""
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
# CONFIG_EMBEDDED is not set
CONFIG_KALLSYMS=y
CONFIG_KALLSYMS_ALL=y
# CONFIG_KALLSYMS_EXTRA_PASS is not set
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y
CONFIG_RT_MUTEXES=y
CONFIG_FUTEX=y
CONFIG_EPOLL=y
CONFIG_SHMEM=y
CONFIG_SLAB=y
CONFIG_VM_EVENT_COUNTERS=y
# CONFIG_TINY_SHMEM is not set
CONFIG_BASE_SMALL=0
# CONFIG_SLOB is not set

#
# Loadable module support
#
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
# CONFIG_MODULE_FORCE_UNLOAD is not set
CONFIG_MODVERSIONS=y
# CONFIG_MODULE_SRCVERSION_ALL is not set
CONFIG_KMOD=y

#
# Block layer
#
# CONFIG_BLK_DEV_IO_TRACE is not set

#
# IO Schedulers
#
CONFIG_IOSCHED_NOOP=y
CONFIG_IOSCHED_AS=y
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set
CONFIG_DEFAULT_AS=y
# CONFIG_DEFAULT_DEADLINE is not set
# CONFIG_DEFAULT_CFQ is not set
# CONFIG_DEFAULT_NOOP is not set
CONFIG_DEFAULT_IOSCHED="anticipatory"

#
# Processor type and features
#
CONFIG_IA64=y
CONFIG_64BIT=y
CONFIG_MMU=y
CONFIG_SWIOTLB=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_FIND_NEXT_BIT=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_TIME_INTERPOLATION=y
CONFIG_DMI=y
CONFIG_EFI=y
CONFIG_GENERIC_IOMAP=y
CONFIG_SCHED_NO_NO_OMIT_FRAME_POINTER=y
CONFIG_DMA_IS_DMA32=y
# CONFIG_IA64_GENERIC is not set
# CONFIG_IA64_DIG is not set
# CONFIG_IA64_HP_ZX1 is not set
# CONFIG_IA64_HP_ZX1_SWIOTLB is not set
# CONFIG_IA64_SGI_SN2 is not set
CONFIG_IA64_HP_SIM=y
# CONFIG_ITANIUM is not set
CONFIG_MCKINLEY=y
# CONFIG_IA64_PAGE_SIZE_4KB is not set
# CONFIG_IA64_PAGE_SIZE_8KB is not set
CONFIG_IA64_PAGE_SIZE_16KB=y
# CONFIG_IA64_PAGE_SIZE_64KB is not set
CONFIG_PGTABLE_3=y
# CONFIG_PGTABLE_4 is not set
# CONFIG_HZ_100 is not set
CONFIG_HZ_250=y
# CONFIG_HZ_1000 is not set
CONFIG_HZ%0
CONFIG_IA64_L1_CACHE_SHIFT=7
CONFIG_IA64_CYCLONE=y
CONFIG_FORCE_MAX_ZONEORDER\x17
# CONFIG_SMP is not set
CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y
# CONFIG_PREEMPT is not set
CONFIG_SELECT_MEMORY_MODEL=y
# CONFIG_FLATMEM_MANUAL is not set
CONFIG_DISCONTIGMEM_MANUAL=y
# CONFIG_SPARSEMEM_MANUAL is not set
CONFIG_DISCONTIGMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
CONFIG_NEED_MULTIPLE_NODES=y
# CONFIG_SPARSEMEM_STATIC is not set
CONFIG_SPLIT_PTLOCK_CPUS=4
CONFIG_RESOURCES_64BIT=y
CONFIG_ARCH_SELECT_MEMORY_MODEL=y
CONFIG_ARCH_DISCONTIGMEM_ENABLE=y
CONFIG_ARCH_FLATMEM_ENABLE=y
CONFIG_ARCH_SPARSEMEM_ENABLE=y
CONFIG_NODES_SHIFT=8
CONFIG_VIRTUAL_MEM_MAP=y
CONFIG_HOLES_IN_ZONE=y
CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID=y
CONFIG_IA32_SUPPORT=y
CONFIG_COMPAT=y
CONFIG_IA64_MCA_RECOVERY=y
CONFIG_PERFMON=y
CONFIG_IA64_PALINFO=y
# CONFIG_IA64_ESI is not set
CONFIG_KEXEC=y
CONFIG_CRASH_DUMP=y

#
# Firmware Drivers
#
CONFIG_EFI_VARS=y
CONFIG_BINFMT_ELF=y
# CONFIG_BINFMT_MISC is not set

#
# Power management and ACPI
#

#
# Networking
#
CONFIG_NET=y

#
# Networking options
#
# CONFIG_NETDEBUG is not set
CONFIG_PACKET=y
# CONFIG_PACKET_MMAP is not set
CONFIG_UNIX=y
CONFIG_XFRM=y
# CONFIG_XFRM_USER is not set
# CONFIG_NET_KEY is not set
CONFIG_INET=y
# CONFIG_IP_MULTICAST is not set
# CONFIG_IP_ADVANCED_ROUTER is not set
CONFIG_IP_FIB_HASH=y
CONFIG_IP_PNP=y
CONFIG_IP_PNP_DHCP=y
# CONFIG_IP_PNP_BOOTP is not set
# CONFIG_IP_PNP_RARP is not set
# CONFIG_NET_IPIP is not set
# CONFIG_NET_IPGRE is not set
# CONFIG_ARPD is not set
# CONFIG_SYN_COOKIES is not set
# CONFIG_INET_AH is not set
# CONFIG_INET_ESP is not set
# CONFIG_INET_IPCOMP is not set
# CONFIG_INET_XFRM_TUNNEL is not set
# CONFIG_INET_TUNNEL is not set
CONFIG_INET_XFRM_MODE_TRANSPORT=y
CONFIG_INET_XFRM_MODE_TUNNEL=y
CONFIG_INET_DIAG=y
CONFIG_INET_TCP_DIAG=y
# CONFIG_TCP_CONG_ADVANCED is not set
CONFIG_TCP_CONG_BIC=y
# CONFIG_IPV6 is not set
# CONFIG_INET6_XFRM_TUNNEL is not set
# CONFIG_INET6_TUNNEL is not set
# CONFIG_NETWORK_SECMARK is not set
# CONFIG_NETFILTER is not set

#
# DCCP Configuration (EXPERIMENTAL)
#
# CONFIG_IP_DCCP is not set

#
# SCTP Configuration (EXPERIMENTAL)
#
# CONFIG_IP_SCTP is not set

#
# TIPC Configuration (EXPERIMENTAL)
#
# CONFIG_TIPC is not set
# CONFIG_ATM is not set
# CONFIG_BRIDGE is not set
# CONFIG_VLAN_8021Q is not set
# CONFIG_DECNET is not set
# CONFIG_LLC2 is not set
# CONFIG_IPX is not set
# CONFIG_ATALK is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_NET_DIVERT is not set
# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set

#
# QoS and/or fair queueing
#
# CONFIG_NET_SCHED is not set

#
# Network testing
#
# CONFIG_NET_PKTGEN is not set
# CONFIG_HAMRADIO is not set
# CONFIG_IRDA is not set
# CONFIG_BT is not set
# CONFIG_IEEE80211 is not set

#
# Device Drivers
#

#
# Generic Driver Options
#
CONFIG_STANDALONE=y
CONFIG_PREVENT_FIRMWARE_BUILD=y
# CONFIG_FW_LOADER is not set
# CONFIG_DEBUG_DRIVER is not set
# CONFIG_SYS_HYPERVISOR is not set

#
# Connector - unified userspace <-> kernelspace linker
#
# CONFIG_CONNECTOR is not set

#
# Memory Technology Devices (MTD)
#
# CONFIG_MTD is not set

#
# Parallel port support
#
# CONFIG_PARPORT is not set

#
# Plug and Play support
#

#
# Block devices
#
# CONFIG_BLK_DEV_COW_COMMON is not set
# CONFIG_BLK_DEV_LOOP is not set
# CONFIG_BLK_DEV_NBD is not set
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_COUNT\x16
CONFIG_BLK_DEV_RAM_SIZE@96
CONFIG_BLK_DEV_RAM_BLOCKSIZE\x1024
CONFIG_BLK_DEV_INITRD=y
# CONFIG_CDROM_PKTCDVD is not set
# CONFIG_ATA_OVER_ETH is not set

#
# ATA/ATAPI/MFM/RLL support
#
# CONFIG_IDE is not set

#
# SCSI device support
#
# CONFIG_RAID_ATTRS is not set
CONFIG_SCSI=y
CONFIG_SCSI_PROC_FS=y

#
# SCSI support type (disk, tape, CD-ROM)
#
CONFIG_BLK_DEV_SD=y
# CONFIG_CHR_DEV_ST is not set
# CONFIG_CHR_DEV_OSST is not set
# CONFIG_BLK_DEV_SR is not set
# CONFIG_CHR_DEV_SG is not set
# CONFIG_CHR_DEV_SCH is not set

#
# Some SCSI devices (e.g. CD jukebox) support multiple LUNs
#
# CONFIG_SCSI_MULTI_LUN is not set
# CONFIG_SCSI_CONSTANTS is not set
# CONFIG_SCSI_LOGGING is not set

#
# SCSI Transport Attributes
#
CONFIG_SCSI_SPI_ATTRS=y
# CONFIG_SCSI_FC_ATTRS is not set
# CONFIG_SCSI_ISCSI_ATTRS is not set
# CONFIG_SCSI_SAS_ATTRS is not set

#
# SCSI low-level drivers
#
# CONFIG_ISCSI_TCP is not set
# CONFIG_SCSI_SATA is not set
# CONFIG_SCSI_DEBUG is not set

#
# Multi-device support (RAID and LVM)
#
# CONFIG_MD is not set

#
# Fusion MPT device support
#
# CONFIG_FUSION is not set

#
# IEEE 1394 (FireWire) support
#

#
# I2O device support
#

#
# Network device support
#
# CONFIG_NETDEVICES is not set
# CONFIG_DUMMY is not set
# CONFIG_BONDING is not set
# CONFIG_EQUALIZER is not set
# CONFIG_TUN is not set

#
# PHY device support
#

#
# Ethernet (10 or 100Mbit)
#
# CONFIG_NET_ETHERNET is not set

#
# Ethernet (1000 Mbit)
#

#
# Ethernet (10000 Mbit)
#
# CONFIG_PPP is not set
# CONFIG_SLIP is not set
# CONFIG_SHAPER is not set
# CONFIG_NETCONSOLE is not set
# CONFIG_NETPOLL is not set
# CONFIG_NET_POLL_CONTROLLER is not set

#
# ISDN subsystem
#
# CONFIG_ISDN is not set

#
# Telephony Support
#
# CONFIG_PHONE is not set

#
# Input device support
#
CONFIG_INPUT=y

#
# Userland interfaces
#
CONFIG_INPUT_MOUSEDEV=y
# CONFIG_INPUT_MOUSEDEV_PSAUX is not set
CONFIG_INPUT_MOUSEDEV_SCREEN_X\x1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Yv8
# CONFIG_INPUT_JOYDEV is not set
# CONFIG_INPUT_TSDEV is not set
# CONFIG_INPUT_EVDEV is not set
# CONFIG_INPUT_EVBUG is not set

#
# Input Device Drivers
#
# CONFIG_INPUT_KEYBOARD is not set
# CONFIG_INPUT_MOUSE is not set
# CONFIG_INPUT_JOYSTICK is not set
# CONFIG_INPUT_TOUCHSCREEN is not set
# CONFIG_INPUT_MISC is not set

#
# Hardware I/O ports
#
# CONFIG_SERIO is not set
# CONFIG_GAMEPORT is not set

#
# Character devices
#
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_HW_CONSOLE=y
# CONFIG_VT_HW_CONSOLE_BINDING is not set
# CONFIG_SERIAL_NONSTANDARD is not set

#
# Serial drivers
#
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_CONSOLE=y
CONFIG_SERIAL_8250_NR_UARTS=6
CONFIG_SERIAL_8250_RUNTIME_UARTS=4
CONFIG_SERIAL_8250_EXTENDED=y
CONFIG_SERIAL_8250_SHARE_IRQ=y
# CONFIG_SERIAL_8250_DETECT_IRQ is not set
# CONFIG_SERIAL_8250_RSA is not set

#
# Non-8250 serial port support
#
CONFIG_SERIAL_CORE=y
CONFIG_SERIAL_CORE_CONSOLE=y
CONFIG_UNIX98_PTYS=y
CONFIG_LEGACY_PTYS=y
CONFIG_LEGACY_PTY_COUNT%6

#
# IPMI
#
# CONFIG_IPMI_HANDLER is not set

#
# Watchdog Cards
#
# CONFIG_WATCHDOG is not set
# CONFIG_HW_RANDOM is not set
# CONFIG_EFI_RTC is not set
# CONFIG_DTLK is not set
# CONFIG_R3964 is not set

#
# Ftape, the floppy tape device driver
#
# CONFIG_RAW_DRIVER is not set
# CONFIG_HANGCHECK_TIMER is not set

#
# TPM devices
#
# CONFIG_TCG_TPM is not set
# CONFIG_TELCLOCK is not set

#
# I2C support
#
# CONFIG_I2C is not set

#
# SPI support
#
# CONFIG_SPI is not set
# CONFIG_SPI_MASTER is not set

#
# Dallas's 1-wire bus
#

#
# Hardware Monitoring support
#
# CONFIG_HWMON is not set
# CONFIG_HWMON_VID is not set

#
# Misc devices
#

#
# Multimedia devices
#
# CONFIG_VIDEO_DEV is not set
CONFIG_VIDEO_V4L2=y

#
# Digital Video Broadcasting Devices
#
# CONFIG_DVB is not set

#
# Graphics support
#
CONFIG_FIRMWARE_EDID=y
# CONFIG_FB is not set

#
# Console display driver support
#
CONFIG_VGA_CONSOLE=y
# CONFIG_VGACON_SOFT_SCROLLBACK is not set
CONFIG_DUMMY_CONSOLE=y
# CONFIG_BACKLIGHT_LCD_SUPPORT is not set

#
# Sound
#
# CONFIG_SOUND is not set

#
# USB support
#
# CONFIG_USB_ARCH_HAS_HCD is not set
# CONFIG_USB_ARCH_HAS_OHCI is not set
# CONFIG_USB_ARCH_HAS_EHCI is not set

#
# NOTE: USB_STORAGE enables SCSI, and 'SCSI disk support'
#

#
# USB Gadget Support
#
# CONFIG_USB_GADGET is not set

#
# MMC/SD Card support
#
# CONFIG_MMC is not set

#
# LED devices
#
# CONFIG_NEW_LEDS is not set

#
# LED drivers
#

#
# LED Triggers
#

#
# InfiniBand support
#

#
# EDAC - error detection and reporting (RAS) (EXPERIMENTAL)
#

#
# Real Time Clock
#
# CONFIG_RTC_CLASS is not set

#
# DMA Engine support
#
# CONFIG_DMA_ENGINE is not set

#
# DMA Clients
#

#
# DMA Devices
#

#
# File systems
#
# CONFIG_EXT2_FS is not set
# CONFIG_EXT3_FS is not set
# CONFIG_REISERFS_FS is not set
# CONFIG_JFS_FS is not set
# CONFIG_FS_POSIX_ACL is not set
# CONFIG_XFS_FS is not set
# CONFIG_OCFS2_FS is not set
# CONFIG_MINIX_FS is not set
# CONFIG_ROMFS_FS is not set
# CONFIG_INOTIFY is not set
# CONFIG_QUOTA is not set
CONFIG_DNOTIFY=y
# CONFIG_AUTOFS_FS is not set
# CONFIG_AUTOFS4_FS is not set
# CONFIG_FUSE_FS is not set

#
# CD-ROM/DVD Filesystems
#
# CONFIG_ISO9660_FS is not set
# CONFIG_UDF_FS is not set

#
# DOS/FAT/NT Filesystems
#
# CONFIG_MSDOS_FS is not set
# CONFIG_VFAT_FS is not set
# CONFIG_NTFS_FS is not set

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
CONFIG_PROC_KCORE=y
CONFIG_PROC_VMCORE=y
CONFIG_SYSFS=y
CONFIG_TMPFS=y
CONFIG_HUGETLBFS=y
CONFIG_HUGETLB_PAGE=y
CONFIG_RAMFS=y
# CONFIG_CONFIGFS_FS is not set

#
# Miscellaneous filesystems
#
# CONFIG_ADFS_FS is not set
# CONFIG_AFFS_FS is not set
# CONFIG_HFS_FS is not set
# CONFIG_HFSPLUS_FS is not set
# CONFIG_BEFS_FS is not set
# CONFIG_BFS_FS is not set
# CONFIG_EFS_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set
# CONFIG_SYSV_FS is not set
# CONFIG_UFS_FS is not set

#
# Network File Systems
#
# CONFIG_NFS_FS is not set
# CONFIG_NFSD is not set
# CONFIG_SMB_FS is not set
# CONFIG_CIFS is not set
# CONFIG_NCP_FS is not set
# CONFIG_CODA_FS is not set
# CONFIG_AFS_FS is not set
# CONFIG_9P_FS is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y

#
# Native Language Support
#
# CONFIG_NLS is not set

#
# Library routines
#
# CONFIG_CRC_CCITT is not set
# CONFIG_CRC16 is not set
CONFIG_CRC32=y
# CONFIG_LIBCRC32C is not set
CONFIG_PLIST=y
CONFIG_GENERIC_HARDIRQS=y
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_IRQ_PER_CPU=y

#
# HP Simulator drivers
#
# CONFIG_HP_SIMETH is not set
CONFIG_HP_SIMSERIAL=y
CONFIG_HP_SIMSERIAL_CONSOLE=y
# CONFIG_HP_SIMSCSI is not set

#
# Instrumentation Support
#
# CONFIG_PROFILING is not set
# CONFIG_KPROBES is not set

#
# Kernel hacking
#
# CONFIG_PRINTK_TIME is not set
CONFIG_MAGIC_SYSRQ=y
# CONFIG_UNUSED_SYMBOLS is not set
CONFIG_DEBUG_KERNEL=y
CONFIG_LOG_BUF_SHIFT 
CONFIG_DETECT_SOFTLOCKUP=y
# CONFIG_SCHEDSTATS is not set
# CONFIG_DEBUG_SLAB is not set
# CONFIG_DEBUG_RT_MUTEXES is not set
# CONFIG_RT_MUTEX_TESTER is not set
# CONFIG_DEBUG_SPINLOCK is not set
CONFIG_DEBUG_MUTEXES=y
# CONFIG_DEBUG_RWSEMS is not set
# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
# CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set
# CONFIG_DEBUG_KOBJECT is not set
CONFIG_DEBUG_INFO=y
# CONFIG_DEBUG_FS is not set
# CONFIG_DEBUG_VM is not set
CONFIG_FORCED_INLINING=y
# CONFIG_RCU_TORTURE_TEST is not set
CONFIG_IA64_GRANULE_16MB=y
# CONFIG_IA64_GRANULE_64MB is not set
# CONFIG_IA64_PRINT_HAZARDS is not set
# CONFIG_DISABLE_VHPT is not set
# CONFIG_IA64_DEBUG_CMPXCHG is not set
# CONFIG_IA64_DEBUG_IRQ is not set
CONFIG_SYSVIPC_COMPAT=y

#
# Security options
#
# CONFIG_KEYS is not set
# CONFIG_SECURITY is not set

#
# Cryptographic options
#
# CONFIG_CRYPTO is not set

#
# Hardware crypto devices
#

-- 
VGER BF report: S 1

Re: NODE_DATA without CONFIG_NUMA

[Jes Sorensen]

>>>>> "Horms" = Horms  <horms@verge.net.au> writes:

Horms> Hi, I'm trying to build a non-NUMA (HP_SIM) config, and I am
Horms> running into trouble because there are serveral places where
Horms> NODE_DATA is used. It seems to me that this makes little sense
Horms> as NODE_DATA needs the node_data element of struct
Horms> cpuinfo_ia64, which doesn't exist without CONFIG_NUMA.

Horms> Is CONFIG_NUMA mandatory or is this just an oversight?

I haven't looked at the details, given you don't say where it breaks,
but it would make sense to me that a non-NUMA system is treated as a
single node system, eg. NODE_DATA(0) ought to be valid.

Cheers,
Jes

-- 
VGER BF report: U 0.501786

Re: NODE_DATA without CONFIG_NUMA

[KAMEZAWA Hiroyuki]

On Mon, 4 Sep 2006 16:06:06 +0900
Horms <horms@verge.net.au> wrote:

> Sure, 
> 
> here is a config that exhibits the problem.
> Though now you come to mention it, perhaps the config is invalid.
> 

it looks you selects CONFIG_DISCONTIGMEM and doesn't do CONFIG_NUMA.
interesting but ...

DISCONTIGMEM uses plural pg_data_t. This is represented by
CONFIG_NEED_MULTIPLE_NODES. 
So all codes which handles pgdats should depend on CONFIG_NEED_MULTIPLE_NODES.

But several pieces of codes uses CONFIG_NUMA instead of CONFIG_NEED_MULTIPLE_NODES.

for now, selecting CONFIG_FLATMEM is safe, I think.

-Kame


-- 
VGER BF report: U 0.775508

Re: NODE_DATA without CONFIG_NUMA

[Horms]

On Mon, Sep 04, 2006 at 03:43:35AM -0400, Jes Sorensen wrote:
> >>>>> "Horms" = Horms  <horms@verge.net.au> writes:
> 
> Horms> Hi, I'm trying to build a non-NUMA (HP_SIM) config, and I am
> Horms> running into trouble because there are serveral places where
> Horms> NODE_DATA is used. It seems to me that this makes little sense
> Horms> as NODE_DATA needs the node_data element of struct
> Horms> cpuinfo_ia64, which doesn't exist without CONFIG_NUMA.
> 
> Horms> Is CONFIG_NUMA mandatory or is this just an oversight?
> 
> I haven't looked at the details, given you don't say where it breaks,
> but it would make sense to me that a non-NUMA system is treated as a
> single node system, eg. NODE_DATA(0) ought to be valid.

I think it might actually be a config issue. Further experimentation
has found that arch/ia64/configs/sim_defconfig does compile.

For the record, I'm using Tony Luck's test tree, updated earlier today
to changest c8228f2cc1f1231620d09fd07f3d2324bfdebdcc with the config
I posted a little earlier. The first breakage I see is:

  CC      arch/ia64/kernel/asm-offsets.s
In file included from include/linux/slab.h:14,
                 from include/linux/percpu.h:4,
                 from include/linux/rcupdate.h:41,
                 from include/linux/pid.h:4,
                 from include/linux/sched.h:70,
                 from arch/ia64/kernel/asm-offsets.c:9:
include/linux/gfp.h: In function `alloc_pages_node':
include/linux/gfp.h:119: warning: implicit declaration of function
`NODE_DATA'
include/linux/gfp.h:119: error: invalid type argument of `->'

Which I believe is because nodedata.h is not included, as per
~line 83 of include/asm/processor.h

#ifdef CONFIG_NUMA
#include <asm/nodedata.h>
#endif

Including nodedata.h doesn't seem appropriate, as it does seem to
be numa-specific. I wasn't able to find an alternate definition of
CONFIG_NUMA

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


-- 
VGER BF report: U 0.580115

Re: NODE_DATA without CONFIG_NUMA

[Jes Sorensen]

Horms wrote:
> Which I believe is because nodedata.h is not included, as per
> ~line 83 of include/asm/processor.h
> 
> #ifdef CONFIG_NUMA
> #include <asm/nodedata.h>
> #endif
> 
> Including nodedata.h doesn't seem appropriate, as it does seem to
> be numa-specific. I wasn't able to find an alternate definition of
> CONFIG_NUMA

IMHO nodedata.h should provide alternative macros for non NUMA builds.
It seems silly to protect the include with #ifdef.

Cheers,
Jes


-- 
VGER BF report: U 0.5

Re: NODE_DATA without CONFIG_NUMA

[Horms]

On Mon, Sep 04, 2006 at 10:05:30AM +0200, Jes Sorensen wrote:
> Horms wrote:
> > Which I believe is because nodedata.h is not included, as per
> > ~line 83 of include/asm/processor.h
> > 
> > #ifdef CONFIG_NUMA
> > #include <asm/nodedata.h>
> > #endif
> > 
> > Including nodedata.h doesn't seem appropriate, as it does seem to
> > be numa-specific. I wasn't able to find an alternate definition of
> > CONFIG_NUMA
> 
> IMHO nodedata.h should provide alternative macros for non NUMA builds.
> It seems silly to protect the include with #ifdef.

That is pretty much what I was thinking.
But perhaps there is a reason for it.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


-- 
VGER BF report: U 0.753438

Re: NODE_DATA without CONFIG_NUMA

[Jes Sorensen]

Horms wrote:
> On Mon, Sep 04, 2006 at 10:05:30AM +0200, Jes Sorensen wrote:
>> IMHO nodedata.h should provide alternative macros for non NUMA builds.
>> It seems silly to protect the include with #ifdef.
> 
> That is pretty much what I was thinking.
> But perhaps there is a reason for it.

My guess is the reason is lack of testing of all obscure configurations
:) That said, #ifdef'ing out a kernel include like that is almost always
wrong.

Cheers,
Jes



-- 
VGER BF report: U 0.500033

Re: NODE_DATA without CONFIG_NUMA

[Christoph Lameter]

On Mon, 4 Sep 2006, Jes Sorensen wrote:

> I haven't looked at the details, given you don't say where it breaks,
> but it would make sense to me that a non-NUMA system is treated as a
> single node system, eg. NODE_DATA(0) ought to be valid.

NODE_DATA should always be available. The problem is likely due to 
DISCONTIG being associatiated tightly with NUMA.

Re: NODE_DATA without CONFIG_NUMA

[Jes Sorensen]

Christoph Lameter wrote:
> On Mon, 4 Sep 2006, Jes Sorensen wrote:
> 
>> I haven't looked at the details, given you don't say where it breaks,
>> but it would make sense to me that a non-NUMA system is treated as a
>> single node system, eg. NODE_DATA(0) ought to be valid.
> 
> NODE_DATA should always be available. The problem is likely due to 
> DISCONTIG being associatiated tightly with NUMA.

But DISCONTIG will probably go away at some point, so maybe it's time to
disentangle that?

Cheers,
Jes

Re: NODE_DATA without CONFIG_NUMA

[Christoph Lameter]

On Mon, 4 Sep 2006, Jes Sorensen wrote:

> Christoph Lameter wrote:
> > On Mon, 4 Sep 2006, Jes Sorensen wrote:
> > 
> > > I haven't looked at the details, given you don't say where it breaks,
> > > but it would make sense to me that a non-NUMA system is treated as a
> > > single node system, eg. NODE_DATA(0) ought to be valid.
> > 
> > NODE_DATA should always be available. The problem is likely due to DISCONTIG
> > being associatiated tightly with NUMA.
> 
> But DISCONTIG will probably go away at some point, so maybe it's time to
> disentangle that?

I think we should fix the bug.

Disentangle is good but we cannot get rid of DISCONTIG since SPARSEMEM so 
far does not match DISCONTIG performance since it does not support 
virtual mem_map. See the recent discussion in regards to virt_to_page().