* [PATCH] iounmap after ioremap in error path: arch/ia64/pci/pci.c @ 2007-11-03 23:36 Roel Kluin 2007-11-05 2:13 ` Simon Horman 0 siblings, 1 reply; 2+ messages in thread From: Roel Kluin @ 2007-11-03 23:36 UTC (permalink / raw) To: linux-ia64 Do iounmap when too many IO port spaces were encountered Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c index 488e48a..13a05d7 100644 --- a/arch/ia64/pci/pci.c +++ b/arch/ia64/pci/pci.c @@ -154,6 +154,7 @@ new_space (u64 phys_base, int sparse) return i; if (num_io_spaces = MAX_IO_SPACES) { + iounmap(mmio_base); printk(KERN_ERR "PCI: Too many IO port spaces " "(MAX_IO_SPACES=%lu)\n", MAX_IO_SPACES); return ~0; ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iounmap after ioremap in error path: arch/ia64/pci/pci.c 2007-11-03 23:36 [PATCH] iounmap after ioremap in error path: arch/ia64/pci/pci.c Roel Kluin @ 2007-11-05 2:13 ` Simon Horman 0 siblings, 0 replies; 2+ messages in thread From: Simon Horman @ 2007-11-05 2:13 UTC (permalink / raw) To: linux-ia64 On Sun, Nov 04, 2007 at 12:36:50AM +0100, Roel Kluin wrote: > Do iounmap when too many IO port spaces were encountered > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> This looks correct to me, so long as calling iounmap() actually reverses ioremap() in this case. > --- > diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c > index 488e48a..13a05d7 100644 > --- a/arch/ia64/pci/pci.c > +++ b/arch/ia64/pci/pci.c > @@ -154,6 +154,7 @@ new_space (u64 phys_base, int sparse) > return i; > > if (num_io_spaces = MAX_IO_SPACES) { > + iounmap(mmio_base); > printk(KERN_ERR "PCI: Too many IO port spaces " > "(MAX_IO_SPACES=%lu)\n", MAX_IO_SPACES); > return ~0; > - > To unsubscribe from this list: send the line "unsubscribe linux-ia64" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-05 2:13 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-11-03 23:36 [PATCH] iounmap after ioremap in error path: arch/ia64/pci/pci.c Roel Kluin 2007-11-05 2:13 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox