public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 1/3] ia64: fix ptrace inside a namespace
@ 2008-03-04 23:14 akpm
  2008-03-06  8:17 ` Petr Tesarik
  2008-03-06 17:03 ` Luck, Tony
  0 siblings, 2 replies; 3+ messages in thread
From: akpm @ 2008-03-04 23:14 UTC (permalink / raw)
  To: linux-ia64

From: Pavel Emelyanov <xemul@openvz.org>

The ia64 has its own sys_ptrace implementation and it was overlooked when the
pid namespaces patches were sent.

Use find_task_by_vpid() in it.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/ia64/kernel/ptrace.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/ia64/kernel/ptrace.c~ia64-fix-ptrace-inside-a-namespace arch/ia64/kernel/ptrace.c
--- a/arch/ia64/kernel/ptrace.c~ia64-fix-ptrace-inside-a-namespace
+++ a/arch/ia64/kernel/ptrace.c
@@ -1561,7 +1561,7 @@ sys_ptrace (long request, pid_t pid, uns
 	ret = -ESRCH;
 	read_lock(&tasklist_lock);
 	{
-		child = find_task_by_pid(pid);
+		child = find_task_by_vpid(pid);
 		if (child) {
 			if (peek_or_poke)
 				child = find_thread_for_addr(child, addr);
_

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 1/3] ia64: fix ptrace inside a namespace
  2008-03-04 23:14 [patch 1/3] ia64: fix ptrace inside a namespace akpm
@ 2008-03-06  8:17 ` Petr Tesarik
  2008-03-06 17:03 ` Luck, Tony
  1 sibling, 0 replies; 3+ messages in thread
From: Petr Tesarik @ 2008-03-06  8:17 UTC (permalink / raw)
  To: linux-ia64

On Tue, 2008-03-04 at 15:14 -0800, akpm@linux-foundation.org wrote:
> From: Pavel Emelyanov <xemul@openvz.org>
> 
> The ia64 has its own sys_ptrace implementation and it was overlooked when the
> pid namespaces patches were sent.
> 
> Use find_task_by_vpid() in it.

And there we are. If we don't push the ptrace() changes into mainline
soon, mainline will drift away from us. :(

Cheers,
Petr Tesarik

> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> Cc: "Luck, Tony" <tony.luck@intel.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  arch/ia64/kernel/ptrace.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN arch/ia64/kernel/ptrace.c~ia64-fix-ptrace-inside-a-namespace arch/ia64/kernel/ptrace.c
> --- a/arch/ia64/kernel/ptrace.c~ia64-fix-ptrace-inside-a-namespace
> +++ a/arch/ia64/kernel/ptrace.c
> @@ -1561,7 +1561,7 @@ sys_ptrace (long request, pid_t pid, uns
>  	ret = -ESRCH;
>  	read_lock(&tasklist_lock);
>  	{
> -		child = find_task_by_pid(pid);
> +		child = find_task_by_vpid(pid);
>  		if (child) {
>  			if (peek_or_poke)
>  				child = find_thread_for_addr(child, addr);
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [patch 1/3] ia64: fix ptrace inside a namespace
  2008-03-04 23:14 [patch 1/3] ia64: fix ptrace inside a namespace akpm
  2008-03-06  8:17 ` Petr Tesarik
@ 2008-03-06 17:03 ` Luck, Tony
  1 sibling, 0 replies; 3+ messages in thread
From: Luck, Tony @ 2008-03-06 17:03 UTC (permalink / raw)
  To: linux-ia64

> And there we are. If we don't push the ptrace() changes into mainline
> soon, mainline will drift away from us. :(

I staged your patches into my tree yesterday ... I'll push to Linus
soon.

-Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-03-06 17:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-04 23:14 [patch 1/3] ia64: fix ptrace inside a namespace akpm
2008-03-06  8:17 ` Petr Tesarik
2008-03-06 17:03 ` Luck, Tony

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox