From: Simon Horman <horms@verge.net.au>
To: kexec@lists.infradead.org, linux-ia64@vger.kernel.org,
lkml@vger.kernel.org
Cc: Vivek Goyal <vgoyal@redhat.com>
Subject: [patch 1/3] kdump: use is_kdump_kernel() in sba_init()
Date: Tue, 29 Jul 2008 08:12:36 +0000 [thread overview]
Message-ID: <20080729081629.356523305@vergenet.net> (raw)
In-Reply-To: 20080729081235.293361145@vergenet.net
After recent patches* is_kdump_kernel() should return 1 in the
case where code is executing in a crashkernel and 0 otherwise.
It is save to use outside of CONFIG_KDUMP.
* http://lkml.org/lkml/2008/7/28/445
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: linux-2.6/arch/ia64/hp/common/sba_iommu.c
=================================--- linux-2.6.orig/arch/ia64/hp/common/sba_iommu.c 2008-07-29 10:57:17.000000000 +1000
+++ linux-2.6/arch/ia64/hp/common/sba_iommu.c 2008-07-29 10:57:51.000000000 +1000
@@ -2070,14 +2070,13 @@ sba_init(void)
if (!ia64_platform_is("hpzx1") && !ia64_platform_is("hpzx1_swiotlb"))
return 0;
-#if defined(CONFIG_IA64_GENERIC) && defined(CONFIG_CRASH_DUMP) && \
- defined(CONFIG_PROC_FS)
+#if defined(CONFIG_IA64_GENERIC)
/* If we are booting a kdump kernel, the sba_iommu will
* cause devices that were not shutdown properly to MCA
* as soon as they are turned back on. Our only option for
* a successful kdump kernel boot is to use the swiotlb.
*/
- if (elfcorehdr_addr < ELFCORE_ADDR_MAX) {
+ if (is_kdump_kernel()) {
if (swiotlb_late_init_with_default_size(64 * (1<<20)) != 0)
panic("Unable to initialize software I/O TLB:"
" Try machvec=dig boot option");
--
--
Horms
next parent reply other threads:[~2008-07-29 8:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080729081235.293361145@vergenet.net>
2008-07-29 8:12 ` Simon Horman [this message]
2008-07-29 14:51 ` [patch 1/3] kdump: use is_kdump_kernel() in sba_init() Vivek Goyal
2008-07-29 22:40 ` Simon Horman
2008-07-29 23:15 ` Simon Horman
2008-07-30 12:55 ` Vivek Goyal
2008-07-29 8:12 ` [patch 2/3] kdump: add is_vmcore_usable() and vmcore_unusable() Simon Horman
2008-07-29 15:15 ` Vivek Goyal
2008-07-29 22:39 ` Simon Horman
2008-07-29 23:16 ` Simon Horman
2008-07-29 8:12 ` [patch 3/3] kdump: use is_vmcore_usable() and vmcore_unusable() in reserve_elfcorehdr() Simon Horman
2008-07-30 13:01 ` [patch 3/3] kdump: use is_vmcore_usable() and Vivek Goyal
2008-07-31 0:48 ` Simon Horman
2008-07-31 13:21 ` Vivek Goyal
2008-08-01 4:08 ` Simon Horman
2008-08-05 7:19 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729081629.356523305@vergenet.net \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=lkml@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox