From: Simon Horman <horms@verge.net.au>
To: kexec@lists.infradead.org, linux-ia64@vger.kernel.org,
lkml@vger.kernel.org
Cc: Vivek Goyal <vgoyal@redhat.com>
Subject: [patch 3/3] kdump: use is_vmcore_usable() and vmcore_unusable() in reserve_elfcorehdr()
Date: Tue, 29 Jul 2008 08:12:38 +0000 [thread overview]
Message-ID: <20080729081629.715923799@vergenet.net> (raw)
In-Reply-To: 20080729081235.293361145@vergenet.net
After recent changes setting elfcorehdr_addr to ELFCORE_ADDR_MAX
will cause is_kdump_kernel() to return 0 when it should return 1.
Instead use vmcore_unusable(), which has been added for this purpose.
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: linux-2.6/arch/ia64/kernel/setup.c
=================================--- linux-2.6.orig/arch/ia64/kernel/setup.c 2008-07-29 17:27:43.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/setup.c 2008-07-29 17:50:50.000000000 +1000
@@ -502,11 +502,11 @@ int __init reserve_elfcorehdr(unsigned l
* to work properly.
*/
- if (elfcorehdr_addr >= ELFCORE_ADDR_MAX)
+ if (!is_vmcore_usable())
return -EINVAL;
if ((length = vmcore_find_descriptor_size(elfcorehdr_addr)) = 0) {
- elfcorehdr_addr = ELFCORE_ADDR_MAX;
+ vmcore_unusable();
return -EINVAL;
}
--
--
Horms
next prev parent reply other threads:[~2008-07-29 8:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080729081235.293361145@vergenet.net>
2008-07-29 8:12 ` [patch 1/3] kdump: use is_kdump_kernel() in sba_init() Simon Horman
2008-07-29 14:51 ` Vivek Goyal
2008-07-29 22:40 ` Simon Horman
2008-07-29 23:15 ` Simon Horman
2008-07-30 12:55 ` Vivek Goyal
2008-07-29 8:12 ` [patch 2/3] kdump: add is_vmcore_usable() and vmcore_unusable() Simon Horman
2008-07-29 15:15 ` Vivek Goyal
2008-07-29 22:39 ` Simon Horman
2008-07-29 23:16 ` Simon Horman
2008-07-29 8:12 ` Simon Horman [this message]
2008-07-30 13:01 ` [patch 3/3] kdump: use is_vmcore_usable() and Vivek Goyal
2008-07-31 0:48 ` Simon Horman
2008-07-31 13:21 ` Vivek Goyal
2008-08-01 4:08 ` Simon Horman
2008-08-05 7:19 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729081629.715923799@vergenet.net \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=lkml@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox