From: Frans Pop <elendil@planet.nl>
To: Peter Chubb <peterc@gelato.unsw.edu.au>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-ia64@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ia64: minor Makefile simplification through use of cc-ifversion
Date: Fri, 24 Jul 2009 18:23:11 +0000 [thread overview]
Message-ID: <200907242023.12478.elendil@planet.nl> (raw)
In-Reply-To: <87ws5yoo44.wl%peterc@nicta.com.au>
On Friday 24 July 2009, Peter Chubb wrote:
> >>>>> "Sam" = Sam Ravnborg <sam@ravnborg.org> writes:
> Sam> The above change is correct. But I really wonder if the original
> Sam> code was correct? Do we really only want to use the -mtune
> Sam> options for this specific gcc version? If this is indeed the
> Sam> case this deserves a comment explaning this.
>
> I suspect it should be all compilers after this one. -mtune=mckinley
> didn't work very well in the early gcc 3 compilers and didn't exist in
> version 2.
How would you like to handle that? As it is essentially a separate issue,
my suggestion would be: apply my patch as is and then (if needed) commit
a separate patch to fix the incorrect comparisons on top.
Cheers,
FJP
next prev parent reply other threads:[~2009-07-24 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 18:56 [PATCH] ia64: minor Makefile simplification through use of cc-ifversion Frans Pop
2009-07-23 21:28 ` [PATCH] ia64: minor Makefile simplification through use of Sam Ravnborg
2009-07-24 1:39 ` [PATCH] ia64: minor Makefile simplification through use of cc-ifversion Peter Chubb
2009-07-24 18:23 ` Frans Pop [this message]
2009-07-24 23:15 ` Fenghua Yu
2009-07-24 23:25 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907242023.12478.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterc@gelato.unsw.edu.au \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox