* Re: [PATCH] STAGING: Comedi: Build only on arches providing
[not found] ` <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org>
@ 2011-06-23 15:05 ` Ralf Baechle
0 siblings, 0 replies; only message in thread
From: Ralf Baechle @ 2011-06-23 15:05 UTC (permalink / raw)
To: Kumar Gala
Cc: devel, David Howells, linux-m32r, linux-ia64, Paul Mundt,
linux-sh, Benjamin Herrenschmidt, Greg Kroah-Hartman,
linux-kernel, Chris Metcalf, Martyn Welch, Fenghua Yu,
linuxppc-dev@lists.ozlabs.org Tony Luck, linux-am33-list,
Paul Mackerras, linux-m32r-ja, H. Peter Anvin, Thomas Gleixner,
linux-arch, Ingo Molnar, x86
On Thu, Jun 23, 2011 at 07:10:29AM -0500, Kumar Gala wrote:
> > (Adding the PPC folks to cc.)
> >
> > A "git grep -w PAGE_KERNEL_NOCACHE arch/powerpc/" doesn't find anything so
> > I don't think the driver will build there. I don't have a PPC toolchain
> > to verify that.
>
> I can verify it fails on PPC as well:
>
> drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
> drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
> drivers/staging/comedi/drivers.c:505:37: note: each undeclared identifier is reported only once for each function it appears in
>
> However, we do have a #define for PAGE_KERNEL_NC.
Do you think this driver in it's current stage is so valuable that some
ifdefery to get it to work on PPC is the way to go?
IA-64 has PAGE_KERNEL_UC, so basically the same question for IA-64, too.
But preferably the driver should be sorted out properly and until the v1
of my patch which disables it on all architectures that don't provide a
PAGE_KERNEL_NOCACHE definition will do just fine.
Ralf
^ permalink raw reply [flat|nested] only message in thread