* swiotlb_sync_sg() issue?
@ 2006-12-19 11:10 Jan Beulich
2006-12-19 13:26 ` [discuss] " Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2006-12-19 11:10 UTC (permalink / raw)
To: linux-ia64
Due to its apparent obviousness, I'm afraid I'm missing something, but isn't it
incorrect that lib/swiotlb.c:swiotlb_sync_sg() calls sync_single() with
sg->dma_address simply cast to void* rather than going through phys_to_virt()?
Also, for ia64, isn't mark_clean() violating its own comment, i.e. to mark only
*complete* pages? And then, for completeness, isn't swiotlb_sync_sg() missing
the call to mark_clean()?
Thanks, Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [discuss] swiotlb_sync_sg() issue?
2006-12-19 11:10 swiotlb_sync_sg() issue? Jan Beulich
@ 2006-12-19 13:26 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2006-12-19 13:26 UTC (permalink / raw)
To: linux-ia64
>>> "Jan Beulich" <jbeulich@novell.com> 19.12.06 12:10 >>>
>Due to its apparent obviousness, I'm afraid I'm missing something, but isn't it
>incorrect that lib/swiotlb.c:swiotlb_sync_sg() calls sync_single() with
>sg->dma_address simply cast to void* rather than going through phys_to_virt()?
>
>Also, for ia64, isn't mark_clean() violating its own comment, i.e. to mark only
>*complete* pages? And then, for completeness, isn't swiotlb_sync_sg() missing
>the call to mark_clean()?
Okay, I see I mis-read mark_clean(), it's not violating what it claims to do. But
the other two questions remain.
Thanks, Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-19 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-19 11:10 swiotlb_sync_sg() issue? Jan Beulich
2006-12-19 13:26 ` [discuss] " Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox