* [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c
@ 2007-11-04 11:12 Roel Kluin
2007-11-05 2:17 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Roel Kluin @ 2007-11-04 11:12 UTC (permalink / raw)
To: linux-ia64
Do iounmap if tioce_kern_init fails
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
index cee9379..128ed07 100644
--- a/arch/ia64/sn/pci/tioce_provider.c
+++ b/arch/ia64/sn/pci/tioce_provider.c
@@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
tioce_kern = tioce_kern_init(tioce_common);
if (tioce_kern = NULL) {
+ iounmap(tioce_common->ce_pcibus.bs_base);
kfree(tioce_common);
return NULL;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c
2007-11-04 11:12 [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c Roel Kluin
@ 2007-11-05 2:17 ` Simon Horman
2007-11-05 9:10 ` Roel Kluin
2007-11-05 9:34 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2007-11-05 2:17 UTC (permalink / raw)
To: linux-ia64
On Sun, Nov 04, 2007 at 12:12:23PM +0100, Roel Kluin wrote:
> Do iounmap if tioce_kern_init fails
This is covered by a subsequent patch, right?
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> index cee9379..128ed07 100644
> --- a/arch/ia64/sn/pci/tioce_provider.c
> +++ b/arch/ia64/sn/pci/tioce_provider.c
> @@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
>
> tioce_kern = tioce_kern_init(tioce_common);
> if (tioce_kern = NULL) {
> + iounmap(tioce_common->ce_pcibus.bs_base);
> kfree(tioce_common);
> return NULL;
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c
2007-11-04 11:12 [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c Roel Kluin
2007-11-05 2:17 ` Simon Horman
@ 2007-11-05 9:10 ` Roel Kluin
2007-11-05 9:34 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Roel Kluin @ 2007-11-05 9:10 UTC (permalink / raw)
To: linux-ia64
Simon Horman wrote:
> On Sun, Nov 04, 2007 at 12:12:23PM +0100, Roel Kluin wrote:
>> Do iounmap if tioce_kern_init fails
>
> This is covered by a subsequent patch, right?
aparently it should, what am I missing?
>> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
>> ---
>> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
>> index cee9379..128ed07 100644
>> --- a/arch/ia64/sn/pci/tioce_provider.c
>> +++ b/arch/ia64/sn/pci/tioce_provider.c
>> @@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
>>
>> tioce_kern = tioce_kern_init(tioce_common);
>> if (tioce_kern = NULL) {
>> + iounmap(tioce_common->ce_pcibus.bs_base);
>> kfree(tioce_common);
>> return NULL;
>> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c
2007-11-04 11:12 [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c Roel Kluin
2007-11-05 2:17 ` Simon Horman
2007-11-05 9:10 ` Roel Kluin
@ 2007-11-05 9:34 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2007-11-05 9:34 UTC (permalink / raw)
To: linux-ia64
On Mon, Nov 05, 2007 at 10:10:13AM +0100, Roel Kluin wrote:
> Simon Horman wrote:
> > On Sun, Nov 04, 2007 at 12:12:23PM +0100, Roel Kluin wrote:
> >> Do iounmap if tioce_kern_init fails
> >
> > This is covered by a subsequent patch, right?
>
> aparently it should, what am I missing?
Nothing, I was just confirming that it is duplicated elsewhere :-)
> >> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> >> ---
> >> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> >> index cee9379..128ed07 100644
> >> --- a/arch/ia64/sn/pci/tioce_provider.c
> >> +++ b/arch/ia64/sn/pci/tioce_provider.c
> >> @@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
> >>
> >> tioce_kern = tioce_kern_init(tioce_common);
> >> if (tioce_kern = NULL) {
> >> + iounmap(tioce_common->ce_pcibus.bs_base);
> >> kfree(tioce_common);
> >> return NULL;
> >> }
>
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-05 9:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-04 11:12 [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c Roel Kluin
2007-11-05 2:17 ` Simon Horman
2007-11-05 9:10 ` Roel Kluin
2007-11-05 9:34 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox