Incorrect return types for atomic64 functions in IA64 atomic.h

Incorrect return types for atomic64 functions in IA64 atomic.h

[Jerry Feldman]

The return values for the atomic64 functions in /usr/include/asm/atomic.h 
are defined as int and should be __s64 to match the type of the input 
parameter and local variable returned. My patch follows:
----------------------------------------
--- atomic.h.orig       2005-04-29 14:30:34.660126000 -0400
+++ atomic.h    2005-04-29 14:32:57.533791322 -0400
@@ -48,7 +48,7 @@ ia64_atomic_add (int i, atomic_t *v)
        return new;
 }
 
-static __inline__ int
+static __inline__ __s64
 ia64_atomic64_add (__s64 i, atomic64_t *v)
 {
        __s64 old, new;
@@ -76,7 +76,7 @@ ia64_atomic_sub (int i, atomic_t *v)
        return new;
 }
 
-static __inline__ int
+static __inline__ __s64
 ia64_atomic64_sub (__s64 i, atomic64_t *v)
 {
        __s64 old, new;
@@ -124,7 +124,7 @@ atomic_add_negative (int i, atomic_t *v)
        return atomic_add_return(i, v) < 0;
 }
 
-static __inline__ int
+static __inline__ __s64
 atomic64_add_negative (__s64 i, atomic64_t *v)
 {
        return atomic64_add_return(i, v) < 0;
-------------------------------------------------------
-- 
Jerry Feldman <gerald.feldman@hp.com>
Partner Technology Access Center (contractor) (PTAC-MA)
Hewlett-Packard Co.
550 King Street LKG2a-X2
Littleton, Ma. 01460
 (978)506-5243

Re: Incorrect return types for atomic64 functions in IA64 atomic.h

[Andreas Schwab]

Jerry Feldman <gerald.feldman@hp.com> writes:

> @@ -124,7 +124,7 @@ atomic_add_negative (int i, atomic_t *v)
>         return atomic_add_return(i, v) < 0;
>  }
>  
> -static __inline__ int
> +static __inline__ __s64
>  atomic64_add_negative (__s64 i, atomic64_t *v)
>  {
>         return atomic64_add_return(i, v) < 0;

This is wrong.  The return value is a boolean.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Incorrect return types for atomic64 functions in IA64 atomic.h

[Jerry Feldman]

On Friday 29 April 2005 3:10 pm, Andreas Schwab wrote:
> Jerry Feldman <gerald.feldman@hp.com> writes:
> > @@ -124,7 +124,7 @@ atomic_add_negative (int i, atomic_t *v)
> >         return atomic_add_return(i, v) < 0;
> >  }
> >
> > -static __inline__ int
> > +static __inline__ __s64
> >  atomic64_add_negative (__s64 i, atomic64_t *v)
> >  {
> >         return atomic64_add_return(i, v) < 0;
>
> This is wrong.  The return value is a boolean.
I agree. Should I resubmit the patch corrected, or will someone else do it.

-- 
Jerry Feldman <gerald.feldman@hp.com>
Partner Technology Access Center (contractor) (PTAC-MA)
Hewlett-Packard Co.
550 King Street LKG2a-X2
Littleton, Ma. 01460
 (978)506-5243

Incorrect return types for atomic64 functions in IA64 atomic.h (corrected)

[Jerry Feldman]

The return values for the atomic64 functions in /usr/include/asm/atomic.h 
are defined as int and should be __s64 to match the type of the input 
parameter and local variable returned. My patch follows:
----------------------------------------
--- atomic.h.orig       2005-04-29 14:30:34.660126000 -0400
+++ atomic.h    2005-04-29 15:40:34.265825617 -0400
@@ -48,7 +48,7 @@ ia64_atomic_add (int i, atomic_t *v)
        return new;
 }
 
-static __inline__ int
+static __inline__ __s64
 ia64_atomic64_add (__s64 i, atomic64_t *v)
 {
        __s64 old, new;
@@ -76,7 +76,7 @@ ia64_atomic_sub (int i, atomic_t *v)
        return new;
 }
 
-static __inline__ int
+static __inline__ __s64
 ia64_atomic64_sub (__s64 i, atomic64_t *v)
 {
        __s64 old, new;
-------------------------------------------------------
-- 
Jerry Feldman <gerald.feldman@hp.com>
Partner Technology Access Center (contractor) (PTAC-MA)
Hewlett-Packard Co.
550 King Street LKG2a-X2
Littleton, Ma. 01460
 (978)506-5243