[Linux-ia64] [PATCH] fix for modules_install

[Linux-ia64] [PATCH] fix for modules_install

[Uros Prestor]

[-- Attachment #1: Type: text/plain, Size: 138 bytes --]

This trivial patch against 2.4.0-test6 + 000812 fixes a problem with
modules_install target.

Uros

--
Uros Prestor
uros@turbolinux.com



[-- Attachment #2: linux-2.4.0-test6-ia64-modinstall.patch --]
[-- Type: text/plain, Size: 371 bytes --]

diff -ruN linux-2.4.0-test6-000811/arch/ia64/tools/Makefile linux-2.4.0-test6-000811.modules/arch/ia64/tools/Makefile
--- linux-2.4.0-test6-000811/arch/ia64/tools/Makefile	Fri Jul 14 16:08:12 2000
+++ linux-2.4.0-test6-000811.modules/arch/ia64/tools/Makefile	Tue Aug 15 15:53:02 2000
@@ -46,4 +46,4 @@
 
 endif
 
-.PHONY: all modules
+.PHONY: all modules modules_install

Re: [Linux-ia64] [PATCH] fix for modules_install

[Keith Owens]

On Tue, 15 Aug 2000 16:43:39 -0700, 
Uros Prestor <uros@turbolinux.com> wrote:
>This trivial patch against 2.4.0-test6 + 000812 fixes a problem with
>modules_install target.
>
>-.PHONY: all modules
>+.PHONY: all modules modules_install

What problem does it fix?

Re: [Linux-ia64] [PATCH] fix for modules_install

[Uros Prestor]

Keith Owens wrote:

> On Tue, 15 Aug 2000 16:43:39 -0700,
> Uros Prestor <uros@turbolinux.com> wrote:
> >This trivial patch against 2.4.0-test6 + 000812 fixes a problem with
> >modules_install target.
> >
> >-.PHONY: all modules
> >+.PHONY: all modules modules_install
>
> What problem does it fix?

File arch/ia64/tools/Makefile didn't have a target modules_install so
`make modules_install' returned an error.  This patch adds a phony
target which does nothing.

Uros

--
Uros Prestor
uros@turbolinux.com

Re: [Linux-ia64] [PATCH] fix for modules_install

[Keith Owens]

On Tue, 15 Aug 2000 20:20:04 -0700, 
Uros Prestor <uros@turbolinux.com> wrote:
>Keith Owens wrote:
>
>> On Tue, 15 Aug 2000 16:43:39 -0700,
>> Uros Prestor <uros@turbolinux.com> wrote:
>> >This trivial patch against 2.4.0-test6 + 000812 fixes a problem with
>> >modules_install target.
>> >
>> >-.PHONY: all modules
>> >+.PHONY: all modules modules_install
>>
>> What problem does it fix?
>
>File arch/ia64/tools/Makefile didn't have a target modules_install so
>`make modules_install' returned an error.  This patch adds a phony
>target which does nothing.

arch/ia64/tools/Makefile should include Rules.make instead of adding
its own target and .PHONY rules.  see arch/mips/tools/Makefile.  AFAICT
there is no reason not to include Rules.make.

Re: [Linux-ia64] [PATCH] fix for modules_install

[David Mosberger]

>>>>> On Wed, 16 Aug 2000 09:06:39 -0700, Keith Owens <kaos@ocs.com.au> said:

  Keith> arch/ia64/tools/Makefile should include Rules.make instead of
  Keith> adding its own target and .PHONY rules.  see
  Keith> arch/mips/tools/Makefile.  AFAICT there is no reason not to
  Keith> include Rules.make.

I'd be happy to make the change _if_ it's really safe to do so.  We're
doing some weird build tricks in a cross-build environment and I want
to make sure we don't break that code.

	--david