* [Linux-ia64] [PATCH] fix for modules_install
@ 2000-08-15 23:43 Uros Prestor
2000-08-16 3:00 ` Keith Owens
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Uros Prestor @ 2000-08-15 23:43 UTC (permalink / raw)
To: linux-ia64
[-- Attachment #1: Type: text/plain, Size: 138 bytes --]
This trivial patch against 2.4.0-test6 + 000812 fixes a problem with
modules_install target.
Uros
--
Uros Prestor
uros@turbolinux.com
[-- Attachment #2: linux-2.4.0-test6-ia64-modinstall.patch --]
[-- Type: text/plain, Size: 371 bytes --]
diff -ruN linux-2.4.0-test6-000811/arch/ia64/tools/Makefile linux-2.4.0-test6-000811.modules/arch/ia64/tools/Makefile
--- linux-2.4.0-test6-000811/arch/ia64/tools/Makefile Fri Jul 14 16:08:12 2000
+++ linux-2.4.0-test6-000811.modules/arch/ia64/tools/Makefile Tue Aug 15 15:53:02 2000
@@ -46,4 +46,4 @@
endif
-.PHONY: all modules
+.PHONY: all modules modules_install
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Linux-ia64] [PATCH] fix for modules_install
2000-08-15 23:43 [Linux-ia64] [PATCH] fix for modules_install Uros Prestor
@ 2000-08-16 3:00 ` Keith Owens
2000-08-16 3:20 ` Uros Prestor
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Keith Owens @ 2000-08-16 3:00 UTC (permalink / raw)
To: linux-ia64
On Tue, 15 Aug 2000 16:43:39 -0700,
Uros Prestor <uros@turbolinux.com> wrote:
>This trivial patch against 2.4.0-test6 + 000812 fixes a problem with
>modules_install target.
>
>-.PHONY: all modules
>+.PHONY: all modules modules_install
What problem does it fix?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Linux-ia64] [PATCH] fix for modules_install
2000-08-15 23:43 [Linux-ia64] [PATCH] fix for modules_install Uros Prestor
2000-08-16 3:00 ` Keith Owens
@ 2000-08-16 3:20 ` Uros Prestor
2000-08-16 16:06 ` Keith Owens
2000-08-17 21:27 ` David Mosberger
3 siblings, 0 replies; 5+ messages in thread
From: Uros Prestor @ 2000-08-16 3:20 UTC (permalink / raw)
To: linux-ia64
Keith Owens wrote:
> On Tue, 15 Aug 2000 16:43:39 -0700,
> Uros Prestor <uros@turbolinux.com> wrote:
> >This trivial patch against 2.4.0-test6 + 000812 fixes a problem with
> >modules_install target.
> >
> >-.PHONY: all modules
> >+.PHONY: all modules modules_install
>
> What problem does it fix?
File arch/ia64/tools/Makefile didn't have a target modules_install so
`make modules_install' returned an error. This patch adds a phony
target which does nothing.
Uros
--
Uros Prestor
uros@turbolinux.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Linux-ia64] [PATCH] fix for modules_install
2000-08-15 23:43 [Linux-ia64] [PATCH] fix for modules_install Uros Prestor
2000-08-16 3:00 ` Keith Owens
2000-08-16 3:20 ` Uros Prestor
@ 2000-08-16 16:06 ` Keith Owens
2000-08-17 21:27 ` David Mosberger
3 siblings, 0 replies; 5+ messages in thread
From: Keith Owens @ 2000-08-16 16:06 UTC (permalink / raw)
To: linux-ia64
On Tue, 15 Aug 2000 20:20:04 -0700,
Uros Prestor <uros@turbolinux.com> wrote:
>Keith Owens wrote:
>
>> On Tue, 15 Aug 2000 16:43:39 -0700,
>> Uros Prestor <uros@turbolinux.com> wrote:
>> >This trivial patch against 2.4.0-test6 + 000812 fixes a problem with
>> >modules_install target.
>> >
>> >-.PHONY: all modules
>> >+.PHONY: all modules modules_install
>>
>> What problem does it fix?
>
>File arch/ia64/tools/Makefile didn't have a target modules_install so
>`make modules_install' returned an error. This patch adds a phony
>target which does nothing.
arch/ia64/tools/Makefile should include Rules.make instead of adding
its own target and .PHONY rules. see arch/mips/tools/Makefile. AFAICT
there is no reason not to include Rules.make.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Linux-ia64] [PATCH] fix for modules_install
2000-08-15 23:43 [Linux-ia64] [PATCH] fix for modules_install Uros Prestor
` (2 preceding siblings ...)
2000-08-16 16:06 ` Keith Owens
@ 2000-08-17 21:27 ` David Mosberger
3 siblings, 0 replies; 5+ messages in thread
From: David Mosberger @ 2000-08-17 21:27 UTC (permalink / raw)
To: linux-ia64
>>>>> On Wed, 16 Aug 2000 09:06:39 -0700, Keith Owens <kaos@ocs.com.au> said:
Keith> arch/ia64/tools/Makefile should include Rules.make instead of
Keith> adding its own target and .PHONY rules. see
Keith> arch/mips/tools/Makefile. AFAICT there is no reason not to
Keith> include Rules.make.
I'd be happy to make the change _if_ it's really safe to do so. We're
doing some weird build tricks in a cross-build environment and I want
to make sure we don't break that code.
--david
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2000-08-17 21:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2000-08-15 23:43 [Linux-ia64] [PATCH] fix for modules_install Uros Prestor
2000-08-16 3:00 ` Keith Owens
2000-08-16 3:20 ` Uros Prestor
2000-08-16 16:06 ` Keith Owens
2000-08-17 21:27 ` David Mosberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox