[PATCH] - Increase max number of nodes (cpu_to_node_map)

[PATCH] - Increase max number of nodes (cpu_to_node_map)

[Jack Steiner]

I hit a problem with systems having > 256 nodes. The
cpu_to_node_map array is an array of char - needs to be 
bigger.

Here is a patch that changes it to a short.



--- linux_base/arch/ia64/kernel/smpboot.c	Wed Nov  5 08:39:40 2003
+++ linux/arch/ia64/kernel/smpboot.c	Wed Nov  5 12:30:12 2003
@@ -466,7 +466,7 @@
 #ifdef CONFIG_NUMA
 
 /* on which node is each logical CPU (one cacheline even for 64 CPUs) */
-volatile char cpu_to_node_map[NR_CPUS] __cacheline_aligned;
+volatile short cpu_to_node_map[NR_CPUS] __cacheline_aligned;
 /* which logical CPUs are on which nodes */
 volatile cpumask_t node_to_cpu_mask[MAX_NUMNODES] __cacheline_aligned;
 
--- linux_base/include/asm-ia64/numa.h	Wed Nov  5 12:49:18 2003
+++ linux/include/asm-ia64/numa.h	Wed Nov  5 12:31:04 2003
@@ -24,7 +24,7 @@
 
 #include <asm/mmzone.h>
 
-extern volatile char cpu_to_node_map[NR_CPUS] __cacheline_aligned;
+extern volatile short cpu_to_node_map[NR_CPUS] __cacheline_aligned;
 extern volatile cpumask_t node_to_cpu_mask[MAX_NUMNODES] __cacheline_aligned;
 
 /* Stuff below this line could be architecture independent */




-- 
Thanks

Jack Steiner (steiner@sgi.com)          651-683-5302
Principal Engineer                      SGI - Silicon Graphics, Inc.

Re: [PATCH] - Increase max number of nodes (cpu_to_node_map)

[Matthew Wilcox]

On Wed, Nov 05, 2003 at 01:44:17PM -0600, Jack Steiner wrote:
> I hit a problem with systems having > 256 nodes. The
> cpu_to_node_map array is an array of char - needs to be 
> bigger.
> 
> Here is a patch that changes it to a short.

shouldn't that be an unsigned short so we don't run into problems
when adding the 32769th processor?

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Re: [PATCH] - Increase max number of nodes (cpu_to_node_map)

[Jack Steiner]

On Thu, Nov 06, 2003 at 05:06:04PM +0000, Matthew Wilcox wrote:
> On Wed, Nov 05, 2003 at 01:44:17PM -0600, Jack Steiner wrote:
> > I hit a problem with systems having > 256 nodes. The
> > cpu_to_node_map array is an array of char - needs to be 
> > bigger.
> > 
> > Here is a patch that changes it to a short.
> 
> shouldn't that be an unsigned short so we don't run into problems
> when adding the 32769th processor?


Either signed or unsigned works for me. 

I didnt initially make it unsigned because a number of structures use 
negative values to indicate non-existant cpus or nodes. However, that 
doesnt currently apply in this case.


-- 
Thanks

Jack Steiner (steiner@sgi.com)          651-683-5302
Principal Engineer                      SGI - Silicon Graphics, Inc.