PATCH: Put the new API functions in the header files

PATCH: Put the new API functions in the header files

[Alan Cox]

diff --exclude-from /usr/src/exclude -u --new-file --recursive linux.vanilla-2.6.10rc1/include/linux/ide.h linux-2.6.10rc1/include/linux/ide.h
--- linux.vanilla-2.6.10rc1/include/linux/ide.h	2004-11-05 15:42:18.000000000 +0000
+++ linux-2.6.10rc1/include/linux/ide.h	2004-11-05 16:26:18.000000000 +0000
@@ -266,6 +266,7 @@
  * Register new hardware with ide
  */
 int ide_register_hw(hw_regs_t *hw, struct hwif_s **hwifp);
+int ide_register_hw_with_fixup(hw_regs_t *hw, struct hwif_s **hwifp, void (*fixup)(struct hwif_s *));
 
 /*
  * Set up hw_regs_t structure before calling ide_register_hw (optional)
@@ -1470,6 +1475,7 @@
 	void			(*init_iops)(ide_hwif_t *);
 	void                    (*init_hwif)(ide_hwif_t *);
 	void			(*init_dma)(ide_hwif_t *, unsigned long);
+	void			(*fixup)(ide_hwif_t *);
 	u8			channels;
 	u8			autodma;
 	ide_pci_enablebit_t	enablebits[2];
@@ -1529,6 +1535,8 @@
 extern void ide_unregister (unsigned int index);
 
 extern int probe_hwif_init(ide_hwif_t *);
+extern int probe_hwif_init_with_fixup(ide_hwif_t *hwif, void (*fixup)(ide_hwif_t *hwif));
+extern void ide_undecoded_slave(ide_hwif_t *hwif);
 
 static inline void *ide_get_hwifdata (ide_hwif_t * hwif)
 {

Re: PATCH: Put the new API functions in the header files

[Bartlomiej Zolnierkiewicz]

* there is no ordering of your patches
* they are splitted on file boundary not change boundary
  (ie. appling one patch leaves you with kernel which won't compile)
* they are whitespace damaged as usual

:/

On Friday 05 November 2004 17:32, Alan Cox wrote:
> diff --exclude-from /usr/src/exclude -u --new-file --recursive linux.vanilla-2.6.10rc1/include/linux/ide.h linux-2.6.10rc1/include/linux/ide.h
> --- linux.vanilla-2.6.10rc1/include/linux/ide.h	2004-11-05 15:42:18.000000000 +0000
> +++ linux-2.6.10rc1/include/linux/ide.h	2004-11-05 16:26:18.000000000 +0000
> @@ -266,6 +266,7 @@
>   * Register new hardware with ide
>   */
>  int ide_register_hw(hw_regs_t *hw, struct hwif_s **hwifp);
> +int ide_register_hw_with_fixup(hw_regs_t *hw, struct hwif_s **hwifp, void (*fixup)(struct hwif_s *));
>  
>  /*
>   * Set up hw_regs_t structure before calling ide_register_hw (optional)
> @@ -1470,6 +1475,7 @@
>  	void			(*init_iops)(ide_hwif_t *);
>  	void                    (*init_hwif)(ide_hwif_t *);
>  	void			(*init_dma)(ide_hwif_t *, unsigned long);
> +	void			(*fixup)(ide_hwif_t *);
>  	u8			channels;
>  	u8			autodma;
>  	ide_pci_enablebit_t	enablebits[2];
> @@ -1529,6 +1535,8 @@
>  extern void ide_unregister (unsigned int index);
>  
>  extern int probe_hwif_init(ide_hwif_t *);
> +extern int probe_hwif_init_with_fixup(ide_hwif_t *hwif, void (*fixup)(ide_hwif_t *hwif));
> +extern void ide_undecoded_slave(ide_hwif_t *hwif);
>  
>  static inline void *ide_get_hwifdata (ide_hwif_t * hwif)
>  {
> 
> 

Re: PATCH: Put the new API functions in the header files

[Alan Cox]

On Gwe, 2004-11-05 at 22:02, Bartlomiej Zolnierkiewicz wrote:
> * there is no ordering of your patches
> * they are splitted on file boundary not change boundary
>   (ie. appling one patch leaves you with kernel which won't compile)

Well I could send you bigger pieces if you want but you objected to that
last time.

> * they are whitespace damaged as usual

Well if you want to be a bigot about the old trailing space caused by
editor auto indenting feel free 8)

Re: PATCH: Put the new API functions in the header files

[Bartlomiej Zolnierkiewicz]

On Saturday 06 November 2004 00:36, Alan Cox wrote:
> On Gwe, 2004-11-05 at 22:02, Bartlomiej Zolnierkiewicz wrote:
> > * there is no ordering of your patches
> > * they are splitted on file boundary not change boundary
> >   (ie. appling one patch leaves you with kernel which won't compile)
> 
> Well I could send you bigger pieces if you want but you objected to that
> last time.

all or nothing...

> > * they are whitespace damaged as usual
> 
> Well if you want to be a bigot about the old trailing space caused by
> editor auto indenting feel free 8)

sigh