* [PATCH] scsi: ata: make ahci_sdev_attrs static
@ 2021-10-19 10:24 Jiapeng Chong
2021-10-19 22:44 ` Damien Le Moal
2021-10-21 1:37 ` Damien Le Moal
0 siblings, 2 replies; 6+ messages in thread
From: Jiapeng Chong @ 2021-10-19 10:24 UTC (permalink / raw)
To: damien.lemoal; +Cc: linux-ide, linux-kernel, chongjiapeng
From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
This symbol is not used outside of libahci.c, so marks it static.
Fix the following sparse warning:
drivers/ata/libahci.c:134:18: warning: symbol 'ahci_sdev_attrs' was not
declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
---
drivers/ata/libahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 28430c093a7f..8a6835bfd18a 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = {
};
EXPORT_SYMBOL_GPL(ahci_shost_groups);
-struct attribute *ahci_sdev_attrs[] = {
+static struct attribute *ahci_sdev_attrs[] = {
&dev_attr_sw_activity.attr,
&dev_attr_unload_heads.attr,
&dev_attr_ncq_prio_supported.attr,
--
2.19.1.6.gb485710b
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: ata: make ahci_sdev_attrs static
2021-10-19 10:24 [PATCH] scsi: ata: make ahci_sdev_attrs static Jiapeng Chong
@ 2021-10-19 22:44 ` Damien Le Moal
2021-10-20 3:27 ` Bart Van Assche
2021-10-21 1:37 ` Damien Le Moal
1 sibling, 1 reply; 6+ messages in thread
From: Damien Le Moal @ 2021-10-19 22:44 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-ide, Bart Van Assche
+Bart
On 2021/10/19 19:24, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
The patch title should be:
ata: libahci: make ahci_sdev_attrs static
>
> This symbol is not used outside of libahci.c, so marks it static.
>
> Fix the following sparse warning:
>
> drivers/ata/libahci.c:134:18: warning: symbol 'ahci_sdev_attrs' was not
> declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/ata/libahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index 28430c093a7f..8a6835bfd18a 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = {
> };
> EXPORT_SYMBOL_GPL(ahci_shost_groups);
>
> -struct attribute *ahci_sdev_attrs[] = {
> +static struct attribute *ahci_sdev_attrs[] = {
> &dev_attr_sw_activity.attr,
> &dev_attr_unload_heads.attr,
> &dev_attr_ncq_prio_supported.attr,
>
Looks OK to me.
Bart ?
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: ata: make ahci_sdev_attrs static
2021-10-19 22:44 ` Damien Le Moal
@ 2021-10-20 3:27 ` Bart Van Assche
2021-10-20 5:42 ` Damien Le Moal
0 siblings, 1 reply; 6+ messages in thread
From: Bart Van Assche @ 2021-10-20 3:27 UTC (permalink / raw)
To: Damien Le Moal, Jiapeng Chong; +Cc: linux-ide
On 10/19/21 15:44, Damien Le Moal wrote:
> +Bart
>
> On 2021/10/19 19:24, Jiapeng Chong wrote:
>> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> The patch title should be:
>
> ata: libahci: make ahci_sdev_attrs static
>
>>
>> This symbol is not used outside of libahci.c, so marks it static.
>>
>> Fix the following sparse warning:
>>
>> drivers/ata/libahci.c:134:18: warning: symbol 'ahci_sdev_attrs' was not
>> declared. Should it be static?
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
>> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>> ---
>> drivers/ata/libahci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
>> index 28430c093a7f..8a6835bfd18a 100644
>> --- a/drivers/ata/libahci.c
>> +++ b/drivers/ata/libahci.c
>> @@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = {
>> };
>> EXPORT_SYMBOL_GPL(ahci_shost_groups);
>>
>> -struct attribute *ahci_sdev_attrs[] = {
>> +static struct attribute *ahci_sdev_attrs[] = {
>> &dev_attr_sw_activity.attr,
>> &dev_attr_unload_heads.attr,
>> &dev_attr_ncq_prio_supported.attr,
>>
>
> Looks OK to me.
The above patch looks fine to me too.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: ata: make ahci_sdev_attrs static
2021-10-20 3:27 ` Bart Van Assche
@ 2021-10-20 5:42 ` Damien Le Moal
2021-10-20 17:03 ` Bart Van Assche
0 siblings, 1 reply; 6+ messages in thread
From: Damien Le Moal @ 2021-10-20 5:42 UTC (permalink / raw)
To: Bart Van Assche, Jiapeng Chong; +Cc: linux-ide
On 2021/10/20 12:27, Bart Van Assche wrote:
> On 10/19/21 15:44, Damien Le Moal wrote:
>> +Bart
>>
>> On 2021/10/19 19:24, Jiapeng Chong wrote:
>>> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>>
>> The patch title should be:
>>
>> ata: libahci: make ahci_sdev_attrs static
>>
>>>
>>> This symbol is not used outside of libahci.c, so marks it static.
>>>
>>> Fix the following sparse warning:
>>>
>>> drivers/ata/libahci.c:134:18: warning: symbol 'ahci_sdev_attrs' was not
>>> declared. Should it be static?
>>>
>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>>> Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
>>> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>>> ---
>>> drivers/ata/libahci.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
>>> index 28430c093a7f..8a6835bfd18a 100644
>>> --- a/drivers/ata/libahci.c
>>> +++ b/drivers/ata/libahci.c
>>> @@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = {
>>> };
>>> EXPORT_SYMBOL_GPL(ahci_shost_groups);
>>>
>>> -struct attribute *ahci_sdev_attrs[] = {
>>> +static struct attribute *ahci_sdev_attrs[] = {
>>> &dev_attr_sw_activity.attr,
>>> &dev_attr_unload_heads.attr,
>>> &dev_attr_ncq_prio_supported.attr,
>>>
>>
>> Looks OK to me.
>
> The above patch looks fine to me too.
Can I add your reviewed-by tag ?
>
> Thanks,
>
> Bart.
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ata: make ahci_sdev_attrs static
2021-10-19 10:24 [PATCH] scsi: ata: make ahci_sdev_attrs static Jiapeng Chong
2021-10-19 22:44 ` Damien Le Moal
@ 2021-10-21 1:37 ` Damien Le Moal
1 sibling, 0 replies; 6+ messages in thread
From: Damien Le Moal @ 2021-10-21 1:37 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-ide, linux-scsi, Martin K . Petersen
On 10/19/21 19:24, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> This symbol is not used outside of libahci.c, so marks it static.
>
> Fix the following sparse warning:
>
> drivers/ata/libahci.c:134:18: warning: symbol 'ahci_sdev_attrs' was not
> declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/ata/libahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index 28430c093a7f..8a6835bfd18a 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = {
> };
> EXPORT_SYMBOL_GPL(ahci_shost_groups);
>
> -struct attribute *ahci_sdev_attrs[] = {
> +static struct attribute *ahci_sdev_attrs[] = {
> &dev_attr_sw_activity.attr,
> &dev_attr_unload_heads.attr,
> &dev_attr_ncq_prio_supported.attr,
>
Jiapeng,
This patch does not apply to the current libata tree since it is against
the latest changes queued in the scsi tree. After fixing the patch
title, can you resend this patch to the linux-scsi list and to Martin ?
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-21 1:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-19 10:24 [PATCH] scsi: ata: make ahci_sdev_attrs static Jiapeng Chong
2021-10-19 22:44 ` Damien Le Moal
2021-10-20 3:27 ` Bart Van Assche
2021-10-20 5:42 ` Damien Le Moal
2021-10-20 17:03 ` Bart Van Assche
2021-10-21 1:37 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox