Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: tj@kernel.org, JBottomley@Parallels.com
Cc: Len Brown <len.brown@intel.com>,
	linux-scsi@vger.kernel.org, Phillip Susi <psusi@ubuntu.com>,
	linux-ide@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
	Todd Brandt <todd.e.brandt@linux.intel.com>,
	Todd Brandt <todd.e.brandt@intel.com>
Subject: [PATCH v5 0/3] Accelerate Storage Resume (2x or more)
Date: Wed, 05 Mar 2014 12:17:24 -0800	[thread overview]
Message-ID: <20140305201443.20088.85361.stgit@viggo.jf.intel.com> (raw)

It is not everyday that a kernel operation gets 2x faster.  Nice find
by Todd and his AnalyzeSuspend tool [1].

Todd is on vacation so I am taking care of these patches to make sure
they get in the queue for 3.15.

The significant changes from Todd's last submission [2]:

1/ Split out the pure cleanup into its own patch, and expand it to clean
   up libsas as well

2/ Move the entirety of scsi_device resume to an async context.  As
   written, v4 of the patchset overlapped the scsi-start-stop command
   with the scsi_device_resume().  Now in v5 the queue restart is
   properly ordered with the completion of the scsi-start-stop command.

Resume completion time as reported by:

"echo devices > /sys/power/pm_test && echo mem > /sys/power/state"

BEFORE: PM: resume of devices complete after 2271.097 msecs
AFTER:  PM: resume of devices complete after 1057.404 msecs

On a system with two SSDs attached via AHCI.

--
Dan


[1]: Todd's testing showing up to 12x resume latency improvement in some
cases:
https://01.org/suspendresume/blogs/tebrandt/2013/hard-disk-resume-optimization-simpler-approach

[2]: Todd's v4 patchset:
[PATCH v4 0/2] http://marc.info/?l=linux-ide&m=138984698103487&w=2
[PATCH v4 1/2] http://marc.info/?l=linux-ide&m=138984713203515&w=2
[PATCH v4 2/2] http://marc.info/?l=linux-ide&m=138984722003539&w=2

---

Dan Williams (2):
      libata, libsas: kill pm_result and related cleanup
      scsi: async sd resume

Todd Brandt (1):
      libata: async resume


 drivers/ata/libata-core.c     |   75 ++++++++++-----------------
 drivers/ata/libata-eh.c       |   13 +----
 drivers/scsi/libsas/sas_ata.c |   35 ++----------
 drivers/scsi/scsi.c           |    3 +
 drivers/scsi/scsi_pm.c        |  115 ++++++++++++++++++++++++++++++++---------
 drivers/scsi/scsi_priv.h      |    1 
 drivers/scsi/sd.c             |    1 
 include/linux/libata.h        |    9 +--
 include/scsi/libsas.h         |    1 
 9 files changed, 134 insertions(+), 119 deletions(-)

             reply	other threads:[~2014-03-05 20:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 20:17 Dan Williams [this message]
2014-03-05 20:17 ` [PATCH v5 1/3] libata, libsas: kill pm_result and related cleanup Dan Williams
2014-03-10 20:29   ` Tejun Heo
2014-03-10 20:44     ` Tejun Heo
2014-03-05 20:17 ` [PATCH v5 2/3] libata: async resume Dan Williams
2014-12-19 23:46   ` Phillip Susi
2014-12-20  1:42     ` Phillip Susi
2014-03-05 20:17 ` [PATCH v5 3/3] scsi: async sd resume Dan Williams
2014-03-07 15:42   ` Alan Stern
2014-03-08  0:41     ` Dan Williams
2014-03-08  2:52     ` Dan Williams
2014-03-10 15:49       ` Alan Stern
2014-03-10 20:43       ` Tejun Heo
2014-03-10 20:56         ` Dan Williams
2014-03-10 20:59           ` Alan Stern
2014-03-10 21:06             ` Dan Williams
2014-03-10 22:41             ` Phillip Susi
2014-03-11  4:19             ` James Bottomley
2014-03-11  4:47               ` Dan Williams
2014-03-11  5:16                 ` James Bottomley
2014-03-11  5:26                   ` Dan Williams
2014-03-11  6:29                     ` James Bottomley
2014-03-14 20:11                       ` Dan Williams
2014-03-15 21:47                         ` James Bottomley
2014-03-15 23:35                           ` Dan Williams
2014-03-16 18:21                             ` James Bottomley
2014-03-17 18:20                               ` Dan Williams
2014-03-21  0:09                                 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305201443.20088.85361.stgit@viggo.jf.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=JBottomley@Parallels.com \
    --cc=len.brown@intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=psusi@ubuntu.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    --cc=todd.e.brandt@intel.com \
    --cc=todd.e.brandt@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox