From: Dan Williams <dan.j.williams@intel.com>
To: tj@kernel.org, JBottomley@Parallels.com
Cc: Len Brown <len.brown@intel.com>,
linux-scsi@vger.kernel.org, Phillip Susi <psusi@ubuntu.com>,
linux-ide@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
Todd Brandt <todd.e.brandt@linux.intel.com>
Subject: [PATCH v5 2/3] libata: async resume
Date: Wed, 05 Mar 2014 12:17:35 -0800 [thread overview]
Message-ID: <20140305201735.20088.22124.stgit@viggo.jf.intel.com> (raw)
In-Reply-To: <20140305201443.20088.85361.stgit@viggo.jf.intel.com>
From: Todd Brandt <todd.e.brandt@linux.intel.com>
Improve overall system resume time by making libata link recovery
actions asynchronous relative to other resume events.
Link resume operations are performed using the scsi_eh thread, so
commands, particularly the sd resume start/stop command, will be held
off until the device exits error handling. Libata already flushes eh
with ata_port_wait_eh() in the port teardown paths, so there are no
concerns with async operation colliding with the end-of-life of the
ata_port object. Also, libata-core is already careful to flush
in-flight pm operations before another round of pm starts on the given
ata_port.
Reference: https://01.org/suspendresume/blogs/tebrandt/2013/hard-disk-resume-optimization-simpler-approach
Cc: Len Brown <len.brown@intel.com>
Cc: Phillip Susi <psusi@ubuntu.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Todd Brandt <todd.e.brandt@linux.intel.com>
[djbw: rebase on cleanup patch, changelog wordsmithing]
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/ata/libata-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 0f47436c714c..7719ec7d9df9 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5444,7 +5444,7 @@ static int ata_port_resume(struct device *dev)
{
int rc;
- rc = ata_port_resume_sync(to_ata_port(dev), PMSG_RESUME);
+ rc = queue_ata_port_resume(to_ata_port(dev), PMSG_RESUME);
if (!rc) {
pm_runtime_disable(dev);
pm_runtime_set_active(dev);
next prev parent reply other threads:[~2014-03-05 20:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 20:17 [PATCH v5 0/3] Accelerate Storage Resume (2x or more) Dan Williams
2014-03-05 20:17 ` [PATCH v5 1/3] libata, libsas: kill pm_result and related cleanup Dan Williams
2014-03-10 20:29 ` Tejun Heo
2014-03-10 20:44 ` Tejun Heo
2014-03-05 20:17 ` Dan Williams [this message]
2014-12-19 23:46 ` [PATCH v5 2/3] libata: async resume Phillip Susi
2014-12-20 1:42 ` Phillip Susi
2014-03-05 20:17 ` [PATCH v5 3/3] scsi: async sd resume Dan Williams
2014-03-07 15:42 ` Alan Stern
2014-03-08 0:41 ` Dan Williams
2014-03-08 2:52 ` Dan Williams
2014-03-10 15:49 ` Alan Stern
2014-03-10 20:43 ` Tejun Heo
2014-03-10 20:56 ` Dan Williams
2014-03-10 20:59 ` Alan Stern
2014-03-10 21:06 ` Dan Williams
2014-03-10 22:41 ` Phillip Susi
2014-03-11 4:19 ` James Bottomley
2014-03-11 4:47 ` Dan Williams
2014-03-11 5:16 ` James Bottomley
2014-03-11 5:26 ` Dan Williams
2014-03-11 6:29 ` James Bottomley
2014-03-14 20:11 ` Dan Williams
2014-03-15 21:47 ` James Bottomley
2014-03-15 23:35 ` Dan Williams
2014-03-16 18:21 ` James Bottomley
2014-03-17 18:20 ` Dan Williams
2014-03-21 0:09 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305201735.20088.22124.stgit@viggo.jf.intel.com \
--to=dan.j.williams@intel.com \
--cc=JBottomley@Parallels.com \
--cc=len.brown@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=psusi@ubuntu.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
--cc=todd.e.brandt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox