* [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const
@ 2022-01-23 22:22 Colin Ian King
2022-01-24 17:15 ` Sergey Shtylyov
2022-01-27 23:36 ` Damien Le Moal
0 siblings, 2 replies; 5+ messages in thread
From: Colin Ian King @ 2022-01-23 22:22 UTC (permalink / raw)
To: Damien Le Moal, linux-ide; +Cc: kernel-janitors
The static array pio_timing is read-only so it make sense to make
it const.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/ata/pata_pdc202xx_old.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_pdc202xx_old.c b/drivers/ata/pata_pdc202xx_old.c
index b99849095853..f894ff2de0a9 100644
--- a/drivers/ata/pata_pdc202xx_old.c
+++ b/drivers/ata/pata_pdc202xx_old.c
@@ -78,7 +78,7 @@ static void pdc202xx_configure_piomode(struct ata_port *ap, struct ata_device *a
{
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
int port = 0x60 + 8 * ap->port_no + 4 * adev->devno;
- static u16 pio_timing[5] = {
+ static const u16 pio_timing[5] = {
0x0913, 0x050C , 0x0308, 0x0206, 0x0104
};
u8 r_ap, r_bp;
--
2.33.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const
2022-01-23 22:22 [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const Colin Ian King
@ 2022-01-24 17:15 ` Sergey Shtylyov
2022-01-24 21:37 ` Damien Le Moal
2022-01-27 23:36 ` Damien Le Moal
1 sibling, 1 reply; 5+ messages in thread
From: Sergey Shtylyov @ 2022-01-24 17:15 UTC (permalink / raw)
To: Colin Ian King, Damien Le Moal, linux-ide; +Cc: kernel-janitors
Hello!
Too many verbs in the subject. :-)
On 1/24/22 1:22 AM, Colin Ian King wrote:
> The static array pio_timing is read-only so it make sense to make
> it const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
With that fixed:
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const
2022-01-24 17:15 ` Sergey Shtylyov
@ 2022-01-24 21:37 ` Damien Le Moal
2022-01-24 23:02 ` Colin King (gmail)
0 siblings, 1 reply; 5+ messages in thread
From: Damien Le Moal @ 2022-01-24 21:37 UTC (permalink / raw)
To: Sergey Shtylyov, Colin Ian King, linux-ide; +Cc: kernel-janitors
On 2022/01/25 2:15, Sergey Shtylyov wrote:
> Hello!
>
> Too many verbs in the subject. :-)
Yep. I will fix that when applying. No need to resend !
>
> On 1/24/22 1:22 AM, Colin Ian King wrote:
>
>> The static array pio_timing is read-only so it make sense to make
>> it const.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> With that fixed:
>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Thanks for the review.
>
> [...]
>
> MBR, Sergey
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const
2022-01-24 21:37 ` Damien Le Moal
@ 2022-01-24 23:02 ` Colin King (gmail)
0 siblings, 0 replies; 5+ messages in thread
From: Colin King (gmail) @ 2022-01-24 23:02 UTC (permalink / raw)
To: Damien Le Moal, Sergey Shtylyov, linux-ide; +Cc: kernel-janitors
On 24/01/2022 21:37, Damien Le Moal wrote:
> On 2022/01/25 2:15, Sergey Shtylyov wrote:
>> Hello!
>>
>> Too many verbs in the subject. :-)
>
> Yep. I will fix that when applying. No need to resend !
Thanks for fixing this up. Much appreciated.
>
>>
>> On 1/24/22 1:22 AM, Colin Ian King wrote:
>>
>>> The static array pio_timing is read-only so it make sense to make
>>> it const.
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>
>> With that fixed:
>>
>> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> Thanks for the review.
>
>>
>> [...]
>>
>> MBR, Sergey
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const
2022-01-23 22:22 [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const Colin Ian King
2022-01-24 17:15 ` Sergey Shtylyov
@ 2022-01-27 23:36 ` Damien Le Moal
1 sibling, 0 replies; 5+ messages in thread
From: Damien Le Moal @ 2022-01-27 23:36 UTC (permalink / raw)
To: Colin Ian King, linux-ide; +Cc: kernel-janitors
On 1/24/22 07:22, Colin Ian King wrote:
> The static array pio_timing is read-only so it make sense to make
> it const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied to for-5.18. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-27 23:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-23 22:22 [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const Colin Ian King
2022-01-24 17:15 ` Sergey Shtylyov
2022-01-24 21:37 ` Damien Le Moal
2022-01-24 23:02 ` Colin King (gmail)
2022-01-27 23:36 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox