* [PATCH V4] ata: libata-core: Print timeout value when internal command times
@ 2022-08-10 17:59 Tomas Henzl
2022-08-17 16:43 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Tomas Henzl @ 2022-08-10 17:59 UTC (permalink / raw)
To: linux-ide; +Cc: sergei.shtylyov, damien.lemoal
Printing the timeout value may help in troubleshooting failures.
Signed-off-by: David Milburn <dmilburn@redhat.com>
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
V4: a whitespace change
a switch from an an infinitive to an -ing form in the body
a fix to the title prefix
V3: rewording subject and description, no functional change
V2: timeout changed to unsigned int as in for-next
---
drivers/ata/libata-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 826d41f341e4..9478194740e0 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1578,8 +1578,8 @@ static unsigned ata_exec_internal_sg(struct ata_device *dev,
else
ata_qc_complete(qc);
- ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n",
- command);
+ ata_dev_warn(dev, "qc timeout after %u msecs (cmd 0x%x)\n",
+ timeout, command);
}
spin_unlock_irqrestore(ap->lock, flags);
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V4] ata: libata-core: Print timeout value when internal command times
2022-08-10 17:59 [PATCH V4] ata: libata-core: Print timeout value when internal command times Tomas Henzl
@ 2022-08-17 16:43 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2022-08-17 16:43 UTC (permalink / raw)
To: Tomas Henzl, linux-ide; +Cc: sergei.shtylyov
On 2022/08/10 10:59, Tomas Henzl wrote:
> Printing the timeout value may help in troubleshooting failures.
>
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
> V4: a whitespace change
> a switch from an an infinitive to an -ing form in the body
> a fix to the title prefix
> V3: rewording subject and description, no functional change
> V2: timeout changed to unsigned int as in for-next
> ---
> drivers/ata/libata-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 826d41f341e4..9478194740e0 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -1578,8 +1578,8 @@ static unsigned ata_exec_internal_sg(struct ata_device *dev,
> else
> ata_qc_complete(qc);
>
> - ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n",
> - command);
> + ata_dev_warn(dev, "qc timeout after %u msecs (cmd 0x%x)\n",
> + timeout, command);
> }
>
> spin_unlock_irqrestore(ap->lock, flags);
Applied to for-6.1. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-17 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-10 17:59 [PATCH V4] ata: libata-core: Print timeout value when internal command times Tomas Henzl
2022-08-17 16:43 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox