[PATCH -next 0/3] ata: Enable module autoloading

[PATCH -next 0/3] ata: Enable module autoloading

[Liao Chen]

Hi all,

This patchset aims to enable autoloading of some use modules. By 
registering MDT, the kernel is allowed to automatically bind modules to
devices that match the specified compatible strings.

Liao Chen (3):
  ata: pata_ftide010: Enable module autoloading
  ata: pata_ixp4xx: Enable module autoloading
  ata: sata_gemini: Enable module autoloading

 drivers/ata/pata_ftide010.c  | 1 +
 drivers/ata/pata_ixp4xx_cf.c | 1 +
 drivers/ata/sata_gemini.c    | 1 +
 3 files changed, 3 insertions(+)

-- 
2.34.1

[PATCH -next 1/3] ata: pata_ftide010: Enable module autoloading

[Liao Chen]

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/ata/pata_ftide010.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c
index 4d6ef90ccc77..73a9a5109238 100644
--- a/drivers/ata/pata_ftide010.c
+++ b/drivers/ata/pata_ftide010.c
@@ -549,6 +549,7 @@ static const struct of_device_id pata_ftide010_of_match[] = {
 	{ .compatible = "faraday,ftide010", },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, pata_ftide010_of_match);
 
 static struct platform_driver pata_ftide010_driver = {
 	.driver = {
-- 
2.34.1

Re: [PATCH -next 1/3] ata: pata_ftide010: Enable module autoloading

[Sergey Shtylyov]

On 8/29/24 4:19 PM, Liao Chen wrote:

> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey

Re: [PATCH -next 1/3] ata: pata_ftide010: Enable module autoloading

[Damien Le Moal]

On 8/29/24 10:19 PM, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based

s/could/can

Same comment for the other 2 patches. Other than that, looks good.
Feel free to add Sergey's review tag when sending v2. Thanks.

> on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>  drivers/ata/pata_ftide010.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c
> index 4d6ef90ccc77..73a9a5109238 100644
> --- a/drivers/ata/pata_ftide010.c
> +++ b/drivers/ata/pata_ftide010.c
> @@ -549,6 +549,7 @@ static const struct of_device_id pata_ftide010_of_match[] = {
>  	{ .compatible = "faraday,ftide010", },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, pata_ftide010_of_match);
>  
>  static struct platform_driver pata_ftide010_driver = {
>  	.driver = {

-- 
Damien Le Moal
Western Digital Research

[PATCH -next 2/3] ata: pata_ixp4xx: Enable module autoloading

[Liao Chen]

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/ata/pata_ixp4xx_cf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index 246bb4f8f1f7..8a9ee828478f 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_cf.c
@@ -290,6 +290,7 @@ static const struct of_device_id ixp4xx_pata_of_match[] = {
 	{ .compatible = "intel,ixp4xx-compact-flash", },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, ixp4xx_pata_of_match);
 
 static struct platform_driver ixp4xx_pata_platform_driver = {
 	.driver	 = {
-- 
2.34.1

Re: [PATCH -next 2/3] ata: pata_ixp4xx: Enable module autoloading

[Sergey Shtylyov]

On 8/29/24 4:19 PM, Liao Chen wrote:

> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey

[PATCH -next 3/3] ata: sata_gemini: Enable module autoloading

[Liao Chen]

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/ata/sata_gemini.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
index 4c270999ba3c..f574e3c3f5b4 100644
--- a/drivers/ata/sata_gemini.c
+++ b/drivers/ata/sata_gemini.c
@@ -417,6 +417,7 @@ static const struct of_device_id gemini_sata_of_match[] = {
 	{ .compatible = "cortina,gemini-sata-bridge", },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, gemini_sata_of_match);
 
 static struct platform_driver gemini_sata_driver = {
 	.driver = {
-- 
2.34.1

Re: [PATCH -next 3/3] ata: sata_gemini: Enable module autoloading

[Linus Walleij]

On Thu, Aug 29, 2024 at 3:27 PM Liao Chen <liaochen4@huawei.com> wrote:

> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> on the alias from of_device_id table.
>
> Signed-off-by: Liao Chen <liaochen4@huawei.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij