[PATCH v2] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk

[PATCH v2] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk

[Niklas Cassel]

ASUS store the board name in DMI_PRODUCT_NAME rather than
DMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the
model-name in DMI_PRODUCT_VERSION.)

Use the correct DMI identifier, DMI_PRODUCT_NAME, to match the
ASUSPRO-D840SA board, such that the quirk actually gets applied.

Cc: stable@vger.kernel.org
Reported-by: Andy Yang <andyybtc79@gmail.com>
Closes: https://lore.kernel.org/linux-ide/aFb3wXAwJSSJUB7o@ryzen/
Fixes: b5acc3628898 ("ata: ahci: Disallow LPM for ASUSPRO-D840SA motherboard")
Reviewed-by: Hans de Goede <hansg@kernel.org>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
Changes since v1:
-Improved commit log
-Picked up tag from Hans

 drivers/ata/ahci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index e5e5c2e81d09..aa93b0ecbbc6 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1450,7 +1450,7 @@ static bool ahci_broken_lpm(struct pci_dev *pdev)
 		{
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-				DMI_MATCH(DMI_PRODUCT_VERSION, "ASUSPRO D840MB_M840SA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "ASUSPRO D840MB_M840SA"),
 			},
 			/* 320 is broken, there is no known good version. */
 		},
-- 
2.49.0

Re: [PATCH v2] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk

[Damien Le Moal]

On 6/24/25 4:40 PM, Niklas Cassel wrote:
> ASUS store the board name in DMI_PRODUCT_NAME rather than
> DMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the
> model-name in DMI_PRODUCT_VERSION.)
> 
> Use the correct DMI identifier, DMI_PRODUCT_NAME, to match the
> ASUSPRO-D840SA board, such that the quirk actually gets applied.
> 
> Cc: stable@vger.kernel.org
> Reported-by: Andy Yang <andyybtc79@gmail.com>
> Closes: https://lore.kernel.org/linux-ide/aFb3wXAwJSSJUB7o@ryzen/
> Fixes: b5acc3628898 ("ata: ahci: Disallow LPM for ASUSPRO-D840SA motherboard")
> Reviewed-by: Hans de Goede <hansg@kernel.org>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH v2] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk

[Niklas Cassel]

On Wed, Jun 25, 2025 at 06:29:58AM +0000, Andy Yang wrote:
> On Tuesday, June 24, 2025, Damien Le Moal <dlemoal@kernel.org> wrote:
> > On 6/24/25 4:40 PM, Niklas Cassel wrote:
> >> ASUS store the board name in DMI_PRODUCT_NAME rather than
> >> DMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the
> >> model-name in DMI_PRODUCT_VERSION.)
> >>
> >> Use the correct DMI identifier, DMI_PRODUCT_NAME, to match the
> >> ASUSPRO-D840SA board, such that the quirk actually gets applied.
> >>
> >> Cc: stable@vger.kernel.org
> >> Reported-by: Andy Yang <andyybtc79@gmail.com>
> >> Closes: https://lore.kernel.org/linux-ide/aFb3wXAwJSSJUB7o@ryzen/
> >> Fixes: b5acc3628898 ("ata: ahci: Disallow LPM for ASUSPRO-D840SA
> motherboard")
> >> Reviewed-by: Hans de Goede <hansg@kernel.org>
> >> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> >
> > Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> >
> >
> > --
> > Damien Le Moal
> > Western Digital Research
> >
> 
> LGTM. This patch is tested work correctly.

Thank you, I will add your Tested-by tag.


> 
> Again, not sure if its model specific or motherboard specific, if its
> consider motherboard specific we should use (DMI_BOARD_NAME, D840MB)
> instead to match the board.

I don't know if it is model specific or motherboard specific.

Considering how bad this bug is (causing artifacts on the iGPU),
I guess we should hope that it is only the BIOS for your system,
and not for all D840MB boards.

So personally, I would go with the narrowest possible match (which
this patch currently does).

But, I would not be surprised if they actually managed to mess this
up for all boards. But until someone else reports the same problem,
I guess we should give them the benefit of the doubt.


Kind regards,
Niklas

Re: [PATCH v2] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk

[Niklas Cassel]

On Tue, 24 Jun 2025 09:40:30 +0200, Niklas Cassel wrote:
> ASUS store the board name in DMI_PRODUCT_NAME rather than
> DMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the
> model-name in DMI_PRODUCT_VERSION.)
> 
> Use the correct DMI identifier, DMI_PRODUCT_NAME, to match the
> ASUSPRO-D840SA board, such that the quirk actually gets applied.
> 
> [...]

Applied to libata/linux.git (for-6.16-fixes), thanks!

[1/1] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk
      https://git.kernel.org/libata/linux/c/3e0809b1

Kind regards,
Niklas

Re: [PATCH v2] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk

[Niklas Cassel]

Hello Andy,

On Thu, Jun 26, 2025 at 12:39:26AM +0000, Andy Yang wrote:
> Thank you once again for your efforts on this patch. I also want to
> sincerely apologize for any inconvenience caused by the email reply
> incident.

Don't even think about it :)

We might have been able to avoid this extra fix,
but that's it. No biggie regardless.

Thank you for your help debugging this.


Kind regards,
Niklas