Linux ATA/IDE development
 help / color / mirror / Atom feed
* [PATCH v2] ATA: ahci: Add Intel PCH-S RAID device ID
@ 2026-10-29 14:00 Roman Gardzinski
  2026-10-29 14:26 ` Niklas Cassel
  0 siblings, 1 reply; 2+ messages in thread
From: Roman Gardzinski @ 2026-10-29 14:00 UTC (permalink / raw)
  To: dlemoal, cassel, szczepan.durawa, szymon.durawa,
	romanx.gardzinski
  Cc: linux-ide, linux-kernel

When the Intel Nova Lake SATA controller is configured in RAID mode (rather
than AHCI), the generic entry in ahci_pci_tbl which matches any device with
the PCI class code for AHCI, is not sufficient, since the SATA controller
in RAID mode uses a different PCI class code.

Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Niklas Cassel <cassel@kernel.org>

Suggested-by: Szczepan Durawa <szczepan.durawa@intel.com>
Reviewed-by: Szymon Durawa <szymon.durawa@linux.intel.com>
Signed-off-by: Roman Gardzinski <romanx.gardzinski@linux.intel.com>
---
v1 -> v2:
 - update RAID entry in ahci_pci_tbl to board_ahci from board_ahci_pcs_quirk
 - update commit description

 drivers/ata/ahci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 9b8c0935001c..cee67c64fbea 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -280,6 +280,10 @@ static const struct ata_port_info ahci_port_info[] = {
 static const struct pci_device_id ahci_pci_tbl[] = {
 	/* Intel */
 	{
+		/* Nova Lake PCH-S RAID */
+		PCI_VDEVICE(INTEL, 0x6e66),
+		.driver_data = board_ahci,
+	}, {
 		/* Comet Lake PCH-H RAID */
 		PCI_VDEVICE(INTEL, 0x06d6),
 		.driver_data = board_ahci_pcs_quirk,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ATA: ahci: Add Intel PCH-S RAID device ID
  2026-10-29 14:00 [PATCH v2] ATA: ahci: Add Intel PCH-S RAID device ID Roman Gardzinski
@ 2026-10-29 14:26 ` Niklas Cassel
  0 siblings, 0 replies; 2+ messages in thread
From: Niklas Cassel @ 2026-10-29 14:26 UTC (permalink / raw)
  To: Roman Gardzinski
  Cc: dlemoal, szczepan.durawa, szymon.durawa, linux-ide, linux-kernel

On Thu, Oct 29, 2026 at 03:00:03PM +0100, Roman Gardzinski wrote:
> When the Intel Nova Lake SATA controller is configured in RAID mode (rather
> than AHCI), the generic entry in ahci_pci_tbl which matches any device with
> the PCI class code for AHCI, is not sufficient, since the SATA controller
> in RAID mode uses a different PCI class code.
> 
> Cc: Damien Le Moal <dlemoal@kernel.org>
> Cc: Niklas Cassel <cassel@kernel.org>
> 
> Suggested-by: Szczepan Durawa <szczepan.durawa@intel.com>
> Reviewed-by: Szymon Durawa <szymon.durawa@linux.intel.com>
> Signed-off-by: Roman Gardzinski <romanx.gardzinski@linux.intel.com>
> ---
> v1 -> v2:
>  - update RAID entry in ahci_pci_tbl to board_ahci from board_ahci_pcs_quirk
>  - update commit description
> 
>  drivers/ata/ahci.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 9b8c0935001c..cee67c64fbea 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -280,6 +280,10 @@ static const struct ata_port_info ahci_port_info[] = {
>  static const struct pci_device_id ahci_pci_tbl[] = {
>  	/* Intel */
>  	{
> +		/* Nova Lake PCH-S RAID */
> +		PCI_VDEVICE(INTEL, 0x6e66),
> +		.driver_data = board_ahci,
> +	}, {
>  		/* Comet Lake PCH-H RAID */
>  		PCI_VDEVICE(INTEL, 0x06d6),
>  		.driver_data = board_ahci_pcs_quirk,
> -- 
> 2.53.0
> 

Looks good to me:
Reviewed-by: Niklas Cassel <cassel@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-29 14:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-29 14:00 [PATCH v2] ATA: ahci: Add Intel PCH-S RAID device ID Roman Gardzinski
2026-10-29 14:26 ` Niklas Cassel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox