* [PATCH] ata: octeon: Drop empty platform remove function
@ 2022-12-12 21:41 Uwe Kleine-König
2022-12-30 7:00 ` Niklas Cassel
2023-01-02 23:40 ` Damien Le Moal
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2022-12-12 21:41 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-ide, kernel
A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/ata/ahci_octeon.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c
index b9460b91288f..5021ab3ede49 100644
--- a/drivers/ata/ahci_octeon.c
+++ b/drivers/ata/ahci_octeon.c
@@ -73,11 +73,6 @@ static int ahci_octeon_probe(struct platform_device *pdev)
return 0;
}
-static int ahci_octeon_remove(struct platform_device *pdev)
-{
- return 0;
-}
-
static const struct of_device_id octeon_ahci_match[] = {
{ .compatible = "cavium,octeon-7130-sata-uctl", },
{ /* sentinel */ }
@@ -86,7 +81,6 @@ MODULE_DEVICE_TABLE(of, octeon_ahci_match);
static struct platform_driver ahci_octeon_driver = {
.probe = ahci_octeon_probe,
- .remove = ahci_octeon_remove,
.driver = {
.name = "octeon-ahci",
.of_match_table = octeon_ahci_match,
base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ata: octeon: Drop empty platform remove function
2022-12-12 21:41 [PATCH] ata: octeon: Drop empty platform remove function Uwe Kleine-König
@ 2022-12-30 7:00 ` Niklas Cassel
2023-01-02 23:40 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Cassel @ 2022-12-30 7:00 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Damien Le Moal, linux-ide@vger.kernel.org, kernel@pengutronix.de
On Mon, Dec 12, 2022 at 10:41:12PM +0100, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/ata/ahci_octeon.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c
> index b9460b91288f..5021ab3ede49 100644
> --- a/drivers/ata/ahci_octeon.c
> +++ b/drivers/ata/ahci_octeon.c
> @@ -73,11 +73,6 @@ static int ahci_octeon_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int ahci_octeon_remove(struct platform_device *pdev)
> -{
> - return 0;
> -}
> -
> static const struct of_device_id octeon_ahci_match[] = {
> { .compatible = "cavium,octeon-7130-sata-uctl", },
> { /* sentinel */ }
> @@ -86,7 +81,6 @@ MODULE_DEVICE_TABLE(of, octeon_ahci_match);
>
> static struct platform_driver ahci_octeon_driver = {
> .probe = ahci_octeon_probe,
> - .remove = ahci_octeon_remove,
> .driver = {
> .name = "octeon-ahci",
> .of_match_table = octeon_ahci_match,
>
> base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
> --
> 2.38.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ata: octeon: Drop empty platform remove function
2022-12-12 21:41 [PATCH] ata: octeon: Drop empty platform remove function Uwe Kleine-König
2022-12-30 7:00 ` Niklas Cassel
@ 2023-01-02 23:40 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2023-01-02 23:40 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-ide, kernel
On 12/13/22 06:41, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to for-6.3. Thanks !
> ---
> drivers/ata/ahci_octeon.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c
> index b9460b91288f..5021ab3ede49 100644
> --- a/drivers/ata/ahci_octeon.c
> +++ b/drivers/ata/ahci_octeon.c
> @@ -73,11 +73,6 @@ static int ahci_octeon_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int ahci_octeon_remove(struct platform_device *pdev)
> -{
> - return 0;
> -}
> -
> static const struct of_device_id octeon_ahci_match[] = {
> { .compatible = "cavium,octeon-7130-sata-uctl", },
> { /* sentinel */ }
> @@ -86,7 +81,6 @@ MODULE_DEVICE_TABLE(of, octeon_ahci_match);
>
> static struct platform_driver ahci_octeon_driver = {
> .probe = ahci_octeon_probe,
> - .remove = ahci_octeon_remove,
> .driver = {
> .name = "octeon-ahci",
> .of_match_table = octeon_ahci_match,
>
> base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-02 23:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-12 21:41 [PATCH] ata: octeon: Drop empty platform remove function Uwe Kleine-König
2022-12-30 7:00 ` Niklas Cassel
2023-01-02 23:40 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox