From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-ide@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH v7 1/7] block: add a sanity check for non-write flush/fua bios
Date: Thu, 5 Jan 2023 12:54:31 +0900 [thread overview]
Message-ID: <964fb51e-c37e-824f-25bd-ed46d9418a20@opensource.wdc.com> (raw)
In-Reply-To: <Y7WL1GXmpDSSYD3/@T590>
On 1/4/23 23:23, Ming Lei wrote:
> On Tue, Jan 03, 2023 at 02:19:18PM +0900, Damien Le Moal wrote:
>> From: Christoph Hellwig <hch@infradead.org>
>>
>> Check that the PREFUSH and FUA flags are only set on write bios,
>> given that the flush state machine expects that.
>
> flush state machine is only for request based driver, but FUA is
> used by bio drivers(dm, md, ...) too, just wondering if bio drivers
> are covered for this change? If yes, can you add words in the
> commit log?
I think they are since it already was the responsibility of
dm_submit_bio() and md_submit_bio() to handle PREFLUSH and FUA.
>
>
> Thanks,
> Ming
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-01-05 3:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 5:19 [PATCH v7 0/7] Improve libata support for FUA Damien Le Moal
2023-01-03 5:19 ` [PATCH v7 1/7] block: add a sanity check for non-write flush/fua bios Damien Le Moal
2023-01-03 8:05 ` Niklas Cassel
2023-01-03 12:46 ` Damien Le Moal
2023-01-03 13:02 ` Niklas Cassel
2023-01-04 14:23 ` Ming Lei
2023-01-05 3:54 ` Damien Le Moal [this message]
2023-01-03 5:19 ` [PATCH v7 2/7] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2023-01-03 5:19 ` [PATCH v7 3/7] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2023-01-03 5:19 ` [PATCH v7 4/7] ata: libata: cleanup fua support detection Damien Le Moal
2023-01-03 5:19 ` [PATCH v7 5/7] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2023-01-03 5:19 ` [PATCH v7 6/7] ata: libata: blacklist FUA support for known buggy drives Damien Le Moal
2023-01-03 5:19 ` [PATCH v7 7/7] ata: libata: Enable fua support by default Damien Le Moal
2023-01-04 16:49 ` [PATCH v7 0/7] Improve libata support for FUA Tejun Heo
2023-01-05 3:43 ` Damien Le Moal
2023-01-05 18:15 ` Tejun Heo
2023-01-06 6:51 ` Damien Le Moal
2023-01-06 18:03 ` Tejun Heo
2023-01-10 13:23 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964fb51e-c37e-824f-25bd-ed46d9418a20@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=ming.lei@redhat.com \
--cc=niklas.cassel@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox