Linux IIO development
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] iio: mxs-lradc: Remove useless check in read_raw
Date: Tue, 2 Jul 2013 19:58:06 +0200	[thread overview]
Message-ID: <201307021958.06343.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKr6MGYKKRZm7prGRQhPXpfuEimOmrgUucraCfF_7SPTEA@mail.gmail.com>

Dear Otavio Salvador,

> On Mon, Jul 1, 2013 at 9:08 PM, Marek Vasut <marex@denx.de> wrote:
> > The removed check in the read_raw implementation was always true,
> > therefore remove it.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Jonathan Cameron <jic23@kernel.org>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> 
> This fixes the driver for MX23 but why this code were add at first?

Obviously because I wrote the code incorrectly. I appologize for the trouble.

Jonathan, can we get this one into 3.10.1 maybe ?

Best regards,
Marek Vasut

  reply	other threads:[~2013-07-02 17:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02  0:08 [PATCH] iio: mxs-lradc: Remove useless check in read_raw Marek Vasut
2013-07-02  3:38 ` Otavio Salvador
2013-07-02 17:58   ` Marek Vasut [this message]
2013-07-02  9:19 ` Hector Palacios
2013-07-02 11:43 ` Alexandre Belloni
2013-07-02 11:53   ` Otavio Salvador
2013-07-02 12:03   ` Marek Vasut
2013-07-02 12:49     ` Alexandre Belloni
2013-07-02 16:13       ` Marek Vasut
2013-07-02 16:37         ` Otavio Salvador
2013-07-02 17:36           ` Marek Vasut
2013-07-02 17:42             ` Otavio Salvador
2013-07-02 17:55               ` Marek Vasut
2013-07-03  9:25                 ` Hector Palacios
2013-07-03 11:38                   ` Marek Vasut
2013-07-03 13:58                     ` Hector Palacios
2013-07-03 19:26                       ` Jonathan Cameron
2013-07-02 17:19         ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201307021958.06343.marex@denx.de \
    --to=marex@denx.de \
    --cc=fabio.estevam@freescale.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox