From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-iio@vger.kernel.org, otavio@ossystems.com.br,
Jonathan Cameron <jic23@kernel.org>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] iio: mxs-lradc: Remove useless check in read_raw
Date: Tue, 02 Jul 2013 19:19:30 +0200 [thread overview]
Message-ID: <51D30BA2.7020008@free-electrons.com> (raw)
In-Reply-To: <201307021813.18019.marex@denx.de>
Hi,
On 02/07/2013 18:13, Marek Vasut wrote:
> Dear Alexandre Belloni,
>
>> On 02/07/2013 14:03, Marek Vasut wrote:
>>> Dear Alexandre Belloni,
>>>
>>>> Dear Marek,
>>>>
>>>> I don't seem to be hitting that issue. I'm using 3.10rc7. Do you know
>>>> how to reproduce it ?
>>>
>>> The check is just redundant, it's not a bug.
>>
>> Ok, that's what I understood first but then got confused by reports of
>> it solving a bug.
>
> It cannot solve a thing. If it does, then we have a problem.
>
> What kind of bug do you see ? How can I replicate it ? Can you send me a
> testcase?
>
It doesn't solve anything on my side, I never saw any issue with that
code. I was surprised by those reports though:
http://marc.info/?l=linux-iio&m=137275710622191&w=2
http://marc.info/?l=linux-iio&m=137273629716559&w=2
Hector and Otavio seem to be the ones with an issue ;)
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-07-02 17:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 0:08 [PATCH] iio: mxs-lradc: Remove useless check in read_raw Marek Vasut
2013-07-02 3:38 ` Otavio Salvador
2013-07-02 17:58 ` Marek Vasut
2013-07-02 9:19 ` Hector Palacios
2013-07-02 11:43 ` Alexandre Belloni
2013-07-02 11:53 ` Otavio Salvador
2013-07-02 12:03 ` Marek Vasut
2013-07-02 12:49 ` Alexandre Belloni
2013-07-02 16:13 ` Marek Vasut
2013-07-02 16:37 ` Otavio Salvador
2013-07-02 17:36 ` Marek Vasut
2013-07-02 17:42 ` Otavio Salvador
2013-07-02 17:55 ` Marek Vasut
2013-07-03 9:25 ` Hector Palacios
2013-07-03 11:38 ` Marek Vasut
2013-07-03 13:58 ` Hector Palacios
2013-07-03 19:26 ` Jonathan Cameron
2013-07-02 17:19 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D30BA2.7020008@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=fabio.estevam@freescale.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox