* [PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set
@ 2019-06-06 2:05 Fabio Estevam
2019-06-06 3:24 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2019-06-06 2:05 UTC (permalink / raw)
To: jic23
Cc: lars, Michael.Hennerich, rdunlap, linux-iio, gregkh, devel, preid,
Fabio Estevam
On x86_64 when GPIOLIB is not set the following build errors
are seen:
drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
drivers/staging/iio/addac/adt7316.c:1805:2: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration]
These functions are provided by the <linux/gpio/consumer.h>
and <linux/irq.h> headers, so include them to fix these
build errors.
While at it, remove <linux/gpio.h> as this driver is a GPIO
consumer and not a GPIO driver.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Remove <linux/gpio.h> - Phil
drivers/staging/iio/addac/adt7316.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 37ce563cb0e1..9cb3d0e42c38 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -6,7 +6,8 @@
*/
#include <linux/interrupt.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
+#include <linux/irq.h>
#include <linux/workqueue.h>
#include <linux/device.h>
#include <linux/kernel.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set
2019-06-06 2:05 [PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set Fabio Estevam
@ 2019-06-06 3:24 ` Randy Dunlap
2019-06-08 11:55 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2019-06-06 3:24 UTC (permalink / raw)
To: Fabio Estevam, jic23
Cc: lars, Michael.Hennerich, linux-iio, gregkh, devel, preid
On 6/5/19 7:05 PM, Fabio Estevam wrote:
> On x86_64 when GPIOLIB is not set the following build errors
> are seen:
>
> drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> drivers/staging/iio/addac/adt7316.c:1805:2: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration]
>
> These functions are provided by the <linux/gpio/consumer.h>
> and <linux/irq.h> headers, so include them to fix these
> build errors.
>
> While at it, remove <linux/gpio.h> as this driver is a GPIO
> consumer and not a GPIO driver.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> Changes since v1:
> - Remove <linux/gpio.h> - Phil
>
> drivers/staging/iio/addac/adt7316.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 37ce563cb0e1..9cb3d0e42c38 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -6,7 +6,8 @@
> */
>
> #include <linux/interrupt.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/irq.h>
> #include <linux/workqueue.h>
> #include <linux/device.h>
> #include <linux/kernel.h>
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set
2019-06-06 3:24 ` Randy Dunlap
@ 2019-06-08 11:55 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-06-08 11:55 UTC (permalink / raw)
To: Randy Dunlap
Cc: Fabio Estevam, lars, Michael.Hennerich, linux-iio, gregkh, devel,
preid
On Wed, 5 Jun 2019 20:24:09 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 6/5/19 7:05 PM, Fabio Estevam wrote:
> > On x86_64 when GPIOLIB is not set the following build errors
> > are seen:
> >
> > drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> > drivers/staging/iio/addac/adt7316.c:1805:2: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration]
> >
> > These functions are provided by the <linux/gpio/consumer.h>
> > and <linux/irq.h> headers, so include them to fix these
> > build errors.
> >
> > While at it, remove <linux/gpio.h> as this driver is a GPIO
> > consumer and not a GPIO driver.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Applied to the fixes-togreg branch of iio.git.
thanks,
Jonathan
>
> Thanks.
>
> > ---
> > Changes since v1:
> > - Remove <linux/gpio.h> - Phil
> >
> > drivers/staging/iio/addac/adt7316.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> > index 37ce563cb0e1..9cb3d0e42c38 100644
> > --- a/drivers/staging/iio/addac/adt7316.c
> > +++ b/drivers/staging/iio/addac/adt7316.c
> > @@ -6,7 +6,8 @@
> > */
> >
> > #include <linux/interrupt.h>
> > -#include <linux/gpio.h>
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/irq.h>
> > #include <linux/workqueue.h>
> > #include <linux/device.h>
> > #include <linux/kernel.h>
> >
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-08 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-06 2:05 [PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set Fabio Estevam
2019-06-06 3:24 ` Randy Dunlap
2019-06-08 11:55 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox