From: Alexandru Lazar <alazar@startmail.com>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com,
Alexandru Lazar <alazar@startmail.com>
Subject: [PATCH 0/2] Maxim MAX1241 driver, v2
Date: Wed, 18 Mar 2020 22:28:35 +0200 [thread overview]
Message-ID: <20200318202837.512428-1-alazar@startmail.com> (raw)
Hello again,
Here's version 2 of a patch series which adds support for the Maxim
MAX1241, a 12-bit, single-channel, SPI-connected ADC. The previous
version is here:
https://lore.kernel.org/linux-iio/20200317201710.23180-1-alazar@startmail.com/
I've integrated pretty much all of the suggestions I got here, and fixed
the issues that you all pointed out (thanks again! Did I say thanks
lately? Thanks!!!). A short list of the changes is at the end of this
message. checkpatch.pl is happy, it just warns me about the MAINTAINERS
file, where I don't think an entry is necessary. dt_bindings_check is
happy, too.
The only suggestion that I haven't incorporated is adding max1240 to the
list of compatible devices. I've thought about it, but there are
timing-related differences between the two devices, so simply validating
what my machine sends wouldn't be definitive. I think it would be
disingenious to claim compatibility under these circumstances. I do plan
to get a 1240 asap, anyway, and with any luck my patch would just update
the compat string.
Now, here's what I changed:
* Removed useeless header includes
* Dropped needlessly verbose stuff in _read and _probe functions
* Dropped useless GPL notice
* Lowered log level of shdn pin status in probe function, now it's
dev_dbg
* Added proper error checking for the GPIO shutdown pin
* remove now always returns zero (man, I've been wrong about this for
*years* now...)
* Added regulator disable action, cleanup is now handled via devm
* Drop delay_usecs, use delay.value, delay.unit
* Drop config_of, of_match_ptr call
* Dropped IIO_BUFFER, IIO_TRIGGERED_BUFFER dependencies, set SPI_MASTER
as dependency, fix indenting.
* DT binding: use correct id, add reg description (looks pretty
standard), dropped spi-max-frequency, fixed dt_binding_check
complaints (oops!)
Thanks!
Alex
Alexandru Lazar (2):
iio: adc: Add MAX1241 driver
dt-bindings: iio: adc: Add MAX1241 device tree bindings in
documentation
.../bindings/iio/adc/maxim,max1241.yaml | 62 ++++++
drivers/iio/adc/Kconfig | 10 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/max1241.c | 206 ++++++++++++++++++
4 files changed, 279 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
create mode 100644 drivers/iio/adc/max1241.c
--
2.25.1
next reply other threads:[~2020-03-18 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 20:28 Alexandru Lazar [this message]
2020-03-18 20:28 ` [PATCH 1/2] iio: adc: Add MAX1241 driver Alexandru Lazar
2020-03-19 6:51 ` Ardelean, Alexandru
2020-03-18 20:28 ` [PATCH 2/2] dt-bindings: iio: adc: Add MAX1241 device tree bindings in documentation Alexandru Lazar
2020-03-19 7:31 ` [PATCH 0/2] Maxim MAX1241 driver, v2 Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318202837.512428-1-alazar@startmail.com \
--to=alazar@startmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox