* [PATCH] iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device
@ 2020-03-13 18:06 Lorenzo Bianconi
2020-03-17 13:08 ` Vitor Soares
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Bianconi @ 2020-03-13 18:06 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, lorenzo.bianconi, mario.tesi, vitor.soares
flush hw FIFO before device reset in order to avoid possible races
on interrupt line 1. If the first interrupt line is asserted during
hw reset the device will work in I3C-only mode (if it is supported)
Fixes: 801a6e0af0c6 ("iio: imu: st_lsm6dsx: add support to LSM6DSO")
Fixes: 43901008fde0 ("iio: imu: st_lsm6dsx: add support to LSM6DSR")
Reported-by: Mario Tesi <mario.tesi@st.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
This is a new version of: "iio: imu: st_lsm6dsx: disable I3C support during
device reset"
https://patchwork.kernel.org/patch/11425389/
---
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 24 +++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
index 84d219ae6aee..4426524b59f2 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
@@ -2036,11 +2036,21 @@ static int st_lsm6dsx_init_hw_timer(struct st_lsm6dsx_hw *hw)
return 0;
}
-static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
+static int st_lsm6dsx_reset_device(struct st_lsm6dsx_hw *hw)
{
const struct st_lsm6dsx_reg *reg;
int err;
+ /*
+ * flush hw FIFO before device reset in order to avoid
+ * possible races on interrupt line 1. If the first interrupt
+ * line is asserted during hw reset the device will work in
+ * I3C-only mode (if it is supported)
+ */
+ err = st_lsm6dsx_flush_fifo(hw);
+ if (err < 0 && err != -ENOTSUPP)
+ return err;
+
/* device sw reset */
reg = &hw->settings->reset;
err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
@@ -2059,6 +2069,18 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
msleep(50);
+ return 0;
+}
+
+static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
+{
+ const struct st_lsm6dsx_reg *reg;
+ int err;
+
+ err = st_lsm6dsx_reset_device(hw);
+ if (err < 0)
+ return err;
+
/* enable Block Data Update */
reg = &hw->settings->bdu;
err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
--
2.24.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device
2020-03-13 18:06 [PATCH] iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device Lorenzo Bianconi
@ 2020-03-17 13:08 ` Vitor Soares
2020-04-04 16:29 ` Lorenzo Bianconi
0 siblings, 1 reply; 6+ messages in thread
From: Vitor Soares @ 2020-03-17 13:08 UTC (permalink / raw)
To: Lorenzo Bianconi, jic23@kernel.org
Cc: linux-iio@vger.kernel.org, lorenzo.bianconi@redhat.com,
mario.tesi@st.com
Hi Lorenzo,
From: Lorenzo Bianconi <lorenzo@kernel.org>
Date: Fri, Mar 13, 2020 at 18:06:00
> flush hw FIFO before device reset in order to avoid possible races
> on interrupt line 1. If the first interrupt line is asserted during
> hw reset the device will work in I3C-only mode (if it is supported)
>
> Fixes: 801a6e0af0c6 ("iio: imu: st_lsm6dsx: add support to LSM6DSO")
> Fixes: 43901008fde0 ("iio: imu: st_lsm6dsx: add support to LSM6DSR")
> Reported-by: Mario Tesi <mario.tesi@st.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> This is a new version of: "iio: imu: st_lsm6dsx: disable I3C support during
> device reset"
> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11425389_&d=DwIDAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=d7oUzE4fWeY3JqYqqd-uW_v1SJkij_sOpXRvpm3-Thg&s=BEgROrIZoG9oGrwQEENFz0DP88VioXUhpeZP2Y168XI&e=
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 24 +++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index 84d219ae6aee..4426524b59f2 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -2036,11 +2036,21 @@ static int st_lsm6dsx_init_hw_timer(struct st_lsm6dsx_hw *hw)
> return 0;
> }
>
> -static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> +static int st_lsm6dsx_reset_device(struct st_lsm6dsx_hw *hw)
> {
> const struct st_lsm6dsx_reg *reg;
> int err;
>
> + /*
> + * flush hw FIFO before device reset in order to avoid
> + * possible races on interrupt line 1. If the first interrupt
> + * line is asserted during hw reset the device will work in
> + * I3C-only mode (if it is supported)
> + */
> + err = st_lsm6dsx_flush_fifo(hw);
> + if (err < 0 && err != -ENOTSUPP)
> + return err;
> +
> /* device sw reset */
> reg = &hw->settings->reset;
> err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> @@ -2059,6 +2069,18 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
>
> msleep(50);
>
> + return 0;
> +}
> +
> +static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> +{
> + const struct st_lsm6dsx_reg *reg;
> + int err;
> +
> + err = st_lsm6dsx_reset_device(hw);
> + if (err < 0)
> + return err;
> +
> /* enable Block Data Update */
> reg = &hw->settings->bdu;
> err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> --
> 2.24.1
I tested the patch and the I3C interface is working fine in this version.
Reviewed-by: Vitor Soares <vitor.soares@synopsys.com>
Tested-by: Vitor Soares <vitor.soares@synopsys.com>
Best regards,
Vitor
Soares
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device
2020-03-17 13:08 ` Vitor Soares
@ 2020-04-04 16:29 ` Lorenzo Bianconi
2020-04-04 17:06 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Bianconi @ 2020-04-04 16:29 UTC (permalink / raw)
To: jic23@kernel.org
Cc: Lorenzo Bianconi, linux-iio@vger.kernel.org, mario.tesi@st.com,
Vitor Soares
>
> Hi Lorenzo,
>
> From: Lorenzo Bianconi <lorenzo@kernel.org>
> Date: Fri, Mar 13, 2020 at 18:06:00
>
> > flush hw FIFO before device reset in order to avoid possible races
> > on interrupt line 1. If the first interrupt line is asserted during
> > hw reset the device will work in I3C-only mode (if it is supported)
> >
Hi Jonathan,
any news about this patch? Maybe I am wrong but I am not able to find
it in your tree.
Thanks in advance.
Regards,
Lorenzo
> > Fixes: 801a6e0af0c6 ("iio: imu: st_lsm6dsx: add support to LSM6DSO")
> > Fixes: 43901008fde0 ("iio: imu: st_lsm6dsx: add support to LSM6DSR")
> > Reported-by: Mario Tesi <mario.tesi@st.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > This is a new version of: "iio: imu: st_lsm6dsx: disable I3C support during
> > device reset"
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11425389_&d=DwIDAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=d7oUzE4fWeY3JqYqqd-uW_v1SJkij_sOpXRvpm3-Thg&s=BEgROrIZoG9oGrwQEENFz0DP88VioXUhpeZP2Y168XI&e=
> > ---
> > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 24 +++++++++++++++++++-
> > 1 file changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > index 84d219ae6aee..4426524b59f2 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > @@ -2036,11 +2036,21 @@ static int st_lsm6dsx_init_hw_timer(struct st_lsm6dsx_hw *hw)
> > return 0;
> > }
> >
> > -static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > +static int st_lsm6dsx_reset_device(struct st_lsm6dsx_hw *hw)
> > {
> > const struct st_lsm6dsx_reg *reg;
> > int err;
> >
> > + /*
> > + * flush hw FIFO before device reset in order to avoid
> > + * possible races on interrupt line 1. If the first interrupt
> > + * line is asserted during hw reset the device will work in
> > + * I3C-only mode (if it is supported)
> > + */
> > + err = st_lsm6dsx_flush_fifo(hw);
> > + if (err < 0 && err != -ENOTSUPP)
> > + return err;
> > +
> > /* device sw reset */
> > reg = &hw->settings->reset;
> > err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> > @@ -2059,6 +2069,18 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> >
> > msleep(50);
> >
> > + return 0;
> > +}
> > +
> > +static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > +{
> > + const struct st_lsm6dsx_reg *reg;
> > + int err;
> > +
> > + err = st_lsm6dsx_reset_device(hw);
> > + if (err < 0)
> > + return err;
> > +
> > /* enable Block Data Update */
> > reg = &hw->settings->bdu;
> > err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> > --
> > 2.24.1
>
> I tested the patch and the I3C interface is working fine in this version.
>
> Reviewed-by: Vitor Soares <vitor.soares@synopsys.com>
> Tested-by: Vitor Soares <vitor.soares@synopsys.com>
>
> Best regards,
> Vitor
> Soares
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device
2020-04-04 16:29 ` Lorenzo Bianconi
@ 2020-04-04 17:06 ` Jonathan Cameron
2020-04-04 17:09 ` Lorenzo Bianconi
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2020-04-04 17:06 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Lorenzo Bianconi, linux-iio@vger.kernel.org, mario.tesi@st.com,
Vitor Soares
On Sat, 4 Apr 2020 18:29:25 +0200
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> >
> > Hi Lorenzo,
> >
> > From: Lorenzo Bianconi <lorenzo@kernel.org>
> > Date: Fri, Mar 13, 2020 at 18:06:00
> >
> > > flush hw FIFO before device reset in order to avoid possible races
> > > on interrupt line 1. If the first interrupt line is asserted during
> > > hw reset the device will work in I3C-only mode (if it is supported)
> > >
>
> Hi Jonathan,
>
> any news about this patch? Maybe I am wrong but I am not able to find
> it in your tree.
> Thanks in advance.
I'm running a bit behind on catching up with fixes after it became obvious
they wouldn't make the merge window.
Applied to the fixes-togreg branch of iio.git and marked for stable.
>
> Regards,
> Lorenzo
>
>
> > > Fixes: 801a6e0af0c6 ("iio: imu: st_lsm6dsx: add support to LSM6DSO")
> > > Fixes: 43901008fde0 ("iio: imu: st_lsm6dsx: add support to LSM6DSR")
> > > Reported-by: Mario Tesi <mario.tesi@st.com>
> > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > ---
> > > This is a new version of: "iio: imu: st_lsm6dsx: disable I3C support during
> > > device reset"
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11425389_&d=DwIDAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=d7oUzE4fWeY3JqYqqd-uW_v1SJkij_sOpXRvpm3-Thg&s=BEgROrIZoG9oGrwQEENFz0DP88VioXUhpeZP2Y168XI&e=
> > > ---
> > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 24 +++++++++++++++++++-
> > > 1 file changed, 23 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > index 84d219ae6aee..4426524b59f2 100644
> > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > @@ -2036,11 +2036,21 @@ static int st_lsm6dsx_init_hw_timer(struct st_lsm6dsx_hw *hw)
> > > return 0;
> > > }
> > >
> > > -static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > > +static int st_lsm6dsx_reset_device(struct st_lsm6dsx_hw *hw)
> > > {
> > > const struct st_lsm6dsx_reg *reg;
> > > int err;
> > >
> > > + /*
> > > + * flush hw FIFO before device reset in order to avoid
> > > + * possible races on interrupt line 1. If the first interrupt
> > > + * line is asserted during hw reset the device will work in
> > > + * I3C-only mode (if it is supported)
> > > + */
> > > + err = st_lsm6dsx_flush_fifo(hw);
> > > + if (err < 0 && err != -ENOTSUPP)
> > > + return err;
> > > +
> > > /* device sw reset */
> > > reg = &hw->settings->reset;
> > > err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> > > @@ -2059,6 +2069,18 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > >
> > > msleep(50);
> > >
> > > + return 0;
> > > +}
> > > +
> > > +static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > > +{
> > > + const struct st_lsm6dsx_reg *reg;
> > > + int err;
> > > +
> > > + err = st_lsm6dsx_reset_device(hw);
> > > + if (err < 0)
> > > + return err;
> > > +
> > > /* enable Block Data Update */
> > > reg = &hw->settings->bdu;
> > > err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> > > --
> > > 2.24.1
> >
> > I tested the patch and the I3C interface is working fine in this version.
> >
> > Reviewed-by: Vitor Soares <vitor.soares@synopsys.com>
> > Tested-by: Vitor Soares <vitor.soares@synopsys.com>
> >
> > Best regards,
> > Vitor
> > Soares
> >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device
2020-04-04 17:06 ` Jonathan Cameron
@ 2020-04-04 17:09 ` Lorenzo Bianconi
2020-04-05 9:26 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Bianconi @ 2020-04-04 17:09 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lorenzo Bianconi, linux-iio@vger.kernel.org, mario.tesi@st.com,
Vitor Soares
>
> On Sat, 4 Apr 2020 18:29:25 +0200
> Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
>
> > >
> > > Hi Lorenzo,
> > >
> > > From: Lorenzo Bianconi <lorenzo@kernel.org>
> > > Date: Fri, Mar 13, 2020 at 18:06:00
> > >
> > > > flush hw FIFO before device reset in order to avoid possible races
> > > > on interrupt line 1. If the first interrupt line is asserted during
> > > > hw reset the device will work in I3C-only mode (if it is supported)
> > > >
> >
> > Hi Jonathan,
> >
> > any news about this patch? Maybe I am wrong but I am not able to find
> > it in your tree.
> > Thanks in advance.
>
> I'm running a bit behind on catching up with fixes after it became obvious
> they wouldn't make the merge window.
>
> Applied to the fixes-togreg branch of iio.git and marked for stable.
>
ack, thx...sorry for all the noise around it.
Regards,
Lorenzo
> >
> > Regards,
> > Lorenzo
> >
> >
> > > > Fixes: 801a6e0af0c6 ("iio: imu: st_lsm6dsx: add support to LSM6DSO")
> > > > Fixes: 43901008fde0 ("iio: imu: st_lsm6dsx: add support to LSM6DSR")
> > > > Reported-by: Mario Tesi <mario.tesi@st.com>
> > > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > > ---
> > > > This is a new version of: "iio: imu: st_lsm6dsx: disable I3C support during
> > > > device reset"
> > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11425389_&d=DwIDAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=d7oUzE4fWeY3JqYqqd-uW_v1SJkij_sOpXRvpm3-Thg&s=BEgROrIZoG9oGrwQEENFz0DP88VioXUhpeZP2Y168XI&e=
> > > > ---
> > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 24 +++++++++++++++++++-
> > > > 1 file changed, 23 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > index 84d219ae6aee..4426524b59f2 100644
> > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > @@ -2036,11 +2036,21 @@ static int st_lsm6dsx_init_hw_timer(struct st_lsm6dsx_hw *hw)
> > > > return 0;
> > > > }
> > > >
> > > > -static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > > > +static int st_lsm6dsx_reset_device(struct st_lsm6dsx_hw *hw)
> > > > {
> > > > const struct st_lsm6dsx_reg *reg;
> > > > int err;
> > > >
> > > > + /*
> > > > + * flush hw FIFO before device reset in order to avoid
> > > > + * possible races on interrupt line 1. If the first interrupt
> > > > + * line is asserted during hw reset the device will work in
> > > > + * I3C-only mode (if it is supported)
> > > > + */
> > > > + err = st_lsm6dsx_flush_fifo(hw);
> > > > + if (err < 0 && err != -ENOTSUPP)
> > > > + return err;
> > > > +
> > > > /* device sw reset */
> > > > reg = &hw->settings->reset;
> > > > err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> > > > @@ -2059,6 +2069,18 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > > >
> > > > msleep(50);
> > > >
> > > > + return 0;
> > > > +}
> > > > +
> > > > +static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > > > +{
> > > > + const struct st_lsm6dsx_reg *reg;
> > > > + int err;
> > > > +
> > > > + err = st_lsm6dsx_reset_device(hw);
> > > > + if (err < 0)
> > > > + return err;
> > > > +
> > > > /* enable Block Data Update */
> > > > reg = &hw->settings->bdu;
> > > > err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> > > > --
> > > > 2.24.1
> > >
> > > I tested the patch and the I3C interface is working fine in this version.
> > >
> > > Reviewed-by: Vitor Soares <vitor.soares@synopsys.com>
> > > Tested-by: Vitor Soares <vitor.soares@synopsys.com>
> > >
>
> > > Best regards,
> > > Vitor
> > > Soares
> > >
> > >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device
2020-04-04 17:09 ` Lorenzo Bianconi
@ 2020-04-05 9:26 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-04-05 9:26 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Lorenzo Bianconi, linux-iio@vger.kernel.org, mario.tesi@st.com,
Vitor Soares
On Sat, 4 Apr 2020 19:09:18 +0200
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> >
> > On Sat, 4 Apr 2020 18:29:25 +0200
> > Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> >
> > > >
> > > > Hi Lorenzo,
> > > >
> > > > From: Lorenzo Bianconi <lorenzo@kernel.org>
> > > > Date: Fri, Mar 13, 2020 at 18:06:00
> > > >
> > > > > flush hw FIFO before device reset in order to avoid possible races
> > > > > on interrupt line 1. If the first interrupt line is asserted during
> > > > > hw reset the device will work in I3C-only mode (if it is supported)
> > > > >
> > >
> > > Hi Jonathan,
> > >
> > > any news about this patch? Maybe I am wrong but I am not able to find
> > > it in your tree.
> > > Thanks in advance.
> >
> > I'm running a bit behind on catching up with fixes after it became obvious
> > they wouldn't make the merge window.
> >
> > Applied to the fixes-togreg branch of iio.git and marked for stable.
> >
>
> ack, thx...sorry for all the noise around it.
No problem - it reminded me to actually do something about this and other
patches in the same position ;)
Jonathan
>
> Regards,
> Lorenzo
>
> > >
> > > Regards,
> > > Lorenzo
> > >
> > >
> > > > > Fixes: 801a6e0af0c6 ("iio: imu: st_lsm6dsx: add support to LSM6DSO")
> > > > > Fixes: 43901008fde0 ("iio: imu: st_lsm6dsx: add support to LSM6DSR")
> > > > > Reported-by: Mario Tesi <mario.tesi@st.com>
> > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > > > ---
> > > > > This is a new version of: "iio: imu: st_lsm6dsx: disable I3C support during
> > > > > device reset"
> > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11425389_&d=DwIDAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=d7oUzE4fWeY3JqYqqd-uW_v1SJkij_sOpXRvpm3-Thg&s=BEgROrIZoG9oGrwQEENFz0DP88VioXUhpeZP2Y168XI&e=
> > > > > ---
> > > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 24 +++++++++++++++++++-
> > > > > 1 file changed, 23 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > > index 84d219ae6aee..4426524b59f2 100644
> > > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > > @@ -2036,11 +2036,21 @@ static int st_lsm6dsx_init_hw_timer(struct st_lsm6dsx_hw *hw)
> > > > > return 0;
> > > > > }
> > > > >
> > > > > -static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > > > > +static int st_lsm6dsx_reset_device(struct st_lsm6dsx_hw *hw)
> > > > > {
> > > > > const struct st_lsm6dsx_reg *reg;
> > > > > int err;
> > > > >
> > > > > + /*
> > > > > + * flush hw FIFO before device reset in order to avoid
> > > > > + * possible races on interrupt line 1. If the first interrupt
> > > > > + * line is asserted during hw reset the device will work in
> > > > > + * I3C-only mode (if it is supported)
> > > > > + */
> > > > > + err = st_lsm6dsx_flush_fifo(hw);
> > > > > + if (err < 0 && err != -ENOTSUPP)
> > > > > + return err;
> > > > > +
> > > > > /* device sw reset */
> > > > > reg = &hw->settings->reset;
> > > > > err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> > > > > @@ -2059,6 +2069,18 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > > > >
> > > > > msleep(50);
> > > > >
> > > > > + return 0;
> > > > > +}
> > > > > +
> > > > > +static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
> > > > > +{
> > > > > + const struct st_lsm6dsx_reg *reg;
> > > > > + int err;
> > > > > +
> > > > > + err = st_lsm6dsx_reset_device(hw);
> > > > > + if (err < 0)
> > > > > + return err;
> > > > > +
> > > > > /* enable Block Data Update */
> > > > > reg = &hw->settings->bdu;
> > > > > err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
> > > > > --
> > > > > 2.24.1
> > > >
> > > > I tested the patch and the I3C interface is working fine in this version.
> > > >
> > > > Reviewed-by: Vitor Soares <vitor.soares@synopsys.com>
> > > > Tested-by: Vitor Soares <vitor.soares@synopsys.com>
> > > >
> >
> > > > Best regards,
> > > > Vitor
> > > > Soares
> > > >
> > > >
> > >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-05 9:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-13 18:06 [PATCH] iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device Lorenzo Bianconi
2020-03-17 13:08 ` Vitor Soares
2020-04-04 16:29 ` Lorenzo Bianconi
2020-04-04 17:06 ` Jonathan Cameron
2020-04-04 17:09 ` Lorenzo Bianconi
2020-04-05 9:26 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox